On Thu, 2019-10-31 at 16:59 +0100, Javier Martinez Canillas wrote:
> On 10/31/19 12:56 PM, Vladimir 'phcoder' Serbinenko wrote:
> > This patch looks incomplete. What if "chosen" is there but does not contain
> > the relevant fields?
> >
>
> My understanding is that if there's a chosen node alread
On 10/31/19 12:56 PM, Vladimir 'phcoder' Serbinenko wrote:
> This patch looks incomplete. What if "chosen" is there but does not contain
> the relevant fields?
>
My understanding is that if there's a chosen node already defined in the
Device Tree but without #address-cells and #size-cells properti
This patch looks incomplete. What if "chosen" is there but does not contain
the relevant fields?
On Thu, 31 Oct 2019, 11:39 Javier Martinez Canillas,
wrote:
> From: Mark Salter
>
> Recent upstream changes to kexec-tools relies on #address-cells
> and #size-cells properties in the FDT. If grub2
This patch LGTM
On Wed, 30 Oct 2019, 11:49 Javier Martinez Canillas,
wrote:
> From: Peter Jones
>
> Currently grub-editenv and related tools are not able to follow symbolic
> links when finding their config file. For example the grub-editenv create
> command will wrongly overwrite a symlink in
Having // at the beginning of the path may have special meaning according
to posix. I don't know if it applies in particular case and if the special
meaning is useful for grub to begin with, just something to check
On Thu, 31 Oct 2019, 11:37 Javier Martinez Canillas,
wrote:
> From: Lenny Szubowi
Please don't chain swap_bytes32 with le_to_cpu32 as it's a less readable
equivalent of be_to_cpu32
On Thu, 31 Oct 2019, 11:38 Javier Martinez Canillas,
wrote:
> From: Masahiro Matsuya
>
> The netmask configured in firmware is not respected on ppc64 (big endian).
> When 255.255.252.0 is set as n
From: Mark Salter
Recent upstream changes to kexec-tools relies on #address-cells
and #size-cells properties in the FDT. If grub2 needs to create
a chosen node, it is likely because firmware did not provide one.
In that case, set #address-cells and #size-cells properties to
make sure they exist.
From: Masahiro Matsuya
The netmask configured in firmware is not respected on ppc64 (big endian).
When 255.255.252.0 is set as netmask in firmware, the following is the
value of bootpath string in grub_ieee1275_parse_bootpath().
/vdevice/l-lan@3002:speed=auto,duplex=auto,192.168.88.10,,192
From: Lenny Szubowicz
Some tftp servers do not handle multiple consecutive slashes correctly;
this patch avoids sending tftp requests with non-normalized paths.
Signed-off-by: Lenny Szubowicz
Signed-off-by: Mark Salter
Signed-off-by: Javier Martinez Canillas
---
grub-core/net/tftp.c | 28 ++
