[PATCH 2/2] install: Add only-platform-installation option.

Hello again, I've tested this patch on BIOS x86 (on a vm) and x86_64 EFI. Surely it does extra work, plenty of checks and string allocations are not needed at all, because it skips only calls that write files into grubdir or platdir (not macppcdir nor efidir). What do you think? Refactoring the

Re: [PATCH v2 2/2] Make editenv chase symlinks including those across devices

Hello Daniel, Thanks a lot for pointing out these issues. I'll fix them in v2. >> + >> + linkbuf = xmalloc (size+1); > > Please check for NULL here. And "size + 1". In general I will not accept > any patch which does not check for NULL for malloc() et consortes. > Yes, I'll be more carefu

Re: [PATCH] tpm: Pass unknown error as non-fatal, but debug print the error we got

Adding Matthew... Matthew, whole thread is at [1]. Daniel [1] https://lists.gnu.org/archive/html/grub-devel/2019-10/msg00103.html On Fri, Oct 25, 2019 at 10:48:43AM -0400, Mathieu Trudel-Lapierre wrote: > On Fri, Oct 25, 2019 at 10:28 AM Mathieu Trudel-Lapierre > wrote: > > > > Signed-off-by:

Re: [PATCH v4 4/5] normal/main: Search for specific config files for netboot

On 10/28/19 4:13 PM, Daniel Kiper wrote: > On Wed, Oct 23, 2019 at 03:00:32PM +0200, Javier Martinez Canillas wrote: >> From: Paulo Flabiano Smorigo >> >> This patch implements a search for a specific configuration when the config >> file is on a remoteserver. It uses the following order: >>1)

Re: Transfering Data from GRUB to userspace?

Hi Max, On Mon, Oct 28, 2019 at 10:58:21AM +, Max Tottenham via Grub-devel wrote: > Hi Folks > > I've often found myself in a position where I've needed to perform some > debugging of remote hardware that does not have a network accessible KVM > attached. To that end, being able to remotely lo

Re: [PATCH v4 3/5] net/dhcp: Set net__client{id, uuid} variables from DHCP options

On 10/28/19 3:54 PM, Daniel Kiper wrote: > On Wed, Oct 23, 2019 at 03:00:31PM +0200, Javier Martinez Canillas wrote: >> From: Paulo Flabiano Smorigo >> >> This patch sets a net__clientid and net__clientuuid >> GRUB environment variables, using the DHCP client ID and UUID options if >> these are f

Re: [PATCH v2 2/2] Make editenv chase symlinks including those across devices

On Mon, Oct 28, 2019 at 02:11:10PM +0100, Javier Martinez Canillas wrote: > From: Peter Jones > > The grub-editenv create command will wrongly overwrite /boot/grub2/grubenv > with a regular file if grubenv is a symbolic link. But instead, it should > create a new file in the path the symlink point

Re: [PATCH v4 4/5] normal/main: Search for specific config files for netboot

On Wed, Oct 23, 2019 at 03:00:32PM +0200, Javier Martinez Canillas wrote: > From: Paulo Flabiano Smorigo > > This patch implements a search for a specific configuration when the config > file is on a remoteserver. It uses the following order: >1) DHCP client UUID option. >2) MAC address (i

Re: [PATCH v4 3/5] net/dhcp: Set net__client{id, uuid} variables from DHCP options

On Wed, Oct 23, 2019 at 03:00:31PM +0200, Javier Martinez Canillas wrote: > From: Paulo Flabiano Smorigo > > This patch sets a net__clientid and net__clientuuid > GRUB environment variables, using the DHCP client ID and UUID options if > these are found. > > In the same way than net__ variables ar

Re: [PATCH 2/2] Make editenv chase symlinks including those across devices.

On 10/23/19 11:42 AM, Daniel Kiper wrote: > On Fri, Oct 18, 2019 at 02:42:21PM +0200, Javier Martinez Canillas wrote: >> From: Peter Jones >> >> This lets us make /boot/grub2/grubenv a symlink to > > Who or what creates that link? > That symlink is created by the Fedora grub2-efi package. On leg

[PATCH v2 1/2] Add grub_util_readlink()

From: Peter Jones Currently grub-editenv and related tools are not able to follow symbolic links when finding their config file. For example the grub-editenv create command will wrongly overwrite a symlink in /boot/grub2/grubenv with a new regular file, instead of creating a file in the path the

[PATCH v2 2/2] Make editenv chase symlinks including those across devices

From: Peter Jones The grub-editenv create command will wrongly overwrite /boot/grub2/grubenv with a regular file if grubenv is a symbolic link. But instead, it should create a new file in the path the symlink points to. This lets /boot/grub2/grubenv be a symlink to /boot/efi/EFI/fedora/grubenv e

Re: [PATCH 1/2] Add grub_util_readlink()

Hello Daniel, On 10/23/19 11:19 AM, Daniel Kiper wrote: > On Fri, Oct 18, 2019 at 02:42:20PM +0200, Javier Martinez Canillas wrote: >> From: Peter Jones >> >> Add a grub_util_readlink() helper function. > > OK but for patches like that one I will be always asking for an explannation > in the com

Granularity of grub-install (was Re: Reproducibility of grub-install)

Hi, First of all, thank you for your comments. My answers are inline, although the bad subject was a main issue of misunderstanding. I changed it, as I think it reflects better my current idea. I'm sorry for the confusion it certainly caused. Wed, 23 Oct 2019 11:09:07 +0200 Daniel Kiper wrote

[PATCH] install: Free allocated path for grub.efi.

Hi, This patch is a minor issue, but in terms of correctness I think this free is missing. Happy hacking, Miguel >From 1720e89de777fd3a30a6824797d97855b7bb8b68 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miguel=20=C3=81ngel=20Arruga=20Vivas?= Date: Mon, 28 Oct 2019 10:08:25 +0100 Subject: [PATCH 1

Transfering Data from GRUB to userspace?

Hi Folks I've often found myself in a position where I've needed to perform some debugging of remote hardware that does not have a network accessible KVM attached. To that end, being able to remotely log into a machine and have some method of accessing GRUB2 boot time debug messages from userspace