Re: [PATCH] Enable pager by default

2019-10-22 Thread Nicholas Vinson
On 10/22/19 10:04, Daniel Kiper wrote: On Tue, Oct 22, 2019 at 10:30:20AM +0200, Javier Martinez Canillas wrote: Hello Daniel, On 10/21/19 4:56 PM, Daniel Kiper wrote: On Fri, Oct 18, 2019 at 02:43:18PM +0200, Javier Martinez Canillas wrote: From: Peter Jones When user enters into the GRU

Re: [PATCH] grub-mkconfig: use portable 'command -v' to detect installed programs

2019-10-22 Thread Eli Schwartz
On 10/21/19 11:09 AM, Daniel Kiper wrote: > On Wed, Oct 16, 2019 at 11:03:06PM -0400, Eli Schwartz wrote: >> The 'which' utility is not guaranteed to be installed either, and if it >> is, its behavior is not portable either. >> >> Conversely, the 'command -v' shell builtin is required to exist in a

Re: [PATCH v3 5/5] docs: Update info with grub.cfg netboot selection order

2019-10-22 Thread John Paul Adrian Glaubitz
On 10/22/19 4:26 PM, Daniel Kiper wrote: > On Tue, Oct 22, 2019 at 10:48:14AM +0200, Javier Martinez Canillas wrote: >> From: Robert Marshall >> >> Add documentation to the grub info page that specifies the order >> netboot clients use to select a grub configuration file. >> >> Signed-off-by: Robe

Re: [PATCH v3 2/5] net/dhcp: Consistently use hexadecimal numbers for options enum

2019-10-22 Thread Daniel Kiper
On Tue, Oct 22, 2019 at 10:48:11AM +0200, Javier Martinez Canillas wrote: > The bootp/dhcp options enum values are a mixture of hexadecimal and decimal > numbers. Change this to consistently use hexadecimal numbers for all values. > > Suggested-by: Daniel Kiper > Signed-off-by: Javier Martinez Can

Re: [PATCH v3 5/5] docs: Update info with grub.cfg netboot selection order

2019-10-22 Thread Daniel Kiper
On Tue, Oct 22, 2019 at 10:48:14AM +0200, Javier Martinez Canillas wrote: > From: Robert Marshall > > Add documentation to the grub info page that specifies the order > netboot clients use to select a grub configuration file. > > Signed-off-by: Robert Marshall > Signed-off-by: Javier Martinez Can

Re: [PATCH] Enable pager by default

2019-10-22 Thread Daniel Kiper
On Tue, Oct 22, 2019 at 10:30:20AM +0200, Javier Martinez Canillas wrote: > Hello Daniel, > > On 10/21/19 4:56 PM, Daniel Kiper wrote: > > On Fri, Oct 18, 2019 at 02:43:18PM +0200, Javier Martinez Canillas wrote: > >> From: Peter Jones > >> > >> When user enters into the GRUB shell and tries to us

[PATCH v3 3/5] net/dhcp: Set net__client{id, uuid} variables from DHCP options

2019-10-22 Thread Javier Martinez Canillas
From: Paulo Flabiano Smorigo This patch sets a net__clientid and net__clientuuid GRUB environment variables, using the DHCP client ID and UUID options if these are found. In the same way than net__ variables are set for other options such domain name, boot file, next server, etc. Signed-off-by:

[PATCH v3 4/5] normal/main: Search for specific config files for netboot

2019-10-22 Thread Javier Martinez Canillas
From: Paulo Flabiano Smorigo This patch implements a search for a specific configuration when the config file is on a remoteserver. It uses the following order: 1) DHCP client UUID option. 2) MAC address (in lower case hexadecimal with dash separators); 3) IP (in upper case hexadecimal)

[PATCH v3 5/5] docs: Update info with grub.cfg netboot selection order

2019-10-22 Thread Javier Martinez Canillas
From: Robert Marshall Add documentation to the grub info page that specifies the order netboot clients use to select a grub configuration file. Signed-off-by: Robert Marshall Signed-off-by: Javier Martinez Canillas --- Changes in v3: - Add a patch documenting the grub.cfg netboot selection o

[PATCH v3 1/5] Add %X option to printf functions

2019-10-22 Thread Javier Martinez Canillas
From: Paulo Flabiano Smorigo The printf(3) function has support for the %X format specifier, to output an unsigned hexadecimal integer in uppercase. This can be achived in GRUB using the %x format specifier in grub_printf() and calling grub_toupper(), but it is more convenient if there is suppor

[PATCH v3 0/5] Search for specific config files using UUID, MAC and IP

2019-10-22 Thread Javier Martinez Canillas
Hello, This is a v3 of a series that have been carried in Fedora (and other distros) for a long time. It allows to fetch GRUB configurations that are customized to each machine by using the client UUID, MAC and IP as grub.cfg suffixes. The procedure is similar to what is used by pxelinux and yabo

[PATCH v3 2/5] net/dhcp: Consistently use hexadecimal numbers for options enum

2019-10-22 Thread Javier Martinez Canillas
The bootp/dhcp options enum values are a mixture of hexadecimal and decimal numbers. Change this to consistently use hexadecimal numbers for all values. Suggested-by: Daniel Kiper Signed-off-by: Javier Martinez Canillas --- Changes in v3: - Add patch to cleanup bootp/dhcp options enum. Change

[PATCH v3] Add GRUB_DISABLE_UUID

2019-10-22 Thread Javier Martinez Canillas
From: Peter Jones The grub-mkconfig and 10_linux scripts by default attempt to use a UUID to set the root kernel command line parameter and the $root GRUB environment variable. The former can be disabled by setting the GRUB_DISABLE_LINUX_UUID variable to "true", but there is currently no way to

Re: [PATCH] Enable pager by default

2019-10-22 Thread Javier Martinez Canillas
Hello Daniel, On 10/21/19 4:56 PM, Daniel Kiper wrote: > On Fri, Oct 18, 2019 at 02:43:18PM +0200, Javier Martinez Canillas wrote: >> From: Peter Jones >> >> When user enters into the GRUB shell and tries to use help command, lot of >> information is scrolled out of screen and the user doesn't ha

Re: [PATCH] Update to minilzo-2.08

2019-10-22 Thread Javier Martinez Canillas
Hello Daniel, On 10/21/19 4:48 PM, Daniel Kiper wrote: > On Fri, Oct 18, 2019 at 02:45:13PM +0200, Javier Martinez Canillas wrote: >> From: Peter Jones >> >> This fixes CVE-2014-4607 - lzo: lzo1x_decompress_safe() integer overflow >> >> Resolves: http://savannah.gnu.org/bugs/?42635 > > OK but I

Re: [PATCH v2 2/3] Set net__client{id, uuid} variables from DHCP options

2019-10-22 Thread Javier Martinez Canillas
Hello Daniel, On 10/21/19 4:40 PM, Daniel Kiper wrote: > On Fri, Oct 18, 2019 at 09:59:09AM +0200, Javier Martinez Canillas wrote: >> From: Paulo Flabiano Smorigo >> >> This patch sets a net__clientid and net__clientuuid >> GRUB environment variables, using the DHCP client ID and UUID options if

Re: [PATCH v2] Add GRUB_DISABLE_UUID

2019-10-22 Thread Javier Martinez Canillas
Hello Daniel, On 10/21/19 4:26 PM, Daniel Kiper wrote: > On Fri, Oct 04, 2019 at 12:57:44PM +0200, Javier Martinez Canillas wrote: >> Hello Nicolas, >> >> Thanks a lot for the feedback. >> >> On 10/3/19 4:29 AM, Nicholas Vinson wrote: >> >> [snip] >> > > +if [ "x${GRUB_DISABLE_UUID}" = "xt