Re: [PATCH] grub-core/commands/basic_math.c: New commands to perform basic math operations on variables

2019-07-16 Thread Vladimir 'phcoder' Serbinenko
On Tue, 16 Jul 2019, 19:15 glenn tanner, wrote: > Added new commands to add and subtract values from grub variables, was > desirable for automated testing. Compiled and tested under x86_64-efi. > > diff --git a/grub-core/Makefile.core.def b/grub-core/Makefile.core.def > index 474a63e68..c383f0157

Re: [PATCH] grub-core/commands/basic_math.c: New commands to perform basic math operations on variables

2019-07-16 Thread Vladimir 'phcoder' Serbinenko
We should rather have $[...] syntax in parser rather than ad-hoc math commands On Tue, 16 Jul 2019, 19:15 glenn tanner, wrote: > Added new commands to add and subtract values from grub variables, was > desirable for automated testing. Compiled and tested under x86_64-efi. > > diff --git a/grub-c

[PATCH] grub-core/commands/basic_math.c: New commands to perform basic math operations on variables

2019-07-16 Thread glenn tanner
Added new commands to add and subtract values from grub variables, was desirable for automated testing. Compiled and tested under x86_64-efi. diff --git a/grub-core/Makefile.core.def b/grub-core/Makefile.core.def index 474a63e68..c383f0157 100644 --- a/grub-core/Makefile.core.def +++ b/grub-core/M

Re: [PATCH] sparc64: Fix BIOS Boot Partition support

2019-07-16 Thread Eric Snowberg
> On Jul 16, 2019, at 5:35 AM, John Paul Adrian Glaubitz > wrote: > > On 7/15/19 12:40 AM, James Clarke wrote: >> Currently, gpt_offset is uninitialised when using a BIOS Boot Partition >> but is used unconditionally inside save_blocklists. Instead, ensure it >> is always initialised to 0 (note

Re: [PATCH] sparc64: Fix BIOS Boot Partition support

2019-07-16 Thread Vladimir 'phcoder' Serbinenko
LGTM. Let's give it another day on ML, then I'll commit it On Mon, Jul 15, 2019 at 12:40 AM James Clarke wrote: > > Currently, gpt_offset is uninitialised when using a BIOS Boot Partition > but is used unconditionally inside save_blocklists. Instead, ensure it > is always initialised to 0 (note t

Re: [PATCH] sparc64: Fix BIOS Boot Partition support

2019-07-16 Thread John Paul Adrian Glaubitz
On 7/15/19 12:40 AM, James Clarke wrote: > Currently, gpt_offset is uninitialised when using a BIOS Boot Partition > but is used unconditionally inside save_blocklists. Instead, ensure it > is always initialised to 0 (note that there is already separate code to > do the equivalent adjustment after

Re: [PATCH] 30_os-prober: Provide GRUB_OS_PROBER_DISABLE_DEBUG

2019-07-16 Thread Michael Chang
On Mon, Jul 15, 2019 at 05:26:55PM +0100, Colin Watson wrote: > On Mon, Jul 15, 2019 at 09:28:31AM +, Michael Chang wrote: > > This patch adds support to disable os-prober debug output while running > > grub-mkconfig through GRUB_OS_PROBER_DISABLE_DEBUG=true in simple > > configuration interfac