[PATCH v6] probe: Support probing for partition UUID with --part-uuid

2019-05-14 Thread Jacob Kroon
Linux supports root=PARTUUID= boot argument, so add support for probing it. Compared to the fs UUID, the partition UUID does not change when reformatting a partition. For now, only disks using a GPT partition table are supported. Signed-off-by: Jacob Kroon --- docs/grub.texi | 2 +-

Re: [PATCH] grub-mkconfig: Use -c instead of --printf for stat

2019-05-14 Thread Daniel Kiper
On Tue, May 14, 2019 at 11:40:55AM +0300, Ovidiu Panait wrote: > "--printf" only works with the stat variant provided by coreutils. > > With busybox, stat will fail with the following error: > stat: unrecognized option '--printf=%T' > > Usage: stat [OPTIONS] FILE... > > Signed-off-by: Ovidiu Panait

Re: [PATCH v2 7/8] travis: Add ARM thumb target to tests

2019-05-14 Thread Leif Lindholm
On Tue, May 14, 2019 at 06:32:06AM -0700, Alexander Graf wrote: > > But, wait... > > arm-linux-gnueabi is the softfloat (v5te) toolchain - if we want to > > test that, fine - but we definitely need to test arm-linux-gnueabihf. > > > > First of all, I would expect that this toolchain will not use T3

Re: [PATCH v2 1/8] travis: Run bootstrap instead of autogen.sh

2019-05-14 Thread Daniel Kiper
On Tue, May 14, 2019 at 06:17:58AM -0700, Alexander Graf wrote: > On 10.05.19 13:03, Daniel Kiper wrote: > > On Thu, May 02, 2019 at 08:55:30AM +0200, Alexander Graf wrote: > >> Commit 35b909062e7b3 ("gnulib: Upgrade Gnulib and switch to bootstrap > >> tool") > >> changed the build flow from runni

Re: [PATCH v2 8/8] travis: Test module loading from tftp as well

2019-05-14 Thread Daniel Kiper
On Tue, May 14, 2019 at 06:18:41AM -0700, Alexander Graf wrote: > On 10.05.19 13:24, Daniel Kiper wrote: > > On Thu, May 02, 2019 at 08:55:37AM +0200, Alexander Graf wrote: > >> The travis test today only uses modules that are delivered with the > >> grub.efi binary. Let's drop echo and reboot and

Re: [PATCH v2 7/8] travis: Add ARM thumb target to tests

2019-05-14 Thread Alexander Graf
On 14.05.19 12:05, Leif Lindholm wrote: > Comment here as well: > > On Thu, May 02, 2019 at 08:55:36AM +0200, Alexander Graf wrote: >> We hit an error case which only got triggered on ARM Thumb code. So >> let's make sure we test that combination as well. > This is the default for at least several

Re: [PATCH v2 8/8] travis: Test module loading from tftp as well

2019-05-14 Thread Alexander Graf
On 10.05.19 13:24, Daniel Kiper wrote: > On Thu, May 02, 2019 at 08:55:37AM +0200, Alexander Graf wrote: >> The travis test today only uses modules that are delivered with the >> grub.efi binary. Let's drop echo and reboot and see if grub can load >> them dynamically. >> >> For this, we need to e

Re: [PATCH v2 1/8] travis: Run bootstrap instead of autogen.sh

2019-05-14 Thread Alexander Graf
On 10.05.19 13:03, Daniel Kiper wrote: > On Thu, May 02, 2019 at 08:55:30AM +0200, Alexander Graf wrote: >> Commit 35b909062e7b3 ("gnulib: Upgrade Gnulib and switch to bootstrap tool") >> changed the build flow from running ./autogen.sh to running ./bootstrap >> but missed to update .travis.yml.

Re: [PATCH v2 7/8] travis: Add ARM thumb target to tests

2019-05-14 Thread Leif Lindholm
Comment here as well: On Thu, May 02, 2019 at 08:55:36AM +0200, Alexander Graf wrote: > We hit an error case which only got triggered on ARM Thumb code. So > let's make sure we test that combination as well. This is the default for at least several and possibly most ARMv7-A distributions/prebuilt

Re: [PATCH v2 6/8] travis: Add smoke tests for arm and aarch64

2019-05-14 Thread Leif Lindholm
Just noticed this hadn't been merged, so time for a comment :) On Thu, May 02, 2019 at 08:55:35AM +0200, Alexander Graf wrote: > We've had an arm regression in grub recently where grub would not even > be able to boot up anymore. So let's include arm and aarch64 in our > simple "hello world" smoke

[PATCH] grub-mkconfig: Use -c instead of --printf for stat

2019-05-14 Thread Ovidiu Panait
"--printf" only works with the stat variant provided by coreutils. With busybox, stat will fail with the following error: stat: unrecognized option '--printf=%T' Usage: stat [OPTIONS] FILE... Signed-off-by: Ovidiu Panait --- util/grub-mkconfig.in | 2 +- 1 file changed, 1 insertion(+), 1 delet

Re: grub-mkrescue: Problem with MBR partition table at start of EFI partition

2019-05-14 Thread Thomas Schmitt
Hi, Daniel Kiper wrote: > may I ask you to write a summary of your findings, A Macbook took offense from the MBR partition table entry in the EFI FAT image which grub-mkrescue produces by help of mformat(1). Vladimir stated that this partition table entry is not intentional and that the informati