Re: [PATCH] loader/i386/linux: Calculate the setup_header length

2019-03-29 Thread Ross Philipson
On 03/29/2019 11:09 AM, Daniel Kiper wrote: > From: Andrew Jeddeloh > > Previously the setup_header length was just assumed to be the size of the > linux_kernel_params struct. The linux x86 32-bit boot protocol says that > the size of the linux_i386_kernel_header is 0x202 + the byte value at 0x20

[PATCH] docs/grub-dev: Change comments rules

2019-03-29 Thread Daniel Kiper
Current comments forms are annoying, so, some of them are disallowed starting from now. New rules are more flexible and mostly aligned with, e.g., Linux kernel comments rules. Signed-off-by: Daniel Kiper --- docs/grub-dev.texi | 43 +-- 1 file changed, 29

[PATCH] loader/i386/linux: Calculate the setup_header length

2019-03-29 Thread Daniel Kiper
From: Andrew Jeddeloh Previously the setup_header length was just assumed to be the size of the linux_kernel_params struct. The linux x86 32-bit boot protocol says that the size of the linux_i386_kernel_header is 0x202 + the byte value at 0x201 in the linux_i386_kernel_header. Calculate the size

Re: [PATCH 2/2] efidisk: null pointer dereference in grub_efidisk_get_device_name

2019-03-29 Thread Daniel Kiper
On Thu, Mar 28, 2019 at 03:26:37PM -0600, Eric Snowberg wrote: > Function grub_efi_find_last_device_path may return NULL when called > from grub_efidisk_get_device_name > > Signed-off-by: Eric Snowberg Reviewed-by: Daniel Kiper Daniel ___ Grub-devel

Re: [PATCH] efidisk: write to null pointer ldp

2019-03-29 Thread Daniel Kiper
On Thu, Mar 28, 2019 at 02:32:31PM -0600, Eric Snowberg wrote: > Function grub_efi_find_last_device_path may return constant NULL when > called from find_parent_device. > > Signed-off-by: Eric Snowberg Reviewed-by: Daniel Kiper Daniel ___ Grub-devel

Re: [PATCH 1/2] efidisk: null pointer dereference in is_child

2019-03-29 Thread Daniel Kiper
On Thu, Mar 28, 2019 at 03:26:36PM -0600, Eric Snowberg wrote: > Function grub_efi_find_last_device path may return NULL when called > from is_child. > > Signed-off-by: Eric Snowberg Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-d