On Wed, Feb 27, 2019 at 09:10:08AM +, Colin Watson wrote:
>Many of GRUB's utilities don't check anywhere near all the possible
>write errors. For example, if grub-install runs out of space when
>copying a file, it won't notice. There were missing checks for the
>return values of write, fflush
syslinux_parse simplifies some filenames by removing things like ".."
segments, but the tests assumed that @abs_top_srcdir@ would be
untouched, which is not true in the case of out-of-tree builds where
@abs_top_srcdir@ may contain ".." segments.
Performing the substitution requires some awkwardnes
On Mon, Jan 14, 2019 at 02:15:14PM +0100, Daniel Kiper wrote:
> On Wed, Jan 09, 2019 at 02:59:12PM +, Colin Watson wrote:
> > +# Mimic simplify_filename from grub-core/lib/syslinux_parse.c, so that we
>
> OK, but I would like to see a comment before
> grub-core/lib/syslinux_parse.c:simplify_fi
I have a bug report that I think is best handled by importing and using
a new module from Gnulib, so I tried to do that. Unfortunately GRUB's
Gnulib import is in a confusing state that makes it difficult to do
this. The last full update was in 2013, without documentation of the
exact commit that
(Sorry for the slow response.)
On Wed, Jan 16, 2019 at 09:03:40PM +0100, Daniel Kiper wrote:
> Could you update INSTALL file too?
Done.
> Additionally, if you do such huge change could you move Gnulib from
> grub-core/gnulib to grub-core/lib/gnulib?
Ending up with grub-core/lib/gnulib/libgnu.a
Many of GRUB's utilities don't check anywhere near all the possible
write errors. For example, if grub-install runs out of space when
copying a file, it won't notice. There were missing checks for the
return values of write, fflush, fsync, and close (or the equivalents on
other OSes), all of whic
