[PATCH v2 1/1] osdep/freebsd: Fix partition calculation for EBR entries

2019-02-26 Thread James Clarke
For EBR partitions, "start" is the relative starting sector of the EBR header itself, whereas "offset" is the relative starting byte of the partition's contents, excluding the EBR header and any padding. Thus we must use "offset", and divide by the sector size to convert to sectors. Signed-off-by:

[PATCH v2 0/1] osdep/freebsd: Fix partition calculation for EBR entries

2019-02-26 Thread Colin Watson
Here's a patch from James Clarke to fix a FreeBSD partition calculation bug, originally sent to https://bugs.debian.org/923253; I've only reformatted the commit message slightly. On FreeBSD, grub uses the "start" rather than the "offset" config property to calculate the starting sector for partiti

Re: [PATCH 0/1] Fix partition offset for EBR partitions on FreeBSD

2019-02-26 Thread Colin Watson
On Tue, Feb 26, 2019 at 03:12:06PM +, Colin Watson wrote: > Here's a patch from James Clarke to fix a FreeBSD partition calculation > bug, originally sent to https://bugs.debian.org/923253; I've only > reformatted the commit message slightly. I botched the commit message a bit. I'll send a v2

Re: [PATCH] grub-install: check for arm-efi as a default target

2019-02-26 Thread Steve McIntyre
On Tue, Feb 26, 2019 at 03:55:47PM +0100, Daniel Kiper wrote: >On Tue, Feb 26, 2019 at 01:27:21PM +, Leif Lindholm wrote: >> >> As pointed out by Colin on IRC - it appears you have pushed Steves >> original submission rather than the revised one which I gave my R-b >> for. >> >> Could you addre

[PATCH 1/1] Fix partition offset for EBR partitions on FreeBSD

2019-02-26 Thread James Clarke
On FreeBSD, grub uses the "start" rather than the "offset" config property to calculate the starting sector for partitions, which gives the wrong value for EBR partitions: > root@lemon:/home/jrtc27/src/grub2/grub2-2.02+dfsg1# geom part list > (output trimmed and annotated) > Geom name: ada0 > sche

[PATCH 0/1] Fix partition offset for EBR partitions on FreeBSD

2019-02-26 Thread Colin Watson
Here's a patch from James Clarke to fix a FreeBSD partition calculation bug, originally sent to https://bugs.debian.org/923253; I've only reformatted the commit message slightly. James Clarke (1): Fix partition offset for EBR partitions on FreeBSD grub-core/osdep/freebsd/getroot.c | 5 +++-- 1

Re: [PATCH] grub-install: check for arm-efi as a default target

2019-02-26 Thread Daniel Kiper
On Tue, Feb 26, 2019 at 01:27:21PM +, Leif Lindholm wrote: > On Thu, Feb 21, 2019 at 04:31:32PM +0100, Daniel Kiper wrote: > > On Thu, Feb 21, 2019 at 03:04:26PM +, Leif Lindholm wrote: > > > On Thu, Feb 21, 2019 at 02:46:11PM +, Steve McIntyre wrote: > > > > Much like on x86, we can wo

Re: [PATCH] grub-install: check for arm-efi as a default target

2019-02-26 Thread Leif Lindholm
On Thu, Feb 21, 2019 at 04:31:32PM +0100, Daniel Kiper wrote: > On Thu, Feb 21, 2019 at 03:04:26PM +, Leif Lindholm wrote: > > On Thu, Feb 21, 2019 at 02:46:11PM +, Steve McIntyre wrote: > > > Much like on x86, we can work out if the system is running on top of > > > EFI firmware. If so,