Re: [PATCH v6 09/11] RISC-V: Add libgcc helpers for clz

2019-02-18 Thread Daniel Kiper
On Tue, Feb 12, 2019 at 11:31:06AM +0100, Alexander Graf wrote: > Gcc may decide it wants to call helper functions to execute clz. Provide Do we know when it happens? Could we add that to the commit message? > them in our own copy of libgcc. > > Signed-off-by: Alexander Graf > --- > grub-core/k

Re: [PATCH v6 10/11] RISC-V: Add to build system

2019-02-18 Thread Daniel Kiper
On Tue, Feb 12, 2019 at 11:31:07AM +0100, Alexander Graf wrote: > This patch adds support for RISC-V to the grub build system. With this > patch, I can successfully build grub on RISC-V as a UEFI application. > > Signed-off-by: Alexander Graf > Reviewed-by: Alistair Francis > Reviewed-by: Bin Men

Re: [PATCH v2] Add travis-ci config file

2019-02-18 Thread Daniel Kiper
On Mon, Feb 18, 2019 at 07:57:35PM +0100, Daniel Kiper wrote: > On Thu, Feb 14, 2019 at 02:12:28PM +0100, Alexander Graf wrote: [...] > > + - mkdir /tmp/cross > > + # results in binaries like > > /tmp/cross/gcc-8.1.0-nolibc/ia64-linux/bin/ia64-linux-gcc > > + - for i in $CROSS_TARGETS; do > >

Re: [PATCH v6 07/11] RISC-V: Add awareness for RISC-V reloations

2019-02-18 Thread Daniel Kiper
On Wed, Feb 13, 2019 at 12:44:32AM +, Alistair Francis wrote: > On Tue, 2019-02-12 at 11:31 +0100, Alexander Graf wrote: > > This patch adds awareness of RISC-V relocations throughout the grub > > tools > > as well as dynamic linkage and elf->PE relocation conversion support. > > > > Signed-off

Re: [PATCH] Add knobs to allow non-initrd boot config

2019-02-18 Thread Daniel Kiper
On Mon, Feb 18, 2019 at 07:41:43PM +0100, Paul Menzel wrote: > Dear Daniel, > > On 18.02.19 13:58, Daniel Kiper wrote: > > On Fri, Feb 15, 2019 at 07:44:55AM -0800, Nick Vinson wrote: > > > > Let me start of by saying that I am a contributor and do not have any > > > authority to approve or deny pa

Re: [PATCH v7 08/11] RISC-V: Add auxiliary files

2019-02-18 Thread Daniel Kiper
On Wed, Feb 13, 2019 at 12:48:44AM +, Alistair Francis wrote: > On Tue, 2019-02-12 at 17:32 +0100, Alexander Graf wrote: > > To support a new architecture we need to provide a few helper > > functions > > for memory, cache, timer, etc support. > > > > This patch adds the remainders of those. So

Re: [PATCH v6 06/11] RISC-V: Add Linux load logic

2019-02-18 Thread Daniel Kiper
On Tue, Feb 12, 2019 at 11:31:03AM +0100, Alexander Graf wrote: > We currently only support to run grub on RISC-V as UEFI payload. Ideally, > we also only want to support running Linux underneath as UEFI payload. > > Prepare that with some Linux boot stub code. Once the arm64 target is > generalize

Re: [PATCH 1/1] Add new module msr

2019-02-18 Thread Jesús Diéguez Fernández
Hi, I have some doubts that I mention below. El 18/2/19 a las 14:24, Daniel Kiper escribió: > Hi, > > Thank you for the contribution. A few comments below... > > On Sat, Feb 16, 2019 at 06:29:01PM +0100, JesusDF wrote: > > I think that message from mail #0 should go here. And you do not ne

Re: [PATCH v2] Add travis-ci config file

2019-02-18 Thread Daniel Kiper
On Thu, Feb 14, 2019 at 02:12:28PM +0100, Alexander Graf wrote: > There is a really convenient service for open source project from Travis > CI: They allow for free CI testing using their infrastructure. > > Grub has had issues with broken builds for various targets for a long time > already. The m

Re: [PATCH] Add knobs to allow non-initrd boot config

2019-02-18 Thread Paul Menzel
Dear Daniel, On 18.02.19 13:58, Daniel Kiper wrote: On Fri, Feb 15, 2019 at 07:44:55AM -0800, Nick Vinson wrote: Let me start of by saying that I am a contributor and do not have any authority to approve or deny patches to GRUB. That said I do have a few comments below that I would like for

Re: [PATCH 1/1] Add a new grub module called msr that registers two commands (rdmsr and wrmsr) to be able to read and write to the model-specific registers. It is i386 specific, as the cpuid module. T

2019-02-18 Thread Daniel Kiper
Hi, Thank you for the contribution. A few comments below... On Sat, Feb 16, 2019 at 06:29:01PM +0100, JesusDF wrote: I think that message from mail #0 should go here. And you do not need introduction mail just for one patch. > --- > grub-core/Makefile.core.def | 10 > grub-core/command

Re: [PATCH] Add knobs to allow non-initrd boot config

2019-02-18 Thread Daniel Kiper
On Fri, Feb 15, 2019 at 07:44:55AM -0800, Nick Vinson wrote: > Paul, > > Let me start of by saying that I am a contributor and do not have any > authority to approve or deny patches to GRUB. That said I do have a few > comments below that I would like for you to consider. Paul, may I ask you to f

Re: [PATCH 1/1] Add new module msr

2019-02-18 Thread Paul Menzel
Dear Jesus, Thank you very much for your contribution. On 02/16/19 18:29, JesusDF wrote: > Add a new grub module called msr that registers two commands (rdmsr and wrmsr) > to be able to read and write to the model-specific registers. It is i386 > specific, as the cpuid module. The name of the