Re: [PATCH 1/9] btrfs: Add support for reading a filesystem with a RAID 5 or RAID 6 profile.

2018-09-19 Thread Goffredo Baroncelli
Please ignore this email On 19/09/2018 20.36, Goffredo Baroncelli wrote: > From: Goffredo Baroncelli > > Signed-off-by: Goffredo Baroncelli > --- > grub-core/fs/btrfs.c | 66 > 1 file changed, 66 insertions(+) > > diff --git a/grub-core/fs/btrfs.c

[PATCH 8/9] btrfs: Make more generic the code for RAID 6 rebuilding

2018-09-19 Thread Goffredo Baroncelli
From: Goffredo Baroncelli The original code which handles the recovery of a RAID 6 disks array assumes that all reads are multiple of 1 << GRUB_DISK_SECTOR_BITS and it assumes that all the I/O is done via the struct grub_diskfilter_segment. This is not true for the btrfs code. In order to reuse t

[PATCH 4/9] btrfs: Avoid a rescan for a device which was already not found.

2018-09-19 Thread Goffredo Baroncelli
From: Goffredo Baroncelli If a device is not found, do not return immediately but record this failure by storing NULL in data->devices_attached[]. This way we avoid unnecessary devices rescan, and speedup the reads in case of a degraded array. Signed-off-by: Goffredo Baroncelli --- grub-core/f

[PATCH 7/9] btrfs: Add support for recovery for a RAID 5 btrfs profiles.

2018-09-19 Thread Goffredo Baroncelli
From: Goffredo Baroncelli Add support for recovery for a RAID 5 btrfs profile. In addition it is added some code as preparatory work for RAID 6 recovery code. Signed-off-by: Goffredo Baroncelli --- grub-core/fs/btrfs.c | 169 +-- 1 file changed, 164 inse

[PATCH 3/9] btrfs: Move the error logging from find_device() to its caller.

2018-09-19 Thread Goffredo Baroncelli
From: Goffredo Baroncelli The caller knows better if this error is fatal or not, i.e. another disk is available or not. This is a preparatory patch. Signed-off-by: Goffredo Baroncelli Reviewed-by: Daniel Kiper --- grub-core/fs/btrfs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(

[PATCH 2/9] btrfs: Add helper to check the btrfs header.

2018-09-19 Thread Goffredo Baroncelli
From: Goffredo Baroncelli This helper is used in a few places to help the debugging. As conservative approach the error is only logged. This does not impact the error handling. Signed-off-by: Goffredo Baroncelli Reviewed-by: Daniel Kiper --- grub-core/fs/btrfs.c | 24 +++-

[PATCH 9/9] btrfs: Add RAID 6 recovery for a btrfs filesystem.

2018-09-19 Thread Goffredo Baroncelli
From: Goffredo Baroncelli Add the RAID 6 recovery, in order to use a RAID 6 filesystem even if some disks (up to two) are missing. This code use the md RAID 6 code already present in grub. Signed-off-by: Goffredo Baroncelli --- grub-core/fs/btrfs.c | 54 +++-

[PATCH 6/9] btrfs: Refactor the code that read from disk

2018-09-19 Thread Goffredo Baroncelli
From: Goffredo Baroncelli Move the code in charge to read the data from disk into a separate function. This helps to separate the error handling logic (which depends on the different raid profiles) from the read from disk logic. Refactoring this code increases the general readability too. This i

[PATCH 5/9] btrfs: Move logging code in grub_btrfs_read_logical()

2018-09-19 Thread Goffredo Baroncelli
From: Goffredo Baroncelli A portion of the logging code is moved outside of internal for(;;). The part that is left inside is the one which depends on the internal for(;;) index. This is a preparatory patch. The next one will refactor the code inside the for(;;) into an another function. Signed

[PATCH 1/9] btrfs: Add support for reading a filesystem with a RAID 5 or RAID 6 profile.

2018-09-19 Thread Goffredo Baroncelli
From: Goffredo Baroncelli Signed-off-by: Goffredo Baroncelli --- grub-core/fs/btrfs.c | 66 1 file changed, 66 insertions(+) diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/btrfs.c index be195448d..56c42746d 100644 --- a/grub-core/fs/btrfs.c +++ b/

[PATCH V7] Add support for BTRFS raid5/6 to GRUB

2018-09-19 Thread Goffredo Baroncelli
Hi All, the aim of this patches set is to provide support for a BTRFS raid5/6 filesystem in GRUB. The first patch, implements the basic support for raid5/6. I.e this works when all the disks are present. The next 5 patches, are preparatory ones. The 7th patch implements the raid5 recovery

[PATCH 1/9] btrfs: Add support for reading a filesystem with a RAID 5 or RAID 6 profile.

2018-09-19 Thread Goffredo Baroncelli
From: Goffredo Baroncelli Signed-off-by: Goffredo Baroncelli --- grub-core/fs/btrfs.c | 66 1 file changed, 66 insertions(+) diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/btrfs.c index be195448d..56c42746d 100644 --- a/grub-core/fs/btrfs.c +++ b/

Re: [PATCH v3] Makefile.am: Add `all_video` to `default_payload.elf`

2018-09-19 Thread Daniel Kiper
On Thu, Sep 06, 2018 at 03:21:24PM +0200, Daniel Kiper wrote: > On Thu, Sep 06, 2018 at 03:07:57PM +0200, Vladimir 'phcoder' Serbinenko wrote: > > Unfortunately this pulls in some problematic graphics drivers that > > shouldn't be in default payload > > Which ones? I have vbe, vga, video_bochs and

Re: [PATCH v2 1/2] build: Capitalise *freetype_* variables

2018-09-19 Thread Colin Watson
On Wed, Sep 19, 2018 at 04:22:12PM +0200, Daniel Kiper wrote: > Ugh... This and another patch somehow dropped off from my radar. > It reappeared during recent mailbox cleanup. Sorry about that. > > Anyway, Colin, may I add your SOB? If yes then > > Reviewed-by: Daniel Kiper Please do - I must h

Re: [PATCH v2 2/2] build: Use pkg-config to find FreeType

2018-09-19 Thread Daniel Kiper
Ugh... Same drop off... Anyway, Reviewed-by: Daniel Kiper Daniel On Tue, Jan 30, 2018 at 09:59:09PM +, Colin Watson wrote: > pkg-config is apparently preferred over freetype-config these days (see > the BUGS section of freetype-config(1)). pkg-config support was added > to FreeType in vers

Re: [PATCH v2] grub-install: Mention *efibootmgr* in `no-nvram` description

2018-09-19 Thread Paul Menzel
Dear Daniel, On 09/19/18 16:08, Daniel Kiper wrote: > On Thu, Sep 06, 2018 at 08:37:50PM +0300, Vladimir 'phcoder' Serbinenko wrote: >> On Thu, 6 Sep 2018, 17:03 Paul Menzel, wrote: >> >>> Date: Thu, 6 Sep 2018 15:15:45 +0200 >>> >>> If executing `efibootmgr` fails, for example, because the syst

Re: [PATCH v2] grub-install: Mention *efibootmgr* in `no-nvram` description

2018-09-19 Thread Daniel Kiper
On Thu, Sep 06, 2018 at 08:37:50PM +0300, Vladimir 'phcoder' Serbinenko wrote: > On Thu, 6 Sep 2018, 17:03 Paul Menzel, wrote: > > > Date: Thu, 6 Sep 2018 15:15:45 +0200 > > > > If executing `efibootmgr` fails, for example, because the system is > > booted in legacy mode, but with a mounted EFI Sy

Re: [PATCH] osdep/linux: convert partition start to disk sector length.

2018-09-19 Thread Daniel Kiper
On Wed, Sep 19, 2018 at 03:58:56PM +0200, Daniel Kiper wrote: > On Thu, Sep 06, 2018 at 08:02:02PM +0200, Mihai Moldovan wrote: > > * On 09/06/2018 07:36 PM, Vladimir 'phcoder' Serbinenko wrote: > > > Grub partition get start returns in 512B blocks. Can I have more details > > > like > > > which p

Re: [PATCH] osdep/linux: convert partition start to disk sector length.

2018-09-19 Thread Daniel Kiper
On Thu, Sep 06, 2018 at 08:02:02PM +0200, Mihai Moldovan wrote: > * On 09/06/2018 07:36 PM, Vladimir 'phcoder' Serbinenko wrote: > > Grub partition get start returns in 512B blocks. Can I have more details > > like > > which partmap you use? > > Yes, but this is a low-level function that expects s

Re: How I configure to get Unicode.pf2 and the command of grub-mkfont

2018-09-19 Thread Daniel Kiper
On Wed, Sep 19, 2018 at 11:59:35AM +, Sherry Zhang(BJ-RD) wrote: > Hi all, > When I compile grub2.02 source code, I can not find that the Unicode.pf2 and > the command of grub-mkfont. > How I configure to get Unicode.pf2 and the command of grub-mkfont? > Build: > ./configure I have a feelin

Re: [PATCH] msdos: Fix overflow in converting partition start and length into 512B blocks

2018-09-19 Thread Daniel Kiper
On Thu, Sep 13, 2018 at 04:08:20PM +0800, Michael Chang wrote: > When booting from NVME SSD with 4k sector size, it fails with the message. > > error: attempt to read or write outside of partition. > > This patch fixes the problem by fixing overflow in converting partition start > and length into 5

Re: [PATCH V1] hostdisk: Fix linux disk cache workaround on multipath disks

2018-09-19 Thread Daniel Kiper
On Thu, Sep 13, 2018 at 03:20:34PM +0800, Michael Chang wrote: > In grub-core/osdep/linux/hostdisk.c::grub_util_fd_open_device() there's > comment > about linux disk cache issue as below: > > /* Linux has a bug that the disk cache for a whole disk is not consistent > with the one for a part

Re: Patch: allow the 'python' used to run gentpl.py to be configured

2018-09-19 Thread Daniel Kiper
On Tue, Jul 17, 2018 at 12:35:42PM -0700, Adam Williamson wrote: > On Fri, 2018-07-06 at 13:19 -0700, Adam Williamson wrote: > > On Fri, 2018-07-06 at 19:25 +0200, Daniel Kiper wrote: > > > On Wed, Jul 04, 2018 at 10:08:53AM -0700, Adam Williamson wrote: > > > > gentpl.py is python2/3-agnostic, but

How I configure to get Unicode.pf2 and the command of grub-mkfont

2018-09-19 Thread Sherry Zhang(BJ-RD)
Hi all, When I compile grub2.02 source code, I can not find that the Unicode.pf2 and the command of grub-mkfont. How I configure to get Unicode.pf2 and the command of grub-mkfont? Build: ./configure make make install grub-install grub-install /dev/sda Best regards, Sherry Zhang ?