Re: [PATCH 6/9] btrfs: refactor the code that read from disk

On 05/30/2018 01:07 PM, Daniel Kiper wrote: > On Wed, May 16, 2018 at 08:48:16PM +0200, Goffredo Baroncelli wrote: >> This is a preparatory patch, to help the adding of the RAID 5/6 recovery > > Please move "This is a preparatory patch" sentence below... > >> code. In case of availability of all

Re: [PATCH 8/9] btrfs: make more generic the code for RAID 6 rebuilding

On 05/30/2018 02:05 PM, Daniel Kiper wrote: > On Wed, May 16, 2018 at 08:48:18PM +0200, Goffredo Baroncelli wrote: >> The original code which handles the recovery of a RAID 6 disks array >> assumes that all reads are multiple of 1 << GRUB_DISK_SECTOR_BITS and it >> assumes that all the I/O is done

Re: [PATCH 9/9] btrfs: add RAID 6 recovery for a btrfs filesystem.

On 05/30/2018 02:15 PM, Daniel Kiper wrote: > On Wed, May 16, 2018 at 08:48:19PM +0200, Goffredo Baroncelli wrote: >> Add the RAID 6 recovery, in order to use a RAID 6 filesystem even if some >> disks (up to two) are missing. This code use the old md RAID 6 code already > > s/the old md/the md/ o

Re: [PATCH 1/9] btrfs: add support for reading a filesystem with a RAID 5 or RAID 6 profile.

Hi Daniel, my comments below On 05/30/2018 12:07 PM, Daniel Kiper wrote: > On Wed, May 16, 2018 at 08:48:11PM +0200, Goffredo Baroncelli wrote: >> Signed-off-by: Goffredo Baroncelli [...] >> + * off -> logical address to read (from the beginning of the >> + * chunk s

Re: [PATCH 7/9] btrfs: add support for recovery for a RAID 5 btrfs profiles.

On 05/30/2018 01:30 PM, Daniel Kiper wrote: > On Wed, May 16, 2018 at 08:48:17PM +0200, Goffredo Baroncelli wrote: >> Signed-off-by: Goffredo Baroncelli >> --- >> grub-core/fs/btrfs.c | 174 ++- >> 1 file changed, 170 insertions(+), 4 deletions(-) >> >> dif