Re: [PATCH 4/7] Avoiding scanning for an already not found device.

2018-05-09 Thread Goffredo Baroncelli
On 05/09/2018 04:07 PM, Daniel Kiper wrote: > On Tue, Apr 24, 2018 at 09:13:13PM +0200, Goffredo Baroncelli wrote: >> If a device is missing, create the entry in data->devices_attached[] array. > > What kind of entry? Invalid one? Please clarify this. > >> This avoid un-necessary devices rescan.

Re: [PATCH 5/7] Refactor the code of read from disk

2018-05-09 Thread Goffredo Baroncelli
On 05/09/2018 04:26 PM, Daniel Kiper wrote: > On Tue, Apr 24, 2018 at 09:13:14PM +0200, Goffredo Baroncelli wrote: >> This is a preparatory patch, to help the adding of the raid5/6 recovery code > > OK, but please tell us why this patch is needed? I will put this commit message: Refactor the c

Re: [PATCH 7/7] Add raid6 recovery.

2018-05-09 Thread Goffredo Baroncelli
On 05/09/2018 06:58 PM, Daniel Kiper wrote: > On Tue, Apr 24, 2018 at 09:13:16PM +0200, Goffredo Baroncelli wrote: >> The code origins from "raid6_recovery.c". The code was changed because the >> original one assumed that both the disk address and size are multiple of >> GRUB_DISK_SECTOR_SIZE. This

Re: [PATCH 2/7] Add helper to check the btrfs header.

2018-05-09 Thread Goffredo Baroncelli
On 05/09/2018 03:52 PM, Daniel Kiper wrote: > On Tue, Apr 24, 2018 at 09:13:11PM +0200, Goffredo Baroncelli wrote: >> This helper was used in few places to help the debugging. As conservative >> approach, in case of error it is only logged. > > Could you explain in the commit message why we are so

Re: [PATCH 3/7] Move from the find_device the error logging logic to the callee.

2018-05-09 Thread Goffredo Baroncelli
On 05/09/2018 04:00 PM, Daniel Kiper wrote: > On Tue, Apr 24, 2018 at 09:13:12PM +0200, Goffredo Baroncelli wrote: >> Signed-off-by: Goffredo Baroncelli >> --- >> grub-core/fs/btrfs.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/grub-core/fs/btrfs.c b/grub-cor

Re: [PATCH 1/7] Add support for reading a filesystem with a raid5 or raid6 profile.

2018-05-09 Thread Goffredo Baroncelli
On 05/09/2018 03:46 PM, Daniel Kiper wrote: > On Tue, Apr 24, 2018 at 09:13:10PM +0200, Goffredo Baroncelli wrote: >> Signed-off-by: Goffredo Baroncelli >> --- >> grub-core/fs/btrfs.c | 32 >> 1 file changed, 32 insertions(+) >> >> diff --git a/grub-core/fs/btrfs.

Re: [PATCH 6/7] Add support for recovery for a raid5 btrfs profiles.

2018-05-09 Thread Goffredo Baroncelli
On 05/09/2018 06:46 PM, Daniel Kiper wrote: > On Tue, Apr 24, 2018 at 09:13:15PM +0200, Goffredo Baroncelli wrote: >> Signed-off-by: Goffredo Baroncelli >> --- >> grub-core/fs/btrfs.c | 206 +-- >> 1 file changed, 199 insertions(+), 7 deletions(-) >> >> dif

Re: [PATCH V2] Add support for BTRFS raid5/6 to GRUB

2018-05-09 Thread Goffredo Baroncelli
On 05/09/2018 07:00 PM, Daniel Kiper wrote: > On Tue, Apr 24, 2018 at 09:13:09PM +0200, Goffredo Baroncelli wrote: >> >> Hi All, >> >> the aim of this patches set is to provide support for a BTRFS raid5/6 >> filesystem in GRUB. >> >> The first patch, implements the basic support for raid5/6. I.e t

[PATCH] loader/i386/linux: calculate the size of the setup header

2018-05-09 Thread Andrew Jeddeloh
This patch is prompted from a question I asked a while ago about why the disk read is necessary. See the thread here [1]. This changes the disk read to use the length of the setup header as calculated by the x86 32 bit linux boot protocol [1]. I'm not 100% sure its patch that's wanted however. The

Re: [PATCH 7/7] Add raid6 recovery.

2018-05-09 Thread Daniel Kiper
On Tue, Apr 24, 2018 at 09:13:16PM +0200, Goffredo Baroncelli wrote: > The code origins from "raid6_recovery.c". The code was changed because the > original one assumed that both the disk address and size are multiple of > GRUB_DISK_SECTOR_SIZE. This is not true for grub btrfs driver. > > The code

Re: [PATCH V2] Add support for BTRFS raid5/6 to GRUB

2018-05-09 Thread Daniel Kiper
On Tue, Apr 24, 2018 at 09:13:09PM +0200, Goffredo Baroncelli wrote: > > Hi All, > > the aim of this patches set is to provide support for a BTRFS raid5/6 > filesystem in GRUB. > > The first patch, implements the basic support for raid5/6. I.e this works when > all the disks > are present. > > Th

Re: [PATCH 6/7] Add support for recovery for a raid5 btrfs profiles.

2018-05-09 Thread Daniel Kiper
On Tue, Apr 24, 2018 at 09:13:15PM +0200, Goffredo Baroncelli wrote: > Signed-off-by: Goffredo Baroncelli > --- > grub-core/fs/btrfs.c | 206 +-- > 1 file changed, 199 insertions(+), 7 deletions(-) > > diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/btrfs.

Re: [PATCH 5/7] Refactor the code of read from disk

2018-05-09 Thread Daniel Kiper
On Tue, Apr 24, 2018 at 09:13:14PM +0200, Goffredo Baroncelli wrote: > This is a preparatory patch, to help the adding of the raid5/6 recovery code OK, but please tell us why this patch is needed? > Signed-off-by: Goffredo Baroncelli > --- > grub-core/fs/btrfs.c | 111 --

Re: [PATCH 4/7] Avoiding scanning for an already not found device.

2018-05-09 Thread Daniel Kiper
On Tue, Apr 24, 2018 at 09:13:13PM +0200, Goffredo Baroncelli wrote: > If a device is missing, create the entry in data->devices_attached[] array. What kind of entry? Invalid one? Please clarify this. > This avoid un-necessary devices rescan. > > Signed-off-by: Goffredo Baroncelli Otherwise LGT

Re: [PATCH 3/7] Move from the find_device the error logging logic to the callee.

2018-05-09 Thread Daniel Kiper
On Tue, Apr 24, 2018 at 09:13:12PM +0200, Goffredo Baroncelli wrote: > Signed-off-by: Goffredo Baroncelli > --- > grub-core/fs/btrfs.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/btrfs.c > index 01a1fc7a1..745bb854e 100644 > -

Re: [PATCH 2/7] Add helper to check the btrfs header.

2018-05-09 Thread Daniel Kiper
On Tue, Apr 24, 2018 at 09:13:11PM +0200, Goffredo Baroncelli wrote: > This helper was used in few places to help the debugging. As conservative > approach, in case of error it is only logged. Could you explain in the commit message why we are so conservative here? > Signed-off-by: Goffredo Baron

Re: [PATCH 1/7] Add support for reading a filesystem with a raid5 or raid6 profile.

2018-05-09 Thread Daniel Kiper
On Tue, Apr 24, 2018 at 09:13:10PM +0200, Goffredo Baroncelli wrote: > Signed-off-by: Goffredo Baroncelli > --- > grub-core/fs/btrfs.c | 32 > 1 file changed, 32 insertions(+) > > diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/btrfs.c > index be195448d..b0032ea4

Re: [PATCH] pass kernel command line as verbatim

2018-05-09 Thread Daniel Kiper
On Thu, Apr 26, 2018 at 04:42:30PM +0800, Michael Chang wrote: > On Tue, Apr 24, 2018 at 12:03:21PM +0200, Daniel Kiper wrote: > > On Wed, Apr 18, 2018 at 03:07:15PM +0800, Michael Chang wrote: > > > On Tue, Apr 17, 2018 at 06:37:06PM +0200, Daniel Kiper wrote: > > > > On Wed, Apr 11, 2018 at 05:17