[PATCH v2] bufio: round up block size to power of 2

2018-04-23 Thread Michael Chang
Rounding up the bufio->block_size to meet power of 2 to facilitate next_buf calcuation in grub_bufio_read. Signed-off-by: Michael Chang v2: - Use a more terse approach to round up size suggested by Daniel - Added comment to explain why to have the size rounded --- grub-core/io/bufio.c | 5 +

Re: [PATCH] bufio: round up block size to power of 2

2018-04-23 Thread Michael Chang
On Mon, Apr 23, 2018 at 03:57:22PM +0200, Daniel Kiper wrote: > On Fri, Apr 20, 2018 at 03:21:30PM +0800, Michael Chang wrote: > > Rounding up the bufio->block_size to meet power of 2 to facilitate next_buf > > calcuation in grub_bufio_read. > > > > Signed-off-by: Michael Chang > > --- > > grub-c

Re: [PATCH v2] Makefile.am: Add `all_video` to `default_payload.elf`

2018-04-23 Thread Paul Menzel
Dear GRUB folks, Am Mittwoch, den 21.03.2018, 09:28 +0100 schrieb Paul Menzel: > From a199bc1f64e33aa942b23fe6d16670cc6002bb6c Mon Sep 17 00:00:00 2001 > From: Paul Menzel > Date: Sun, 16 Apr 2017 21:02:58 +0200 > Subject: [PATCH] Makefile.am: Add `all_video` to default_payload.elf > > The modu

Re: [RFC] Add support for BTRFS raid5/6 to GRUB

2018-04-23 Thread Goffredo Baroncelli
On 04/23/2018 01:50 PM, Daniel Kiper wrote: > On Tue, Apr 17, 2018 at 09:57:40PM +0200, Goffredo Baroncelli wrote: >> Hi All, >> >> Below you can find a patch to add support for accessing files from >> grub in a RAID5/6 btrfs filesystem. This is a RFC because it is >> missing the support for recove

Re: Multiboot ELF segment handling patch

2018-04-23 Thread Alexander Boettcher
Hello, On 17.04.2018 21:40, Daniel Kiper wrote >> The overriden memory may contain device memory (vga text mode e.g.), which >> leads to strange boot behaviour. > > Have you been able to take a look at memory allocator/relocator code why > this happened? for me it looks like, that either already

Re: [PATCH] bufio: round up block size to power of 2

2018-04-23 Thread Daniel Kiper
On Fri, Apr 20, 2018 at 03:21:30PM +0800, Michael Chang wrote: > Rounding up the bufio->block_size to meet power of 2 to facilitate next_buf > calcuation in grub_bufio_read. > > Signed-off-by: Michael Chang > --- > grub-core/io/bufio.c | 8 > 1 file changed, 8 insertions(+) > > diff --gi

Re: [PATCH RFC] Proposition of a --auto-nvram option for grub-install

2018-04-23 Thread Daniel Kiper
Hey Lukasz, On Thu, Apr 19, 2018 at 11:29:28AM +0200, Lukasz Zemczak wrote: > Hey Daniel! > > Thank you for your feedback! I can drop the warning message, sure, I > added it only for verbosity anyway so there's no real reason for > keeping it around. Thanks! > As for your second comment: general

Re: [RFC] Add support for BTRFS raid5/6 to GRUB

2018-04-23 Thread Daniel Kiper
On Tue, Apr 17, 2018 at 09:57:40PM +0200, Goffredo Baroncelli wrote: > Hi All, > > Below you can find a patch to add support for accessing files from > grub in a RAID5/6 btrfs filesystem. This is a RFC because it is > missing the support for recovery (i.e. if some devices are missed). In > the next