Re: [PATCH] F2FS support

2018-03-29 Thread Pete Batard
Hi Daniel, Thanks for reviewing the patch. Here's a v2 that takes your comments into account. Regards, /Pete On 2018.03.28 13:04, Daniel Kiper wrote: On Thu, Mar 22, 2018 at 04:47:47PM +, Pete Batard wrote: From 40030514e682191281e8ddba8d1e0835e6b685dc Mon Sep 17 00:00:00 2001 From: Jae

Re: [PATCH 1/1] Fix PCIe LER when GRUB2 accesses non-enabled MMIO data from VGA

2018-03-29 Thread Daniel Kiper
On Thu, Mar 29, 2018 at 05:00:56PM +0200, Hans de Goede wrote: > Hi, > > On 29-03-18 16:27, Mike Travis wrote: > > > > > >On 3/29/2018 2:36 AM, Daniel Kiper wrote: > >>On Thu, Mar 29, 2018 at 05:29:01PM +0800, Michael Chang wrote: > >>>On Thu, Mar 29, 2018 at 11:02:51AM +0200, Daniel Kiper wrote: >

Re: [PATCH 1/4] Add new "version" command

2018-03-29 Thread Olaf Hering
On Thu, Mar 29, Hans de Goede wrote: > I don't think there is much value in it and I don't feel > like spending time on this to come up with another solution. Not sure what you are trying to fix. At least for me the version is shown all the time at the top. And the buildtime does not add any valu

Re: [PATCH 1/1] Fix PCIe LER when GRUB2 accesses non-enabled MMIO data from VGA

2018-03-29 Thread Hans de Goede
Hi, On 29-03-18 16:27, Mike Travis wrote: On 3/29/2018 2:36 AM, Daniel Kiper wrote: On Thu, Mar 29, 2018 at 05:29:01PM +0800, Michael Chang wrote: On Thu, Mar 29, 2018 at 11:02:51AM +0200, Daniel Kiper wrote: On Wed, Mar 28, 2018 at 11:42:18AM -0500, mike.tra...@hpe.com wrote: A GPU insert

Re: [PATCH 1/4] Add new "version" command

2018-03-29 Thread Hans de Goede
Hi, On 29-03-18 09:53, Olaf Hering wrote: On Wed, Mar 28, Hans de Goede wrote: + grub_printf ("%s, build %s %s\n", PACKAGE_STRING, __DATE__, __TIME__); NACK. Debian sells something what they call "reproducible build". Check their website why usage of __DATE__ and __TIME__ is a bad thing. S

Re: [PATCH 1/1] Fix PCIe LER when GRUB2 accesses non-enabled MMIO data from VGA

2018-03-29 Thread Mike Travis
On 3/29/2018 2:36 AM, Daniel Kiper wrote: On Thu, Mar 29, 2018 at 05:29:01PM +0800, Michael Chang wrote: On Thu, Mar 29, 2018 at 11:02:51AM +0200, Daniel Kiper wrote: On Wed, Mar 28, 2018 at 11:42:18AM -0500, mike.tra...@hpe.com wrote: A GPU inserted into a PCIe I/O slot disappears during sy

Multiboot ELF segment handling patch

2018-03-29 Thread Alexander Boettcher
Hello, our project uses various (micro)kernels booted via GRUB2 using the Multiboot & Multiboot2 protocol. Some of the kernels have several ELF segments which are not necessarily placed close together. When booting such kernels with GRUB2 in BIOS legacy mode we observed that the screen shows colo

Re: [PATCH 1/1] Fix PCIe LER when GRUB2 accesses non-enabled MMIO data from VGA

2018-03-29 Thread Daniel Kiper
On Thu, Mar 29, 2018 at 05:29:01PM +0800, Michael Chang wrote: > On Thu, Mar 29, 2018 at 11:02:51AM +0200, Daniel Kiper wrote: > > On Wed, Mar 28, 2018 at 11:42:18AM -0500, mike.tra...@hpe.com wrote: > > > A GPU inserted into a PCIe I/O slot disappears during system startup. > > > The problem cente

Re: [PATCH 1/1] Fix PCIe LER when GRUB2 accesses non-enabled MMIO data from VGA

2018-03-29 Thread Michael Chang
On Thu, Mar 29, 2018 at 11:02:51AM +0200, Daniel Kiper wrote: > On Wed, Mar 28, 2018 at 11:42:18AM -0500, mike.tra...@hpe.com wrote: > > A GPU inserted into a PCIe I/O slot disappears during system startup. > > The problem centers around GRUB and a specific VGA init function in > > efi_uga.c. This

Re: [PATCH 1/1] Fix PCIe LER when GRUB2 accesses non-enabled MMIO data from VGA

2018-03-29 Thread Daniel Kiper
On Wed, Mar 28, 2018 at 11:42:18AM -0500, mike.tra...@hpe.com wrote: > A GPU inserted into a PCIe I/O slot disappears during system startup. > The problem centers around GRUB and a specific VGA init function in > efi_uga.c. This causes an LER (link error recorvery) because the MMIO > memory has no

Re: [PATCH 1/4] Add new "version" command

2018-03-29 Thread Thomas Schmitt
Hi, Hans de Goede wrote: > > + grub_printf ("%s, build %s %s\n", PACKAGE_STRING, __DATE__, __TIME__); Olaf Hering wrote: > Debian sells something what they call "reproducible build". It's not actually a Debian thing, although some Debian Developers seem to have initiated it and urge people to m

Re: [PATCH 1/4] Add new "version" command

2018-03-29 Thread Olaf Hering
On Wed, Mar 28, Hans de Goede wrote: > + grub_printf ("%s, build %s %s\n", PACKAGE_STRING, __DATE__, __TIME__); NACK. Debian sells something what they call "reproducible build". Check their website why usage of __DATE__ and __TIME__ is a bad thing. SUSE does not want to republish an otherwise u