Re: [PATCH 2/2] .mod files: Strip annobin annotations and .eh_frame, and their relocations

2018-02-15 Thread Vladimir 'phcoder' Serbinenko
LGTM Le mer. 31 janv. 2018 à 17:28, Peter Jones a écrit : > This way debuginfo built from the .module will still include this > information, but the final result won't have the data we don't actually > need in the modules, either on-disk, loaded at runtime, or in prebuilt > images. > > Signed-of

Re: [PATCH 1/2] mkimage: avoid copying relocations for sections that won't be copied.

2018-02-15 Thread Vladimir 'phcoder' Serbinenko
Patch looks good. I'm sick right now. I'll commit in few days when I feel better unless someone commits it before Le mer. 31 janv. 2018 à 17:28, Peter Jones a écrit : > Some versions of gcc include a plugin called "annobin", and in some > build systems this is enabled by default. This plugin cr

Re: [PATCH 1/2] mkimage: avoid copying relocations for sections that won't be copied.

2018-02-15 Thread Peter Jones
Anyone want to have a look at this patchset to make gcc > 7.2.1 (with optional plugins enabled) work? On Wed, Jan 31, 2018 at 11:26:59AM -0500, Peter Jones wrote: > Some versions of gcc include a plugin called "annobin", and in some > build systems this is enabled by default. This plugin creates

Re: [PATCH 0/8] xen: add pvh guest support

2018-02-15 Thread Daniel Kiper
Hi Juergen, Sorry for huge delay. It looks that I am recovering slowly and probably I will have more time for reviews. On Wed, Nov 29, 2017 at 02:46:42PM +0100, Juergen Gross wrote: > This patch series adds support for booting Linux as PVH guest. > > Similar to i386/xen and x86_64/xen platforms t

Re: [PATCH 8/8] xenpvh: add support to configure

2018-02-15 Thread Daniel Kiper
On Wed, Nov 29, 2017 at 02:46:50PM +0100, Juergen Gross wrote: > Support platform i386/xenpvh in configure. > > Signed-off-by: Juergen Gross Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman

Re: [PATCH 7/8] xenpvh: support grub-install for xenpvh

2018-02-15 Thread Daniel Kiper
On Wed, Nov 29, 2017 at 02:46:49PM +0100, Juergen Gross wrote: > Add xenpvh support to grub-install. > > Signed-off-by: Juergen Gross Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listin

Re: [PATCH 6/8] xenpvh: support building a standalone image

2018-02-15 Thread Daniel Kiper
On Wed, Nov 29, 2017 at 02:46:48PM +0100, Juergen Gross wrote: > Suppor mkimage for xenpvh. > > Signed-off-by: Juergen Gross > --- > include/grub/util/mkimage.h | 3 ++- > util/grub-mkimage32.c | 1 + > util/grub-mkimage64.c | 1 + > util/grub-mkimagexx.c | 44 +++

Re: [PATCH 5/8] xenpvh: add build runes for grub-core

2018-02-15 Thread Daniel Kiper
On Wed, Nov 29, 2017 at 02:46:47PM +0100, Juergen Gross wrote: > Add the modifications to the build system needed to build a xenpvh > grub. > > Signed-off-by: Juergen Gross Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.o

Re: [PATCH 4/8] xen: add xen pvh guest support to grub-core

2018-02-15 Thread Daniel Kiper
On Wed, Nov 29, 2017 at 02:46:46PM +0100, Juergen Gross wrote: > Add all the grub-core code needed for Xen PVH guest support. This > includes: > > - The new PVH entry point of grub > - PVH specific initialization code > - machine specific header files > - modifications in Xen specific code to work

Re: [PATCH 3/8] xen: carve out grant tab initialization into dedicated function

2018-02-15 Thread Daniel Kiper
On Wed, Nov 29, 2017 at 02:46:45PM +0100, Juergen Gross wrote: > Initialize the grant tab in a dedicated function. This will enable > using it for PVH guests, too. > > Signed-off-by: Juergen Gross > --- > grub-core/kern/xen/init.c | 35 +-- > 1 file changed, 21 ins

Re: [PATCH 2/8] loader/linux: support passing rsdp address via boot params

2018-02-15 Thread Daniel Kiper
On Wed, Nov 29, 2017 at 02:46:44PM +0100, Juergen Gross wrote: > Xen PVH guests will have the RSDP at an arbitrary address. Support that > by passing the RSDP address via the boot parameters to Linux. > > Signed-off-by: Juergen Gross You told me that this patch should be rewritten so I am skippin

Re: [PATCH 1/8] xen: add some xen headers

2018-02-15 Thread Daniel Kiper
On Wed, Nov 29, 2017 at 02:46:43PM +0100, Juergen Gross wrote: > In order to support grub2 in Xen PVH environment some additional Xen > headers are needed. Add them. > > Signed-off-by: Juergen Gross > --- > include/xen/hvm/hvm_op.h | 296 +++ > include/xen/hvm/params.h | 2

Re: [PATCH 03/10] make GRUB_LINUX_MAGIC_SIGNATURE architecture-specific

2018-02-15 Thread Daniel Kiper
On Thu, Feb 15, 2018 at 10:39:38AM +, Leif Lindholm wrote: > On Thu, Feb 15, 2018 at 11:05:16AM +0100, Daniel Kiper wrote: > > On Thu, Feb 01, 2018 at 06:18:51PM +, Leif Lindholm wrote: > > > Rename GRUB_LINUX_MAGIC_SIGNATURE GRUB_LINUX_I386_MAGIC_SIGNATURE, > > > > Missing "to" between GRU

Re: [PATCH 03/10] make GRUB_LINUX_MAGIC_SIGNATURE architecture-specific

2018-02-15 Thread Leif Lindholm
On Thu, Feb 15, 2018 at 11:05:16AM +0100, Daniel Kiper wrote: > On Thu, Feb 01, 2018 at 06:18:51PM +, Leif Lindholm wrote: > > Rename GRUB_LINUX_MAGIC_SIGNATURE GRUB_LINUX_I386_MAGIC_SIGNATURE, > > Missing "to" between GRUB_LINUX_MAGIC_SIGNATURE and > GRUB_LINUX_I386_MAGIC_SIGNATURE. Both for

Re: [PATCH 10/10] commands/file: use definitions from arm64/linux.h

2018-02-15 Thread Daniel Kiper
On Thu, Feb 01, 2018 at 06:18:58PM +, Leif Lindholm wrote: > Clean up code for matching IS_ARM64 slightly by making use of struct > linux_arm_kernel_header and GRUB_LINUX_ARM64_MAGIC_SIGNATURE. > > Signed-off-by: Leif Lindholm Reviewed-by: Daniel Kiper Daniel __

Re: [PATCH 09/10] commands/file: use definitions from arm/linux.h

2018-02-15 Thread Daniel Kiper
On Thu, Feb 01, 2018 at 06:18:57PM +, Leif Lindholm wrote: > Clean up code for matching IS_ARM slightly by making use of struct > linux_arm_kernel_header and GRUB_LINUX_ARM_MAGIC_SIGNATURE. > > Signed-off-by: Leif Lindholm > --- > grub-core/commands/file.c | 14 ++ > 1 file change

Re: [PATCH 00/10] various cleanup

2018-02-15 Thread Daniel Kiper
Sorry for delay. On Thu, Feb 01, 2018 at 06:18:48PM +, Leif Lindholm wrote: > So, sorry I dropped the ball on this last year. > > This series contains what I would hope to be non-contentious > cleanup in preparation for the functional changes (/fixes) for > the arm64 linux loader and its reuse

Re: [PATCH 07/10] arm: switch linux loader to linux_arm_kernel_header struct

2018-02-15 Thread Daniel Kiper
On Thu, Feb 01, 2018 at 06:18:55PM +, Leif Lindholm wrote: > Use kernel header struct and magic definition to align (and coexist) with > i386/arm64 ports. > > Signed-off-by: Leif Lindholm Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing li

Re: [PATCH 08/10] arm: make linux.h safe to include for non-native builds

2018-02-15 Thread Daniel Kiper
On Thu, Feb 01, 2018 at 06:18:56PM +, Leif Lindholm wrote: > (for machine arm/efi) and > (for machine arm/coreboot) will not always > resolve (and will likely not be valid to) if pulled in when building > non-native commands, such as host tools or the "file" command. > So explicitly include t

Re: [PATCH 06/10] arm64: align linux kernel magic macro naming with i386

2018-02-15 Thread Daniel Kiper
On Thu, Feb 01, 2018 at 06:18:54PM +, Leif Lindholm wrote: > Change GRUB_ARM64_LINUX_MAGIC to GRUB_LINUX_ARM64_MAGIC_SIGNATURE. > > Signed-off-by: Leif Lindholm Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https

Re: [PATCH 05/10] arm64: align linux kernel header struct naming with i386

2018-02-15 Thread Daniel Kiper
On Thu, Feb 01, 2018 at 06:18:53PM +, Leif Lindholm wrote: > Rename struct grub_arm64_linux_kernel_header -> linux_arm64_kernel_header. > > Signed-off-by: Leif Lindholm Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.o

Re: [PATCH 04/10] i386: make struct linux_kernel_header architecture specific

2018-02-15 Thread Daniel Kiper
On Thu, Feb 01, 2018 at 06:18:52PM +, Leif Lindholm wrote: > struct linux_kernel_header -> struct linux_i386_kernel_header > > Signed-off-by: Leif Lindholm Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://li

Re: [PATCH 03/10] make GRUB_LINUX_MAGIC_SIGNATURE architecture-specific

2018-02-15 Thread Daniel Kiper
On Thu, Feb 01, 2018 at 06:18:51PM +, Leif Lindholm wrote: > Rename GRUB_LINUX_MAGIC_SIGNATURE GRUB_LINUX_I386_MAGIC_SIGNATURE, Missing "to" between GRUB_LINUX_MAGIC_SIGNATURE and GRUB_LINUX_I386_MAGIC_SIGNATURE. I will fix it during commit. > to be usable in code that supports more than one

Re: [PATCH 02/10] Make arch-specific linux.h include guards architecture unique

2018-02-15 Thread Daniel Kiper
On Thu, Feb 01, 2018 at 06:18:50PM +, Leif Lindholm wrote: > Replace uses of GRUB_LINUX_MACHINE_HEADER and GRUB_LINUX_CPU_HEADER > with GRUB__LINUX_HEADER include guards to prevent issues when > including more than one of them. > > Signed-off-by: Leif Lindholm Reviewed-by: Daniel Kiper Dani

Re: [PATCH 01/10] arm64/efi: move EFI_PAGE definitions to efi/memory.h

2018-02-15 Thread Daniel Kiper
On Thu, Feb 01, 2018 at 06:18:49PM +, Leif Lindholm wrote: > The EFI page definitions and macros are generic and should not be confined > to arm64 headers - so move to efi/memory.h. > Also add EFI_PAGE_SIZE macro. > > Update loader sources to reflect new header location. > > Signed-off-by: Leif