Re: ZFS boot environment patch

2017-09-13 Thread Colin Watson
On Wed, Sep 13, 2017 at 11:02:48AM -0400, Konrad Rzeszutek Wilk wrote: > On Fri, Sep 01, 2017 at 01:31:28PM +0200, Paul Lagerweij wrote: > > +zfs_be="0" > > Why not just > > zfs_be= > > And then you can just check for zfs_be having an value instead of for 1 or 0? > > Or alternatively, > > zfs_

Re: ZFS boot environment patch

2017-09-13 Thread Konrad Rzeszutek Wilk
On Fri, Sep 01, 2017 at 01:31:28PM +0200, Paul Lagerweij wrote: > Hello, > > I've created a patch for util/grub.d/10_linux.in for dynamic ZFS boot > environment entries. I've only tested the patch in Ubuntu 16.04.2 with GRUB > 2.02~beta2, ZFS on Linux 0.6.5.6, Linux 4.4.0-83 and 4.4.0-81, but the

Re: [PATCH 2/4] arm64/efi: move EFI_PAGE definitions to efi/memory.h

2017-09-13 Thread Leif Lindholm
On Wed, Sep 13, 2017 at 06:00:21AM +0200, Daniel Kiper wrote: > On Tue, Sep 05, 2017 at 09:41:12PM +0100, Leif Lindholm wrote: > > The EFI page definitions and macros are generic and should not be confined > > to arm64 headers - so move to efi/memory.h. > > I am OK with this. > > > Also add EFI_P

Re: [PATCH 3/4] efi: add central copy of grub_efi_find_mmap_size

2017-09-13 Thread Leif Lindholm
On Wed, Sep 13, 2017 at 06:39:11AM +0200, Daniel Kiper wrote: > On Tue, Sep 05, 2017 at 09:41:13PM +0100, Leif Lindholm wrote: > > There are several implementations of this function in the tree. > > Add a central version in grub-core/efi/mm.c. > > > > Taken from grub-core/loader/i386/linux.c, chang

Re: [PATCH 1/4] i386/x86_64: make linux header definitions arch-specific

2017-09-13 Thread Leif Lindholm
On Wed, Sep 13, 2017 at 05:45:58AM +0200, Daniel Kiper wrote: > Hi Leif, > > Sorry for late reply but I am traveling. I should be > more responsive starting from next week. > > On Tue, Sep 05, 2017 at 09:41:11PM +0100, Leif Lindholm wrote: > > Rename GRUB_LINUX_MAGIC_SIGNATURE -> GRUB_LINUX_I386_