08.05.2016 16:01, Dryden Personalis пишет:
>
>>> -if (fs_probe)
>>> +if (!is_lvm && fs_probe)
>>
>> No, we want to probe for FS here to eliminate corner case of both PV and
>> FS metadata.
>
> You mean you want to change it to:
>
No, I do not want to change it at all. It should remain a
Andrei Borzenkov schreef op 08-05-2016 11:23:
PV label may be in the first sector. In this case label will be
overwritten later by boot image. This needs additional check.
Pardon my last mail.
ON OLD PV SIGNATURES
If you have an old PV that had a boatloaderarea, then wip
Dryden Personalis schreef op 08-05-2016 19:16:
I just wasted 2 hours trying to get GRUB_UTIL to work and failing.
I am just not always that brilliant.
Why on earth is that flag in there? If you enable it, stuff won't
compile anymore. And I merely needed to turn on verbose output for
grub-in
Andrei Borzenkov schreef op 08-05-2016 10:47:
08.05.2016 09:05, Andrei Borzenkov пишет:
+#ifdef GRUB_UTIL
+int
+grub_util_is_lvm(grub_disk_t disk)
+{
+ struct grub_diskfilter_pv_id id;
+ struct grub_diskfilter_vg *vg;
+ grub_disk_addr_t start_sector;
+ vg = grub_lvm_detect(disk, &id, &start
Andrei Borzenkov schreef op 08-05-2016 10:47:
08.05.2016 09:05, Andrei Borzenkov пишет:
+#ifdef GRUB_UTIL
+int
+grub_util_is_lvm(grub_disk_t disk)
+{
+ struct grub_diskfilter_pv_id id;
+ struct grub_diskfilter_vg *vg;
+ grub_disk_addr_t start_sector;
+ vg = grub_lvm_detect(disk, &id, &start
Andrei Borzenkov schreef op 08-05-2016 11:23:
08.05.2016 07:53, Dryden Personalis пишет:
+if (is_lvm)
+ err = grub_util_lvm_embed (dest_dev->disk, &nsec, maxsec,
+GRUB_EMBED_PCBIOS, §ors);
PV label may be in the first sector. In this case label will be
Andrei Borzenkov schreef op 08-05-2016 8:05:
Did you actually test it by installing GRUB on PV? Does it boot? Did
you
test it both with unpartitioned disk and PV in partition?
Hi Andrei,
I must say I have for the most part just copied the patch as it was, and
just tried to fix it so that th
08.05.2016 07:53, Dryden Personalis пишет:
> +if (is_lvm)
> + err = grub_util_lvm_embed (dest_dev->disk, &nsec, maxsec,
> +GRUB_EMBED_PCBIOS, §ors);
PV label may be in the first sector. In this case label will be
overwritten later by boot image. This needs
08.05.2016 09:05, Andrei Borzenkov пишет:
>>
>> +#ifdef GRUB_UTIL
>> +int
>> +grub_util_is_lvm(grub_disk_t disk)
>> +{
>> + struct grub_diskfilter_pv_id id;
>> + struct grub_diskfilter_vg *vg;
>> + grub_disk_addr_t start_sector;
>> + vg = grub_lvm_detect(disk, &id, &start_sector);
>> + if (!
