Re: [PATCH v3 01/10] xen: make xen loader callable multiple times

2016-02-18 Thread Juergen Gross
On 18/02/16 17:58, Daniel Kiper wrote: > On Thu, Feb 18, 2016 at 11:32:16AM +0100, Juergen Gross wrote: >> On 18/02/16 11:12, Daniel Kiper wrote: >>> On Wed, Feb 17, 2016 at 06:19:28PM +0100, Juergen Gross wrote: The loader for xen paravirtualized environment isn't callable multiple times

Re: [PATCH v3 09/10] xen: modify page table construction

2016-02-18 Thread Juergen Gross
On 18/02/16 17:40, Daniel Kiper wrote: > On Wed, Feb 17, 2016 at 06:19:36PM +0100, Juergen Gross wrote: >> Modify the page table construction to allow multiple virtual regions >> to be mapped. This is done as preparation for removing the p2m list >> from the initial kernel mapping in order to suppo

Re: [Xen-devel] [PATCH v3 02/10] xen: reduce number of global variables in xen loader

2016-02-18 Thread Juergen Gross
On 18/02/16 18:00, Lennart Sorensen wrote: > On Thu, Feb 18, 2016 at 11:34:49AM +0100, Juergen Gross wrote: >> On 18/02/16 11:22, Daniel Kiper wrote: >>> On Wed, Feb 17, 2016 at 06:19:29PM +0100, Juergen Gross wrote: The loader for xen paravirtualized environment is using lots of global v

Re: [PATCH v3] tcp: add window scaling and RTTM support

2016-02-18 Thread Josef Bacik
On 02/13/2016 10:40 AM, Andrei Borzenkov wrote: 01.02.2016 21:30, Josef Bacik пишет: ... @@ -745,6 +817,7 @@ grub_net_recv_tcp_packet (struct grub_net_buff *nb, { struct tcphdr *tcph; grub_net_tcp_socket_t sock; + grub_uint32_t tsecr = 0; grub_err_t err; /* Ignore broadcast.

[PATCH] efidisk: Respect block_io_protocol buffer alignment

2016-02-18 Thread Leif Lindholm
Returned from the OpenProtocol operation, the grub_efi_block_io_media structure contains the io_align field, specifying the minimum alignment required for buffers used in any data transfers with the device. Make grub_efidisk_readwrite() allocate a temporary buffer, aligned to this boundary, if the

Re: [PATCH v3 08/10] xen: add capability to load initrd outside of initial mapping

2016-02-18 Thread Daniel Kiper
On Thu, Feb 18, 2016 at 01:43:33PM +0100, Juergen Gross wrote: > On 18/02/16 12:18, Daniel Kiper wrote: > > On Wed, Feb 17, 2016 at 06:19:35PM +0100, Juergen Gross wrote: > >> Modern pvops linux kernels support an initrd not covered by the initial > >> mapping. This capability is flagged by an elf-

Re: [PATCH v3 02/10] xen: reduce number of global variables in xen loader

2016-02-18 Thread Daniel Kiper
On Thu, Feb 18, 2016 at 11:34:49AM +0100, Juergen Gross wrote: > On 18/02/16 11:22, Daniel Kiper wrote: > > On Wed, Feb 17, 2016 at 06:19:29PM +0100, Juergen Gross wrote: > >> The loader for xen paravirtualized environment is using lots of global > >> variables. Reduce the number by making them eit

Re: [PATCH v3 03/10] xen: add elfnote.h to avoid using numbers instead of constants

2016-02-18 Thread Daniel Kiper
On Thu, Feb 18, 2016 at 11:35:52AM +0100, Juergen Gross wrote: > On 18/02/16 11:30, Daniel Kiper wrote: > > On Wed, Feb 17, 2016 at 06:19:30PM +0100, Juergen Gross wrote: > >> Various features and parameters of a pv-kernel are specified via > >> elf notes in the kernel image. Those notes are part o

Re: [PATCH v3 01/10] xen: make xen loader callable multiple times

2016-02-18 Thread Daniel Kiper
On Thu, Feb 18, 2016 at 11:32:16AM +0100, Juergen Gross wrote: > On 18/02/16 11:12, Daniel Kiper wrote: > > On Wed, Feb 17, 2016 at 06:19:28PM +0100, Juergen Gross wrote: > >> The loader for xen paravirtualized environment isn't callable multiple > >> times as it won't free any memory in case of fa

Re: [PATCH v3 02/10] xen: reduce number of global variables in xen loader

2016-02-18 Thread Lennart Sorensen
On Thu, Feb 18, 2016 at 11:34:49AM +0100, Juergen Gross wrote: > On 18/02/16 11:22, Daniel Kiper wrote: > > On Wed, Feb 17, 2016 at 06:19:29PM +0100, Juergen Gross wrote: > >> The loader for xen paravirtualized environment is using lots of global > >> variables. Reduce the number by making them eit

Re: [PATCH] efidisk: Respect block_io_protocol buffer alignment

2016-02-18 Thread Andrei Borzenkov
18.02.2016 18:00, Leif Lindholm пишет: > Returned from the OpenProtocol operation, the grub_efi_block_io_media > structure contains the io_align field, specifying the minimum alignment > required for buffers used in any data transfers with the device. > > Make grub_efidisk_readwrite() allocate a t

Re: [PATCH] efidisk: Respect block_io_protocol buffer alignment

2016-02-18 Thread Leif Lindholm
On Thu, Feb 18, 2016 at 04:27:58PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 18.02.2016 16:00, Leif Lindholm wrote: > > --- a/grub-core/disk/efi/efidisk.c > > +++ b/grub-core/disk/efi/efidisk.c > > @@ -463,6 +463,7 @@ grub_efidisk_open (const char *name, struct grub_disk > > *disk)

Re: [PATCH v3 10/10] xen: add capability to load p2m list outside of kernel mapping

2016-02-18 Thread Daniel Kiper
On Wed, Feb 17, 2016 at 06:19:37PM +0100, Juergen Gross wrote: > Modern pvops linux kernels support a p2m list not covered by the > kernel mapping. This capability is flagged by an elf-note specifying > the virtual address the kernel is expecting the p2m list to be mapped > to. > > In case the elf-

Re: [PATCH v3 09/10] xen: modify page table construction

2016-02-18 Thread Daniel Kiper
On Wed, Feb 17, 2016 at 06:19:36PM +0100, Juergen Gross wrote: > Modify the page table construction to allow multiple virtual regions > to be mapped. This is done as preparation for removing the p2m list > from the initial kernel mapping in order to support huge pv domains. > > This allows a cleane

Re: [PATCH] efidisk: Respect block_io_protocol buffer alignment

2016-02-18 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 18.02.2016 16:00, Leif Lindholm wrote: > Returned from the OpenProtocol operation, the grub_efi_block_io_media > structure contains the io_align field, specifying the minimum alignment > required for buffers used in any data transfers with the device. > > Make grub_efidisk_readwrite() allocate

[PATCH] efidisk: Respect block_io_protocol buffer alignment

2016-02-18 Thread Leif Lindholm
Returned from the OpenProtocol operation, the grub_efi_block_io_media structure contains the io_align field, specifying the minimum alignment required for buffers used in any data transfers with the device. Make grub_efidisk_readwrite() allocate a temporary buffer, aligned to this boundary, if the

Re: [PATCH v3 08/10] xen: add capability to load initrd outside of initial mapping

2016-02-18 Thread Juergen Gross
On 18/02/16 12:18, Daniel Kiper wrote: > On Wed, Feb 17, 2016 at 06:19:35PM +0100, Juergen Gross wrote: >> Modern pvops linux kernels support an initrd not covered by the initial >> mapping. This capability is flagged by an elf-note. >> >> In case the elf-note is set by the kernel don't place the i

Re: [PATCH] efidisk: Respect block_io_protocol buffer alignment

2016-02-18 Thread Leif Lindholm
On Thu, Feb 18, 2016 at 03:00:38PM +0300, Andrei Borzenkov wrote: > On Thu, Feb 18, 2016 at 1:21 PM, Leif Lindholm > wrote: > > On Thu, Feb 18, 2016 at 06:36:06AM +0300, Andrei Borzenkov wrote: > >> 17.02.2016 22:44, Leif Lindholm пишет: > >> > Returned from the OpenProtocol operation, the grub_e

Re: [PATCH] efidisk: Respect block_io_protocol buffer alignment

2016-02-18 Thread Andrei Borzenkov
On Thu, Feb 18, 2016 at 1:21 PM, Leif Lindholm wrote: > On Thu, Feb 18, 2016 at 06:36:06AM +0300, Andrei Borzenkov wrote: >> 17.02.2016 22:44, Leif Lindholm пишет: >> > Returned from the OpenProtocol operation, the grub_efi_block_io_media >> > structure contains the io_align field, specifying the

Re: [PATCH v3 08/10] xen: add capability to load initrd outside of initial mapping

2016-02-18 Thread Daniel Kiper
On Wed, Feb 17, 2016 at 06:19:35PM +0100, Juergen Gross wrote: > Modern pvops linux kernels support an initrd not covered by the initial > mapping. This capability is flagged by an elf-note. > > In case the elf-note is set by the kernel don't place the initrd into > the initial mapping. This will a

Re: [PATCH v3 07/10] xen: factor out allocation of page tables into separate function

2016-02-18 Thread Daniel Kiper
On Wed, Feb 17, 2016 at 06:19:34PM +0100, Juergen Gross wrote: > Do the allocation of page tables in a separate function. This will > allow to do the allocation at different times of the boot preparations > depending on the features the kernel is supporting. > > Signed-off-by: Juergen Gross Revie

Re: [PATCH v3 06/10] xen: factor out allocation of special pages into separate function

2016-02-18 Thread Daniel Kiper
On Wed, Feb 17, 2016 at 06:19:33PM +0100, Juergen Gross wrote: > Do the allocation of special pages (start info, console and xenbus > ring buffers) in a separate function. This will allow to do the > allocation at different times of the boot preparations depending on > the features the kernel is su

Re: [PATCH v3 05/10] xen: factor out p2m list allocation into separate function

2016-02-18 Thread Daniel Kiper
On Wed, Feb 17, 2016 at 06:19:32PM +0100, Juergen Gross wrote: > Do the p2m list allocation of the to be loaded kernel in a separate > function. This will allow doing the p2m list allocation at different > times of the boot preparations depending on the features the kernel > is supporting. > > Whil

Re: [PATCH v3 03/10] xen: add elfnote.h to avoid using numbers instead of constants

2016-02-18 Thread Juergen Gross
On 18/02/16 11:30, Daniel Kiper wrote: > On Wed, Feb 17, 2016 at 06:19:30PM +0100, Juergen Gross wrote: >> Various features and parameters of a pv-kernel are specified via >> elf notes in the kernel image. Those notes are part of the interface >> between the Xen hypervisor and the kernel. >> >> Ins

Re: [PATCH v3 04/10] xen: synchronize xen header

2016-02-18 Thread Daniel Kiper
On Wed, Feb 17, 2016 at 06:19:31PM +0100, Juergen Gross wrote: > Get actual version of include/xen/xen.h from the Xen repository in > order to be able to use constants defined there. > > Signed-off-by: Juergen Gross Reviewed-by: Daniel Kiper Daniel _

Re: [PATCH v3 03/10] xen: add elfnote.h to avoid using numbers instead of constants

2016-02-18 Thread Daniel Kiper
On Wed, Feb 17, 2016 at 06:19:30PM +0100, Juergen Gross wrote: > Various features and parameters of a pv-kernel are specified via > elf notes in the kernel image. Those notes are part of the interface > between the Xen hypervisor and the kernel. > > Instead of using num,bers in the code when interp

Re: [PATCH v3 02/10] xen: reduce number of global variables in xen loader

2016-02-18 Thread Juergen Gross
On 18/02/16 11:22, Daniel Kiper wrote: > On Wed, Feb 17, 2016 at 06:19:29PM +0100, Juergen Gross wrote: >> The loader for xen paravirtualized environment is using lots of global >> variables. Reduce the number by making them either local or by putting >> them into a single state structure. >> >> Si

Re: [PATCH v3 01/10] xen: make xen loader callable multiple times

2016-02-18 Thread Juergen Gross
On 18/02/16 11:12, Daniel Kiper wrote: > On Wed, Feb 17, 2016 at 06:19:28PM +0100, Juergen Gross wrote: >> The loader for xen paravirtualized environment isn't callable multiple >> times as it won't free any memory in case of failure. >> >> Call grub_relocator_unload() as other modules do it before

Re: [PATCH v3 02/10] xen: reduce number of global variables in xen loader

2016-02-18 Thread Daniel Kiper
On Wed, Feb 17, 2016 at 06:19:29PM +0100, Juergen Gross wrote: > The loader for xen paravirtualized environment is using lots of global > variables. Reduce the number by making them either local or by putting > them into a single state structure. > > Signed-off-by: Juergen Gross Just two nitpicks

Re: [PATCH] efidisk: Respect block_io_protocol buffer alignment

2016-02-18 Thread Leif Lindholm
On Thu, Feb 18, 2016 at 06:36:06AM +0300, Andrei Borzenkov wrote: > 17.02.2016 22:44, Leif Lindholm пишет: > > Returned from the OpenProtocol operation, the grub_efi_block_io_media > > structure contains the io_align field, specifying the minimum alignment > > required for buffers used in any data

Re: [PATCH v3 01/10] xen: make xen loader callable multiple times

2016-02-18 Thread Daniel Kiper
On Wed, Feb 17, 2016 at 06:19:28PM +0100, Juergen Gross wrote: > The loader for xen paravirtualized environment isn't callable multiple > times as it won't free any memory in case of failure. > > Call grub_relocator_unload() as other modules do it before allocating Do you mean grub_xen_reset? > a