On Mon, Nov 09, 2015 at 03:21:37PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
> On 09.11.2015 14:23, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> > On 09.11.2015 09:03, Michael Chang wrote:
> Attached proof-of-concept. It's all in one file but different methods
> should probably go in
Other than small comment inline go ahead
Le 12 nov. 2015 1:36 AM, "Paulo Flabiano Smorigo" <
pfsmor...@linux.vnet.ibm.com> a écrit :
>
> Changes:
> - using sizeof ("/disk@7766554433221100");
> - grub_uint64_t *table;
> + grub_snprintf (bufptr, sizeof ("/disk@7766554433221100"),
> +
Changes:
- using sizeof ("/disk@7766554433221100");
- grub_uint64_t *table;
---
grub-core/disk/ieee1275/ofdisk.c | 76
1 file changed, 76 insertions(+)
diff --git a/grub-core/disk/ieee1275/ofdisk.c b/grub-core/disk/ieee1275/ofdisk.c
index 297f058..b1f7c56
On 11.11.2015 14:14, Paulo Flabiano Smorigo wrote:
> + ptr = (grub_uint64_t *) (table + sizeof (grub_uint64_t) * i);
> + grub_snprintf (bufptr, 32, "/disk@%" PRIxGRUB_UINT64_T, *ptr);
Please declare table as being grub_uint64_t * and then just use
table[i]. This code violates cast
06.11.2015 05:00, Ignat Korchagin пишет:
Actually, I submitted similar patch recently as well. It provides read
function for variables and accepts a hint on how to process them. The
original patch is here:
https://lists.gnu.org/archive/html/grub-devel/2015-09/msg00043.html.
Yes, I was intendin
Yes, that could be an option. phcoder, can I commit using andrei's approach?
--
P. F. Smorigo
On Wed, Nov 11, 2015 at 3:28 PM, Andrei Borzenkov wrote:
> 11.11.2015 16:14, Paulo Flabiano Smorigo пишет:
>
>> Same patch with the fix.
>> ---
>> grub-core/disk/ieee1275/ofdisk.c | 75
>>
11.11.2015 16:14, Paulo Flabiano Smorigo пишет:
Same patch with the fix.
---
grub-core/disk/ieee1275/ofdisk.c | 75
1 file changed, 75 insertions(+)
diff --git a/grub-core/disk/ieee1275/ofdisk.c b/grub-core/disk/ieee1275/ofdisk.c
index 297f058..ef290bc
Same patch with the fix.
---
grub-core/disk/ieee1275/ofdisk.c | 75
1 file changed, 75 insertions(+)
diff --git a/grub-core/disk/ieee1275/ofdisk.c b/grub-core/disk/ieee1275/ofdisk.c
index 297f058..ef290bc 100644
--- a/grub-core/disk/ieee1275/ofdisk.c
+++ b
