Re: [PATCH 1/3] ieee1275: ofdisk dangling pointer

2015-10-26 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 26.10.2015 22:43, Eric Snowberg wrote: > Within commit: 87ec3b7fa9061f470616ed927fc140e995831c00 - > "Don't continue to query block-size if disk doesn't have it.” > a dangling pointer was introduced. > > Fix dangling pointer issue in grub_ofdisk_open where devpath is freed > and then used again

Re: [PATCH 2/3] ieee1275: ofdisk memory leak

2015-10-26 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 26.10.2015 22:43, Eric Snowberg wrote: > Fix memory leak added within commit: > 87ec3b7fa9061f470616ed927fc140e995831c00 - "Don't continue to > query block-size if disk doesn't have it.” > Committed, thanks > Signed-off-by: Eric Snowberg > --- > grub-core/disk/ieee1275/ofdisk.c |6 +-

Re: [PATCH 3/3] ieee1275: ofdisk - don't continue to query block-size after we have it

2015-10-26 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 26.10.2015 22:43, Eric Snowberg wrote: > Within commit: 87ec3b7fa9061f470616ed927fc140e995831c00 - "Don't continue > to query block-size if disk doesn't have it.” Disks that returned 0 to the > block-size query, still get queried every time. > > Fix logic in grub_ofdisk_get_block_size so the b

[PATCH 2/3] ieee1275: ofdisk memory leak

2015-10-26 Thread Eric Snowberg
Fix memory leak added within commit: 87ec3b7fa9061f470616ed927fc140e995831c00 - "Don't continue to query block-size if disk doesn't have it.” Signed-off-by: Eric Snowberg --- grub-core/disk/ieee1275/ofdisk.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/grub-core/

[PATCH 1/3] ieee1275: ofdisk dangling pointer

2015-10-26 Thread Eric Snowberg
Within commit: 87ec3b7fa9061f470616ed927fc140e995831c00 - "Don't continue to query block-size if disk doesn't have it.” a dangling pointer was introduced. Fix dangling pointer issue in grub_ofdisk_open where devpath is freed and then used again within the call to grub_ofdisk_get_block_size. This s

[PATCH 3/3] ieee1275: ofdisk - don't continue to query block-size after we have it

2015-10-26 Thread Eric Snowberg
Within commit: 87ec3b7fa9061f470616ed927fc140e995831c00 - "Don't continue to query block-size if disk doesn't have it.” Disks that returned 0 to the block-size query, still get queried every time. Fix logic in grub_ofdisk_get_block_size so the block size is not requested upon each open since it w

Re: [PATCH v2] Suport for bi-endianess in elf file

2015-10-26 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 23.07.2015 16:10, Paulo Flabiano Smorigo wrote: > Updated version with the suggestions from Andrei Borzenkov. > > * grub-core/kern/elf.c: check and switch endianess with grub_{be,le}_to > cpu functions. > * grub-core/kern/elfXX.c: Likewise. Applied after fixing following problems: * Since you a