Re: grub2 and touch screen

2015-06-24 Thread Michael Zimmermann
doesn't your device have any buttons(volume?) without the keyboad? That would be way easier then adding touchscreen support especially if UEFI doesn't provide a API for that(which I guess it doesn't). On Wed, Jun 24, 2015 at 2:06 PM, Theodore Christophe < mission_theod...@hotmail.com> wrote: > he

grub2 and touch screen

2015-06-24 Thread Theodore Christophe
hello all, First of all, thank-you for your works. I have installed Fedora21 on my laptop (Medion all in one) with dual boot, and every-thing is working fine. Grub2 give me the choice between win8.1 and FC21, and other rescue. BUT when I use my laptop as touch pad (by removing the screen), wi

Re: [PATCH 2/4] Cryptomount support key files

2015-06-24 Thread Andrei Borzenkov
On Wed, Jun 24, 2015 at 2:26 PM, John Lane wrote: > + > + keyfile_size = grub_file_read (keyfile, key, keyfile_size); > + if (keyfile_size == (grub_size_t)-1) > + return grub_errno; If keyfile size is explicitly given, I expect that short read should be

Re: [PATCH 2/4] Cryptomount support key files

2015-06-24 Thread John Lane
On 24/06/15 07:59, Andrei Borzenkov wrote: > On Tue, Jun 23, 2015 at 8:27 PM, John Lane wrote: -err = cr->recover_key (source, dev, hdr); +err = cr->recover_key (source, dev, hdr, key, keyfile_size); >>> You never clear key variable, so after the first call all subsequent >>> inv

Re: [PATCH 2/4] Cryptomount support key files

2015-06-24 Thread Andrei Borzenkov
On Tue, Jun 23, 2015 at 8:27 PM, John Lane wrote: >>> -err = cr->recover_key (source, dev, hdr); >>> +err = cr->recover_key (source, dev, hdr, key, keyfile_size); >> You never clear key variable, so after the first call all subsequent >> invocations will always use it for any device. Movin