Re: [PATCH] grub-core/loader/i386/xen.c: Initialized initrd_ctx so we don't free a random pointer from the stack.

2015-03-27 Thread Andrei Borzenkov
В Fri, 27 Mar 2015 12:56:43 -0700 Sarah Newman пишет: > Signed-off-by: Sarah Newman > --- > grub-core/loader/i386/xen.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/grub-core/loader/i386/xen.c b/grub-core/loader/i386/xen.c > index c16b4b2..c4d9689 100644 > --- a/gru

[PATCH] grub-core/loader/i386/xen.c: Initialized initrd_ctx so we don't free a random pointer from the stack.

2015-03-27 Thread Sarah Newman
Signed-off-by: Sarah Newman --- grub-core/loader/i386/xen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/grub-core/loader/i386/xen.c b/grub-core/loader/i386/xen.c index c16b4b2..c4d9689 100644 --- a/grub-core/loader/i386/xen.c +++ b/grub-core/loader/i386/xen.c @@ -521,7 +52

RE: [PATCH v3] Add a module for retrieving SMBIOS information

2015-03-27 Thread Rajat Jain
[+Arthur] Hello Folks, I'm trying to get a binary / raw copy of this patch but could not find one. David, is it possible to please send us a binary / raw copy of this patch? Thanks, Rajat > -Original Message- > From: Andrei Borzenkov [mailto:arvidj...@gmail.com] > Sent: Friday, March

Re: [PATCH v2] grub-install: Install PV Xen binaries into the upstream specified path

2015-03-27 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 23.10.2014 23:28, Ian Campbell wrote: Upstream have defined a specification for where guests ought to place their xenpv grub binaries in order to facilitate chainloading from a stage 1 grub loaded from dom0. http://xenbits.xen.org/docs/unstable-staging/misc/x86-xenpv-bootloader.html The spec

Re: Query about GRUB_ENABLE_CRYPTODISK

2015-03-27 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Please commit this patch On 10.12.2014 04:25, Andrei Borzenkov wrote: В Tue, 09 Dec 2014 23:27:49 + Barry Jackson пишет: On 09/12/14 22:36, Barry Jackson wrote: On 09/12/14 18:27, Andrei Borzenkov wrote: В Tue, 09 Dec 2014 12:35:20 + Barry Jackson пишет: Hello, In Mageia it has be

Re: [PATCH v3] Add a module for retrieving SMBIOS information

2015-03-27 Thread Andrei Borzenkov
В Sun, 22 Mar 2015 22:01:49 -0400 David Michael пишет: > +struct __attribute__ ((packed)) grub_smbios_eps > + { > +grub_uint8_t anchor[4]; /* "_SM_" */ any plans to implement SMBIOS 3.0 (64 bit address) support? > +grub_uint8_t checksum; > +grub_uint8_t length; > +grub_uint8_

Re: [PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms

2015-03-27 Thread Daniel Kiper
On Fri, Mar 27, 2015 at 03:06:43PM +, Jan Beulich wrote: > >>> On 27.03.15 at 15:57, wrote: > > On Fri, Mar 27, 2015 at 02:34:19PM +, Jan Beulich wrote: > >> >>> On 27.03.15 at 15:26, wrote: > >> > On Fri, Mar 27, 2015 at 01:36:32PM +, Jan Beulich wrote: > >> >> >>> On 27.03.15 at 14:

Re: [PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms

2015-03-27 Thread Jan Beulich
>>> On 27.03.15 at 15:57, wrote: > On Fri, Mar 27, 2015 at 02:34:19PM +, Jan Beulich wrote: >> >>> On 27.03.15 at 15:26, wrote: >> > On Fri, Mar 27, 2015 at 01:36:32PM +, Jan Beulich wrote: >> >> >>> On 27.03.15 at 14:06, wrote: >> >> > On Tue, Mar 17, 2015 at 10:32:01AM +, Jan Beuli

Re: [PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms

2015-03-27 Thread Daniel Kiper
On Fri, Mar 27, 2015 at 02:34:19PM +, Jan Beulich wrote: > >>> On 27.03.15 at 15:26, wrote: > > On Fri, Mar 27, 2015 at 01:36:32PM +, Jan Beulich wrote: > >> >>> On 27.03.15 at 14:06, wrote: > >> > On Tue, Mar 17, 2015 at 10:32:01AM +, Jan Beulich wrote: > >> >> >>> On 30.01.15 at 18:

Re: [PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms

2015-03-27 Thread Jan Beulich
>>> On 27.03.15 at 15:26, wrote: > On Fri, Mar 27, 2015 at 01:36:32PM +, Jan Beulich wrote: >> >>> On 27.03.15 at 14:06, wrote: >> > On Tue, Mar 17, 2015 at 10:32:01AM +, Jan Beulich wrote: >> >> >>> On 30.01.15 at 18:54, wrote: >> >> > +/* Skip Multiboot2 information fixed part

Re: [PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms

2015-03-27 Thread Daniel Kiper
On Fri, Mar 27, 2015 at 01:36:32PM +, Jan Beulich wrote: > >>> On 27.03.15 at 14:06, wrote: > > On Tue, Mar 17, 2015 at 10:32:01AM +, Jan Beulich wrote: > >> >>> On 30.01.15 at 18:54, wrote: > >> > +/* Skip Multiboot2 information fixed part */ > >> > +lea MB2_fixed_siz

Re: [PATCH 17/18] x86/efi: create new early memory allocator

2015-03-27 Thread Daniel Kiper
On Fri, Mar 27, 2015 at 01:35:11PM +, Jan Beulich wrote: > >>> On 27.03.15 at 13:57, wrote: > > On Mon, Mar 02, 2015 at 05:23:49PM +, Jan Beulich wrote: > >> >>> On 30.01.15 at 18:54, wrote: > >> > +{ > >> > +void *ptr; > >> > + > >> > +/* > >> > + * Init __malloc_free on runt

Re: [Xen-devel] [PATCH 05/18] efi: split efi_enabled to efi_platform and efi_loader

2015-03-27 Thread Lennart Sorensen
On Fri, Mar 27, 2015 at 02:19:44PM +, Jan Beulich wrote: > >>> On 27.03.15 at 15:09, wrote: > > On Fri, Mar 27, 2015 at 02:04:22PM +, Jan Beulich wrote: > >> >>> On 27.03.15 at 14:53, wrote: > >> > On 27/03/15 13:43, Jan Beulich wrote: > >> > On 27.03.15 at 14:32, wrote: > >> >>> On

Re: [Xen-devel] [PATCH 05/18] efi: split efi_enabled to efi_platform and efi_loader

2015-03-27 Thread Jan Beulich
>>> On 27.03.15 at 15:09, wrote: > On Fri, Mar 27, 2015 at 02:04:22PM +, Jan Beulich wrote: >> >>> On 27.03.15 at 14:53, wrote: >> > On 27/03/15 13:43, Jan Beulich wrote: >> > On 27.03.15 at 14:32, wrote: >> >>> On Fri, Feb 20, 2015 at 04:17:35PM +, Jan Beulich wrote: >> >>> On 3

Re: [PATCH 05/18] efi: split efi_enabled to efi_platform and efi_loader

2015-03-27 Thread Lennart Sorensen
On Fri, Mar 27, 2015 at 02:04:22PM +, Jan Beulich wrote: > >>> On 27.03.15 at 14:53, wrote: > > On 27/03/15 13:43, Jan Beulich wrote: > > On 27.03.15 at 14:32, wrote: > >>> On Fri, Feb 20, 2015 at 04:17:35PM +, Jan Beulich wrote: > >>> On 30.01.15 at 18:54, wrote: > > We need

Re: [PATCH 05/18] efi: split efi_enabled to efi_platform and efi_loader

2015-03-27 Thread Jan Beulich
>>> On 27.03.15 at 14:53, wrote: > On 27/03/15 13:43, Jan Beulich wrote: > On 27.03.15 at 14:32, wrote: >>> On Fri, Feb 20, 2015 at 04:17:35PM +, Jan Beulich wrote: >>> On 30.01.15 at 18:54, wrote: > We need more fine grained knowledge about EFI environment and check > for EF

Re: [PATCH 05/18] efi: split efi_enabled to efi_platform and efi_loader

2015-03-27 Thread Andrew Cooper
On 27/03/15 13:43, Jan Beulich wrote: On 27.03.15 at 14:32, wrote: On Fri, Feb 20, 2015 at 04:17:35PM +, Jan Beulich wrote: On 30.01.15 at 18:54, wrote: We need more fine grained knowledge about EFI environment and check for EFI platform and EFI loader separately to properly support mult

Re: [PATCH 05/18] efi: split efi_enabled to efi_platform and efi_loader

2015-03-27 Thread Jan Beulich
>>> On 27.03.15 at 14:32, wrote: > On Fri, Feb 20, 2015 at 04:17:35PM +, Jan Beulich wrote: >> >>> On 30.01.15 at 18:54, wrote: >> > We need more fine grained knowledge about EFI environment and check >> > for EFI platform and EFI loader separately to properly support >> > multiboot2 protocol

Re: [PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms

2015-03-27 Thread Jan Beulich
>>> On 27.03.15 at 14:06, wrote: > On Tue, Mar 17, 2015 at 10:32:01AM +, Jan Beulich wrote: >> >>> On 30.01.15 at 18:54, wrote: >> > +/* Skip Multiboot2 information fixed part */ >> > +lea MB2_fixed_sizeof(%ebx),%ecx >> >> Let's please not add more assumptions than necessa

Re: [PATCH 17/18] x86/efi: create new early memory allocator

2015-03-27 Thread Jan Beulich
>>> On 27.03.15 at 13:57, wrote: > On Mon, Mar 02, 2015 at 05:23:49PM +, Jan Beulich wrote: >> >>> On 30.01.15 at 18:54, wrote: >> > +{ >> > +void *ptr; >> > + >> > +/* >> > + * Init __malloc_free on runtime. Static initialization >> > + * will not work because it puts virtual

Re: [PATCH 05/18] efi: split efi_enabled to efi_platform and efi_loader

2015-03-27 Thread Daniel Kiper
On Fri, Feb 20, 2015 at 04:17:35PM +, Jan Beulich wrote: > >>> On 30.01.15 at 18:54, wrote: > > We need more fine grained knowledge about EFI environment and check > > for EFI platform and EFI loader separately to properly support > > multiboot2 protocol. > > ... because of ... (i.e. I can't s

Re: [PATCH v3] Add a module for retrieving SMBIOS information

2015-03-27 Thread Andrei Borzenkov
В Fri, 27 Mar 2015 13:59:06 +0100 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > Could we avoid exposing such details as offset in structures? It's way > too technical perhaps something like > smbios [--handle=HANDLE|--instance=N] [--set VAR] [TABLE.VARNAME] > where table and varname will be str

Re: [PATCH 16/18] efi: create efi_exit_boot()

2015-03-27 Thread Ian Campbell
On Fri, 2015-03-27 at 13:43 +0100, Daniel Kiper wrote: > On Fri, Mar 27, 2015 at 12:10:56PM +, Jan Beulich wrote: > > >>> On 27.03.15 at 13:00, wrote: > > > Additionally, efi_start() > > > is architecture independent and efi_multiboot2() is x86 only and it should > > > live in x86 files. > > >

Re: [PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms

2015-03-27 Thread Daniel Kiper
On Tue, Mar 17, 2015 at 10:32:01AM +, Jan Beulich wrote: > >>> On 30.01.15 at 18:54, wrote: > > @@ -94,6 +111,17 @@ ENTRY(start) > > gdt_boot_descr: > > .word 6*8-1 > > .long sym_phys(trampoline_gdt) > > +.long 0 /* Needed for 64-bit lgdt */ > > + > > +cs32_swi

Re: [PATCH v3] Add a module for retrieving SMBIOS information

2015-03-27 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 23.03.2015 03:01, David Michael wrote: The following are two use cases from Rajat Jain: 1) We have a board that boots Linux and this board itself can be plugged into one of different chassis types. We need to pass different parameters to the kernel based on the "CHASSIS_TYPE" information th

Re: [PATCH 17/18] x86/efi: create new early memory allocator

2015-03-27 Thread Daniel Kiper
On Mon, Mar 02, 2015 at 05:23:49PM +, Jan Beulich wrote: > >>> On 30.01.15 at 18:54, wrote: > > --- a/xen/arch/x86/efi/efi-boot.h > > +++ b/xen/arch/x86/efi/efi-boot.h > > @@ -103,9 +103,35 @@ static void __init relocate_trampoline(unsigned long > > phys) > > *(u16 *)(*trampoline_ptr

Re: [PATCH 16/18] efi: create efi_exit_boot()

2015-03-27 Thread Daniel Kiper
On Fri, Mar 27, 2015 at 12:10:56PM +, Jan Beulich wrote: > >>> On 27.03.15 at 13:00, wrote: > > Additionally, efi_start() > > is architecture independent and efi_multiboot2() is x86 only and it should > > live in x86 files. > > Is that really the case? Looking at the grub2 sources I see suppor

Re: [PATCH 04/18] xen/x86: add multiboot2 protocol support

2015-03-27 Thread Jan Beulich
>>> On 27.03.15 at 13:22, wrote: > On Fri, Mar 27, 2015 at 11:20:10AM +, Jan Beulich wrote: >> >>> On 27.03.15 at 11:56, wrote: >> > On Fri, Feb 20, 2015 at 04:06:26PM +, Jan Beulich wrote: >> >> >>> On 30.01.15 at 18:54, wrote: >> >> > @@ -31,7 +38,16 @@ asm ( >> >> > ); >> >> > >>

Re: [PATCH] use stock embedded timestamp 2015-01-01T0000+0000

2015-03-27 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 22.03.2015 20:33, Daniel Kahn Gillmor wrote: Variant timestamps make some grub platforms produce non-deterministic core images. This makes it difficult to use simple tools to audit the stability of a system with grub installed. This patch selects a single timestamp to use for these embedded

Re: [PATCH 04/18] xen/x86: add multiboot2 protocol support

2015-03-27 Thread Daniel Kiper
On Fri, Mar 27, 2015 at 11:20:10AM +, Jan Beulich wrote: > >>> On 27.03.15 at 11:56, wrote: > > On Fri, Feb 20, 2015 at 04:06:26PM +, Jan Beulich wrote: > >> >>> On 30.01.15 at 18:54, wrote: > >> > --- a/xen/arch/x86/boot/Makefile > >> > +++ b/xen/arch/x86/boot/Makefile > >> > @@ -1,6 +1,

Re: [PATCH 16/18] efi: create efi_exit_boot()

2015-03-27 Thread Jan Beulich
>>> On 27.03.15 at 13:00, wrote: > Additionally, efi_start() > is architecture independent and efi_multiboot2() is x86 only and it should > live in x86 files. Is that really the case? Looking at the grub2 sources I see support for other than x86... Jan _

Re: [PATCH 16/18] efi: create efi_exit_boot()

2015-03-27 Thread Daniel Kiper
On Mon, Mar 02, 2015 at 04:45:47PM +, Jan Beulich wrote: > >>> On 30.01.15 at 18:54, wrote: > > ..which gets memory map and calls ExitBootServices(). We need this > > to support multiboot2 protocol on EFI platforms. > > Patches from 9 up to here all make sense on the basis that patch 18 > does

Re: [PATCH 08/18] efi: build xen.gz with EFI code

2015-03-27 Thread Andrew Cooper
On 27/03/15 11:46, Jan Beulich wrote: On 27.03.15 at 12:14, wrote: IIRC, MS ABI is supported starting from GCC v4.0. Where did you find that? From all I know __attribute__((__ms_abi__)) is being supported only by 4.5 and newer. The mere support of the MS ABI via command line option doesn't hel

Re: [PATCH 08/18] efi: build xen.gz with EFI code

2015-03-27 Thread Jan Beulich
>>> On 27.03.15 at 12:14, wrote: > IIRC, MS ABI is supported starting from GCC v4.0. Where did you find that? From all I know __attribute__((__ms_abi__)) is being supported only by 4.5 and newer. The mere support of the MS ABI via command line option doesn't help us, as we need to be able to mix

Re: [PATCH 04/18] xen/x86: add multiboot2 protocol support

2015-03-27 Thread Jan Beulich
>>> On 27.03.15 at 11:56, wrote: > On Fri, Feb 20, 2015 at 04:06:26PM +, Jan Beulich wrote: >> >>> On 30.01.15 at 18:54, wrote: >> > --- a/xen/arch/x86/boot/Makefile >> > +++ b/xen/arch/x86/boot/Makefile >> > @@ -1,6 +1,7 @@ >> > obj-bin-y += head.o >> > >> > -RELOC_DEPS = $(BASEDIR)/include

Re: [PATCH 08/18] efi: build xen.gz with EFI code

2015-03-27 Thread Daniel Kiper
On Mon, Mar 02, 2015 at 04:14:22PM +, Jan Beulich wrote: > >>> On 30.01.15 at 18:54, wrote: > > --- a/xen/arch/x86/efi/Makefile > > +++ b/xen/arch/x86/efi/Makefile > > @@ -1,14 +1,14 @@ > > CFLAGS += -fshort-wchar > > > > -obj-y += stub.o > > +obj-y += boot.o > > +obj-y += compat.o > > +obj-y

Re: [PATCH 00/18] x86: multiboot2 protocol support

2015-03-27 Thread Daniel Kiper
On Fri, Jan 30, 2015 at 06:54:04PM +0100, Daniel Kiper wrote: > Hi, > > I am sending, long awaited, first version of multiboot2 protocol > support for legacy BIOS and EFI platforms. New version with relocatable Xen early boot code is under tests now. I hope that I will release new version in 2-3 w

Re: [PATCH 04/18] xen/x86: add multiboot2 protocol support

2015-03-27 Thread Daniel Kiper
On Fri, Feb 20, 2015 at 04:06:26PM +, Jan Beulich wrote: > >>> On 30.01.15 at 18:54, wrote: > > --- a/xen/arch/x86/boot/Makefile > > +++ b/xen/arch/x86/boot/Makefile > > @@ -1,6 +1,7 @@ > > obj-bin-y += head.o > > > > -RELOC_DEPS = $(BASEDIR)/include/asm-x86/config.h > > $(BASEDIR)/include/x