Re: [PATCH] network mega patch

2012-05-03 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 04.05.2012 05:43, Bean wrote: > On Fri, May 4, 2012 at 3:50 AM, Vladimir 'φ-coder/phcoder' Serbinenko > wrote: >> On 03.05.2012 21:40, Bean wrote: >>> + if (rsm->asm_netbuff) >>> +grub_netbuff_free (rsm->asm_netbuff); >> Could you make grub_netbuff_free skip on NULL and so simplify it her

Re: [PATCH] network mega patch

2012-05-03 Thread Bean
On Fri, May 4, 2012 at 3:50 AM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 03.05.2012 21:40, Bean wrote: >> +  if (rsm->asm_netbuff) >> +    grub_netbuff_free (rsm->asm_netbuff); >  Could you make grub_netbuff_free skip on NULL and so simplify it here? Hi, I think this is one of the few pl

Re: [PATCH,HURD] Fix grub-probe with userland partition support

2012-05-03 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 30.04.2012 20:58, Samuel Thibault wrote: > Here is an updated patch. > > Samuel Committed. > > > ___ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel -- Regards Vladimir 'φ-coder/phcoder' Serbinenko

Re: [PATCH] network mega patch

2012-05-03 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 03.05.2012 21:40, Bean wrote: > + if (rsm->asm_netbuff) > +grub_netbuff_free (rsm->asm_netbuff); Could you make grub_netbuff_free skip on NULL and so simplify it here? When you've done this you can commit bug.diff. Thank you -- Regards Vladimir 'φ-coder/phcoder' Serbinenko signature.

Re: [PATCH] network mega patch

2012-05-03 Thread Bean
Hi, No problem. I split the patch into two parts. On Fri, May 4, 2012 at 3:28 AM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 03.05.2012 21:19, Bean wrote: >> Hi, >> >> This patch fixes some serious bugs and memory leaks in the network >> stack. It also contains two optimization: >> >> 1,

Re: [PATCH] network mega patch

2012-05-03 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 03.05.2012 21:19, Bean wrote: > Hi, > > This patch fixes some serious bugs and memory leaks in the network > stack. It also contains two optimization: > > 1, use default block size of 4096. block size is configurable via > tftp_block_size environment variable. > 2, reuse netbuff in efinet driver

[PATCH] network mega patch

2012-05-03 Thread Bean
Hi, This patch fixes some serious bugs and memory leaks in the network stack. It also contains two optimization: 1, use default block size of 4096. block size is configurable via tftp_block_size environment variable. 2, reuse netbuff in efinet driver when there is no data, this saves some alloc/f

Re: [PATCH] bug fix for efi network

2012-05-03 Thread Bean
On Thu, May 3, 2012 at 11:38 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 29.04.2012 17:05, Bean wrote: >> +  for (i = 0; i < 3; i++) >>      { >> +      grub_uint64_t limit_time; >> + >> +      efi_call_3 (net->get_status, net, &int_status, 0); >> + >> +      limit_time = grub_get_time_m

Re: [PATCH] bug fix for efi network

2012-05-03 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 29.04.2012 17:05, Bean wrote: > + for (i = 0; i < 3; i++) > { > + grub_uint64_t limit_time; > + > + efi_call_3 (net->get_status, net, &int_status, 0); > + > + limit_time = grub_get_time_ms () + 5; > + for (;;) > + { > + st = efi_call_7 (net->transm

Re: [PATCH] bug fix for efi network

2012-05-03 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 29.04.2012 20:19, Bean wrote: > 2012/4/30 Vladimir 'φ-coder/phcoder' Serbinenko : >> On 29.04.2012 10:22, Bean wrote: >>> Hi, >>> >>> This patch fix a few bugs in efinet. >>> >>> It also change the tftp block size from 1024 to 8192, which would >>> result in HUGE speed difference. In my previous