Re: [PATCH] bug fix for ntfs

2012-04-24 Thread Thomas Frauendorfer
On Wed, Apr 25, 2012 at 5:01 AM, Bean wrote: > Thanks for the info, I don't have any 4K drive to test. You can check > if ntfs fs driver is working properly since I don't remember if I have > made the 1024 MFT assumption elsewhere. I don't know yet when I will have the time to test it because the

Re: [PATCH] bug fix for ntfs

2012-04-24 Thread Bean
Hi, On Tue, Apr 24, 2012 at 11:36 PM, Thomas Frauendorfer wrote: > When I formated a disk with 4K sectors in Windows it used a complete > sector for each MFT record. The block size is not relevant for the MFT > record size, but the sector size of the disk is. Thanks for the info, I don't have an

Re: [PATCH,HURD] Fix grub-probe with userland partition support

2012-04-24 Thread Samuel Thibault
Vladimir 'φ-coder/phcoder' Serbinenko, le Wed 25 Apr 2012 01:57:54 +0200, a écrit : > On 25.04.2012 01:52, Samuel Thibault wrote: > > +grub_util_error (_("Could not open path `%s'"), path); > This one should be unified with other similar messages. Err, in the file I can see various ways: "Una

RFC: UEFI/PXE and emulating grub-legacy-uefi-hacked behaviour

2012-04-24 Thread Richard Chan
I am interested in getting UEFI/PXE working using the EFI IP/TFTP stack as hacked versions of grub-legacy (e,g., Fedora 17). Is there any wisdom that the list would like to shed? 1. ON EFI platforms grub-legacy directly uses the EFI TFTP stack and not its own i386-pc/TFTP stack. Network tftp-able

Re: [PATCH,HURD] Fix grub-probe with userland partition support

2012-04-24 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 25.04.2012 01:52, Samuel Thibault wrote: > +grub_util_error (_("Could not open path `%s'"), path); This one should be unified with other similar messages. It would also have advantage of giving strerror. strerror should be given on all lib errors. -- Regards Vladimir 'φ-coder/phcoder' Serb

Re: [PATCH,HURD] Fix grub-probe with userland partition support

2012-04-24 Thread Samuel Thibault
Here is an updated patch. Samuel === modified file 'util/getroot.c' --- util/getroot.c 2012-04-22 19:02:55 + +++ util/getroot.c 2012-04-25 01:41:04 + @@ -700,6 +700,69 @@ #elif defined (__GNU__) +static char * +find_hurd_root_device (const char *path) +{ + file_t file; + e

Re: [PATCH,HURD] Fix grub-probe with userland partition support

2012-04-24 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 25.04.2012 00:39, Samuel Thibault wrote: > Vladimir 'φ-coder/phcoder' Serbinenko, le Wed 25 Apr 2012 00:31:26 +0200, a > écrit : >> On 25.04.2012 00:21, Samuel Thibault wrote: >>> Vladimir 'φ-coder/phcoder' Serbinenko, le Tue 24 Apr 2012 22:14:33 +0200, a >>> écrit : On 24.04.2012 19:13,

Re: [PATCH,HURD] Fix grub-probe with userland partition support

2012-04-24 Thread Samuel Thibault
Vladimir 'φ-coder/phcoder' Serbinenko, le Wed 25 Apr 2012 00:31:26 +0200, a écrit : > On 25.04.2012 00:21, Samuel Thibault wrote: > > Vladimir 'φ-coder/phcoder' Serbinenko, le Tue 24 Apr 2012 22:14:33 +0200, a > > écrit : > >> On 24.04.2012 19:13, Samuel Thibault wrote: > >>> Vladimir 'φ-coder/ph

Re: [PATCH,HURD] Fix grub-probe with userland partition support

2012-04-24 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 25.04.2012 00:21, Samuel Thibault wrote: > Vladimir 'φ-coder/phcoder' Serbinenko, le Tue 24 Apr 2012 22:14:33 +0200, a > écrit : >> On 24.04.2012 19:13, Samuel Thibault wrote: >>> Vladimir 'φ-coder/phcoder' Serbinenko, le Tue 24 Apr 2012 15:19:25 +0200, a >>> écrit : On 24.04.2012 14:42,

Re: [PATCH,HURD] Fix grub-probe with userland partition support

2012-04-24 Thread Samuel Thibault
Vladimir 'φ-coder/phcoder' Serbinenko, le Tue 24 Apr 2012 22:14:33 +0200, a écrit : > On 24.04.2012 19:13, Samuel Thibault wrote: > > Vladimir 'φ-coder/phcoder' Serbinenko, le Tue 24 Apr 2012 15:19:25 +0200, a > > écrit : > >> On 24.04.2012 14:42, Samuel Thibault wrote: > >>> 0-sized indeed poses

Re: [PATCH,HURD] Fix grub-probe with userland partition support

2012-04-24 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 24.04.2012 19:13, Samuel Thibault wrote: > Vladimir 'φ-coder/phcoder' Serbinenko, le Tue 24 Apr 2012 15:19:25 +0200, a > écrit : >> On 24.04.2012 14:42, Samuel Thibault wrote: >>> Vladimir 'φ-coder/phcoder' Serbinenko, le Tue 24 Apr 2012 11:55:33 +0200, a >>> écrit : They have iso9660 spa

Re: [PATCH,HURD] Fix grub-probe with userland partition support

2012-04-24 Thread Samuel Thibault
Vladimir 'φ-coder/phcoder' Serbinenko, le Tue 24 Apr 2012 15:19:25 +0200, a écrit : > On 24.04.2012 14:42, Samuel Thibault wrote: > > Vladimir 'φ-coder/phcoder' Serbinenko, le Tue 24 Apr 2012 11:55:33 +0200, a > > écrit : > >> They have iso9660 spanning through > >> the whole disk but all of the

Re: [PATCH] bug fix for ntfs

2012-04-24 Thread Thomas Frauendorfer
On Mon, Apr 23, 2012 at 6:03 PM, Bean wrote: > Hi, > > 2, Previous version doesn't return blocklist information for small > files embed in MFT, this patch fixes it. For example, create a > 512-byte file test in ntfs and try this command: > > grub-fstest /ntfs.img blocklist /tes

Re: [PATCH,HURD] Fix grub-probe with userland partition support

2012-04-24 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 24.04.2012 14:42, Samuel Thibault wrote: > Vladimir 'φ-coder/phcoder' Serbinenko, le Tue 24 Apr 2012 11:55:33 +0200, a > écrit : >> One could have hd0s1 containing hd0s5 and hd0s6. > Argl, I forgot that case indeed. It's funny how that contracts the very > word "partition"... > >> In this case

Re: [PATCH,HURD] Fix grub-probe with userland partition support

2012-04-24 Thread Samuel Thibault
Vladimir 'φ-coder/phcoder' Serbinenko, le Tue 24 Apr 2012 11:55:33 +0200, a écrit : > One could have hd0s1 containing hd0s5 and hd0s6. Argl, I forgot that case indeed. It's funny how that contracts the very word "partition"... > In this case we want hd0s5 and not hd0s1. On the other hand a file

Re: [PATCH,HURD] Fix grub-probe with userland partition support

2012-04-24 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 24.04.2012 11:19, Samuel Thibault wrote: > Because path_start is the start of the file, not of the partition > containing the file. > >> > Some partitions may contain more partitions, like logical container >> > contains logical partitions. > Yes, but we do not have defined /dev namings for thes

Re: [PATCH,HURD] Fix grub-probe with userland partition support

2012-04-24 Thread Samuel Thibault
Vladimir 'φ-coder/phcoder' Serbinenko, le Tue 24 Apr 2012 11:44:35 +0200, a écrit : > On 24.04.2012 11:38, Samuel Thibault wrote: > > Samuel Thibault, le Tue 24 Apr 2012 11:36:27 +0200, a écrit : > >> Vladimir 'φ-coder/phcoder' Serbinenko, le Tue 24 Apr 2012 11:26:46 +0200, > >> a écrit : > >>> T

Re: [PATCH,HURD] Fix grub-probe with userland partition support

2012-04-24 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 24.04.2012 11:38, Samuel Thibault wrote: > Samuel Thibault, le Tue 24 Apr 2012 11:36:27 +0200, a écrit : >> Vladimir 'φ-coder/phcoder' Serbinenko, le Tue 24 Apr 2012 11:26:46 +0200, a >> écrit : >>> Theoretically you shouldn't stop until you find the partition if you >>> know that your device i

Re: [PATCH,HURD] Fix grub-probe with userland partition support

2012-04-24 Thread Samuel Thibault
Samuel Thibault, le Tue 24 Apr 2012 11:36:27 +0200, a écrit : > Vladimir 'φ-coder/phcoder' Serbinenko, le Tue 24 Apr 2012 11:26:46 +0200, a > écrit : > > Theoretically you shouldn't stop until you find the partition if you > > know that your device is partition > > What do you precisely mean by "

Re: [PATCH,HURD] Fix grub-probe with userland partition support

2012-04-24 Thread Samuel Thibault
Vladimir 'φ-coder/phcoder' Serbinenko, le Tue 24 Apr 2012 11:26:46 +0200, a écrit : > Theoretically you shouldn't stop until you find the partition if you > know that your device is partition What do you precisely mean by "device"? What we don't know is whether the root storage for the file is p

Re: [PATCH,HURD] Fix grub-probe with userland partition support

2012-04-24 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 24.04.2012 11:16, Samuel Thibault wrote: > Vladimir 'φ-coder/phcoder' Serbinenko, le Tue 24 Apr 2012 11:12:11 +0200, a > écrit : >> On 24.04.2012 11:00, Samuel Thibault wrote: >>> Vladimir 'φ-coder/phcoder' Serbinenko, le Tue 24 Apr 2012 10:55:21 +0200, a >>> écrit : On 24.04.2012 01:34,

Re: [PATCH,HURD] Fix grub-probe with userland partition support

2012-04-24 Thread Samuel Thibault
Vladimir 'φ-coder/phcoder' Serbinenko, le Tue 24 Apr 2012 11:04:46 +0200, a écrit : > On 24.04.2012 01:34, Samuel Thibault wrote: > > +/* Retrieve the storage information for PATH, and search which partitions > > + * contains its start. */ > > +static char * > > +find_hurd_root_device (const char

Re: [PATCH,HURD] Fix grub-probe with userland partition support

2012-04-24 Thread Samuel Thibault
Vladimir 'φ-coder/phcoder' Serbinenko, le Tue 24 Apr 2012 11:12:11 +0200, a écrit : > On 24.04.2012 11:00, Samuel Thibault wrote: > > Vladimir 'φ-coder/phcoder' Serbinenko, le Tue 24 Apr 2012 10:55:21 +0200, a > > écrit : > >> On 24.04.2012 01:34, Samuel Thibault wrote: > >>> + if (errno == ENO

Re: [PATCH,HURD] Fix grub-probe with userland partition support

2012-04-24 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 24.04.2012 11:00, Samuel Thibault wrote: > Vladimir 'φ-coder/phcoder' Serbinenko, le Tue 24 Apr 2012 10:55:21 +0200, a > écrit : >> On 24.04.2012 01:34, Samuel Thibault wrote: >>> + if (errno == ENOENT && part >= 5) >>> + { >> This introduces an assumption that if part >=5 is missing

Re: [PATCH,HURD] Fix grub-probe with userland partition support

2012-04-24 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 24.04.2012 01:34, Samuel Thibault wrote: > +/* Retrieve the storage information for PATH, and search which partitions > + * contains its start. */ > +static char * > +find_hurd_root_device (const char *path) > +{ > + struct store *path_store, *part_store; > + char *devpath = NULL; > + const

Re: [PATCH,HURD] Fix grub-probe with userland partition support

2012-04-24 Thread Samuel Thibault
Vladimir 'φ-coder/phcoder' Serbinenko, le Tue 24 Apr 2012 10:55:21 +0200, a écrit : > On 24.04.2012 01:34, Samuel Thibault wrote: > > + if (errno == ENOENT && part >= 5) > > + { > This introduces an assumption that if part >=5 is missing then there are > no additional partitions. While t

Re: [PATCH,HURD] Fix grub-probe with userland partition support

2012-04-24 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 24.04.2012 01:34, Samuel Thibault wrote: > + if (errno == ENOENT && part >= 5) > + { This introduces an assumption that if part >=5 is missing then there are no additional partitions. While this is true for msdos, it's false for GPT, where such config is common after deleting a par