lib/arg.c: dynamic newline in help

2009-12-26 Thread Carles Pina i Estany
Hello, Until now the options for the commands has been splitted (using a \n) by the developer. For example, commands/hdparm.c: static const struct grub_arg_option options[] = { {"apm", 'B', 0, "Set Advanced Power Management\n" "(1=low, ..., 254=high,

Re: regression fix

2009-12-26 Thread Carles Pina i Estany
Hi, On Dec/26/2009, Robert Millan wrote: > On Sat, Dec 26, 2009 at 01:35:53AM +0100, Carles Pina i Estany wrote: > > > > Hi, > > > > Commit 1949 introduced a bug using TAB due a miss-understanding that I > > had with the code. > > Oh, good to know. I was wondering why TAB expansion did these

Re: [RFC] Dynamic device.map

2009-12-26 Thread Robert Millan
On Sat, Dec 26, 2009 at 01:37:14PM -0800, David Miller wrote: > From: Robert Millan > Date: Sat, 26 Dec 2009 14:25:51 +0100 > > > Then we rely only on UUIDs. > > This is exactly what I suggested we should avoid. > > On OpenFirmware we scan every device alias, %80 of them point to > non-existing

Re: [RFC] Dynamic device.map

2009-12-26 Thread David Miller
From: Robert Millan Date: Sat, 26 Dec 2009 14:25:51 +0100 > Then we rely only on UUIDs. This is exactly what I suggested we should avoid. On OpenFirmware we scan every device alias, %80 of them point to non-existing devices. The aliases are just an enumeration of the set of devices that could

Re: Non-static variables and nested function pointers [bug #28392]

2009-12-26 Thread Grégoire Sutre
Robert Millan wrote: The following snippet (kern/misc.c) comes to mind: #ifdef NEED_ENABLE_EXECUTE_STACK /* Some gcc versions generate a call to this function in trampolines for nested functions. */ void __enable_execute_stack (void *addr __attribute__ ((unused))) { } #endif I was away fr

Re: user messages

2009-12-26 Thread Carles Pina i Estany
Hi, On Dec/26/2009, Robert Millan wrote: > On Sat, Dec 26, 2009 at 11:20:27AM +0100, Carles Pina i Estany wrote: > >cmd_linux = grub_register_command ("linux", grub_cmd_linux, > > -0, "Load linux."); > > +0, "Load a Linux kernel.

Re: regression fix

2009-12-26 Thread Robert Millan
On Sat, Dec 26, 2009 at 01:35:53AM +0100, Carles Pina i Estany wrote: > > Hi, > > Commit 1949 introduced a bug using TAB due a miss-understanding that I > had with the code. Oh, good to know. I was wondering why TAB expansion did these weird things ;-) > - plen = grub_strlen (prompt_translate

Re: Grub is the bootloader used on Win7?

2009-12-26 Thread Robert Millan
On Sat, Dec 26, 2009 at 12:37:49AM -0600, richardvo...@gmail.com wrote: > > SLIC is part of the mechanism Windows (many versions) uses to volume > license to OEMs and enable OEM recovery disks which only work on a > particular brand or model of computer. The SLIC is supposed to be > included in t

Re: user messages

2009-12-26 Thread Robert Millan
On Sat, Dec 26, 2009 at 11:20:27AM +0100, Carles Pina i Estany wrote: >cmd_linux = grub_register_command ("linux", grub_cmd_linux, > - 0, "Load linux."); > + 0, "Load a Linux kernel."); The construct "Linux kernel" is very ambig

Re: Fix for grub_assert_fail undefined on NetBSD and other platforms

2009-12-26 Thread Robert Millan
On Fri, Dec 25, 2009 at 06:21:58PM +0100, Felix Zielcke wrote: > Am Donnerstag, den 24.12.2009, 22:55 +0100 schrieb Robert Millan: > > On Tue, Dec 22, 2009 at 09:39:07PM +0530, BVK Chaitanya wrote: > > > Hi > > > > > > > > > Attached is the patch, which removes use of undefined > > grub_assert_fa

Re: [RFC] Dynamic device.map

2009-12-26 Thread Robert Millan
On Thu, Dec 24, 2009 at 10:18:27PM +0100, Robert Millan wrote: > > No, I don't think we will. grub-probe is perfectly capable of mapping > > /dev/sda1 to (hd0,1) even without device.map; > > I wasn't very fond of this because it's BIOS-specific. But I guess we can > live with it. On second thoug

Re: patch to compile video/readers/* with test

2009-12-26 Thread Carles Pina i Estany
Hi, On Dec/26/2009, Carles Pina i Estany wrote: > Find an attached patch that fix the compilation of video/readers/* when > DEBUG is enabled. validated in IRC, pushing now -- Carles Pina i Estany http://pinux.info ___ Grub-devel mailing li

Re: patch to compile video/readers/* with debug

2009-12-26 Thread Carles Pina i Estany
Correct Subject: is "with debug" (not with test) -- Carles Pina i Estany http://pinux.info ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

patch to compile video/readers/* with test

2009-12-26 Thread Carles Pina i Estany
Hi, Find an attached patch that fix the compilation of video/readers/* when DEBUG is enabled. If ok I would commit. Thanks, -- Carles Pina i Estany http://pinux.info === modified file 'ChangeLog' --- ChangeLog 2009-12-26 10:01:33 + +++ ChangeLog 2009-12-26 10:42:57 + @@ -1,5 +

user messages

2009-12-26 Thread Carles Pina i Estany
Hello, Find an attached patch. Linux should be always capitalized. All Linux loaders should have the same message: consistency, better LZMA and less work for translators. If you prefer another string tell me and I'll change. -- Carles Pina i Estany http://pinux.info === modified file