Re: Unittests

2009-12-14 Thread BVK Chaitanya
Hi Carles, Yes, I wrote unit testing framework and is available as a patch here: http://lists.gnu.org/archive/html/grub-devel/2009-11/msg00349.html It is not reviewed and is very basic as of now. It has no example for scripted tests, but can be added using check_SCRIPTS make/rmk variable, simil

Unittests

2009-12-14 Thread Carles Pina i Estany
Hello, I remember that BVK was interested to add some unit tests in Grub2. Soon, when gettext will be a bit more far I' could write a unit test for gettext module (habit from work :-) -actually I wanted to do even if I don't publish it). Writing a unittest for gettext it's very easy: it just ne

Understanding GRUB details

2009-12-14 Thread Bruce Dubbs
In order to properly document GRUB, I have been reviewing some of the code at a rather detailed level. My efforts are directed at developing an intimate level of understanding as a prerequisite for the documentation effort. I fully understand that many of the details below are not appropriate

Re: execution of update-grub in chroots might fail

2009-12-14 Thread Felix Zielcke
Am Montag, den 14.12.2009, 13:36 +0100 schrieb Michael Prokop: > >> The simplest fix is to add '&& [ -e /boot/grub/grub.cfg ]' to the > >> test in memtest86+; that is, if the configuration file hasn't > >> been generated already, it shouldn't be updated. (This check is > >> in the memtest86+ postin

Re: execution of update-grub in chroots might fail

2009-12-14 Thread Michael Prokop
* Felix Zielcke wrote: > Am Montag, den 14.12.2009, 11:56 + schrieb Colin Watson: >> On Sun, Dec 13, 2009 at 11:08:04PM +0100, Michael Prokop wrote: >> > For example postinst of memtest86+ uses: >> > if [ "$1" = "configure" ] && [ -x "`which update-grub2 >> 2>/dev/null`" >> > ] ; then >> >

Re: execution of update-grub in chroots might fail

2009-12-14 Thread Felix Zielcke
Am Montag, den 14.12.2009, 11:56 + schrieb Colin Watson: > On Sun, Dec 13, 2009 at 11:08:04PM +0100, Michael Prokop wrote: > > For example postinst of memtest86+ uses: > > > > if [ "$1" = "configure" ] && [ -x "`which update-grub2 > 2>/dev/null`" ] ; then > > update-grub2 > > fi > >

Re: execution of update-grub in chroots might fail

2009-12-14 Thread Colin Watson
On Sun, Dec 13, 2009 at 11:08:04PM +0100, Michael Prokop wrote: > as reported in #550337 update-grub might fail inside chroots. > I'm providing detailed information about this issue in this mail as > discussed on IRC in #grub. update-grub is actually a Debian-specific wrapper around grub-mkconfig.