Re: chmod of generated grub.cfg

2009-09-06 Thread richardvo...@gmail.com
On Sun, Sep 6, 2009 at 12:22 PM, Vladimir 'phcoder' Serbinenko wrote: > On Sun, Sep 6, 2009 at 3:38 PM, Colin Watson wrote: >> On Sun, Sep 06, 2009 at 02:29:03PM +0200, Felix Zielcke wrote: >>> Currently grub-mkconfig uses chmod 444 on the newly generated grub.cfg >>> Wouldn't it be better to use 4

Re: chmod of generated grub.cfg

2009-09-06 Thread Robert Millan
On Sun, Sep 06, 2009 at 05:17:34PM +0200, Felix Zielcke wrote: > Am Sonntag, den 06.09.2009, 17:09 +0200 schrieb Robert Millan: > > On Sun, Sep 06, 2009 at 04:58:40PM +0200, Felix Zielcke wrote: > > > > > > Ok here's now a patch. > > > Robert do you think this can go into 1.97? > > > > For 1.97 I

Re: Report: compil error on OSX for target=i386

2009-09-06 Thread Felix Zielcke
Am Sonntag, den 06.09.2009, 20:56 +0200 schrieb Yves Blusseau: > Le 6 sept. 09 à 16:54, Robert Millan a écrit : > > > On Sun, Sep 06, 2009 at 06:55:41AM +0200, Yves Blusseau wrote: > >> > >> Le 5 sept. 09 à 22:31, Robert Millan a écrit : > >> > >>> On Sat, Sep 05, 2009 at 03:17:58PM +0200, Michal

Re: Report: compil error on OSX for target=i386

2009-09-06 Thread Yves Blusseau
Le 6 sept. 09 à 16:54, Robert Millan a écrit : On Sun, Sep 06, 2009 at 06:55:41AM +0200, Yves Blusseau wrote: Le 5 sept. 09 à 22:31, Robert Millan a écrit : On Sat, Sep 05, 2009 at 03:17:58PM +0200, Michal Suchanek wrote: Still the time and space required to build GCC is much larger than

grub_mod_init and grub_mod_fini missing from symbol table

2009-09-06 Thread Neil Cafferkey
Hi, When compiling GRUB with GCC 3.4.3, I had the problem that my modules didn't work, apparently because the symbols grub_mod_init and grub_mod_fini weren't in the modules' symbol tables. Does the absence of these symbols indicate a bug in GCC, or does "__attribute__ ((used))" not in fact guaran

[PATCH] hide `Try 'help' for usage' if help doestn't exist in rescue mode

2009-09-06 Thread Felix Zielcke
I think we shouldn't tell users to type `help' if the command doestn't exist in rescue mode, i.e. minicmd isn't included in core.img This increases the size of kernel.img for me by 28 bytes. I think it's worth. It's so small I don't bother to attach it: 2009-09-06 Felix Zielcke * kern

Re: Report: compil error on OSX for target=i386

2009-09-06 Thread Yves Blusseau
Le 6 sept. 09 à 19:17, Vladimir 'phcoder' Serbinenko a écrit : checking whether target compiler is working... no configure: error: cannot compile for the target and if i look into the config.log it's because it use the default apple linker tool witch don't recognize some arguments: configu

Re: [PATCH] Change clean rules to properly remove files

2009-09-06 Thread Yves Blusseau
Le 6 sept. 09 à 17:18, Duboucher Thomas a écrit : -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Robert Millan a écrit : On Sun, Sep 06, 2009 at 02:19:54PM +0200, Yves Blusseau wrote: Is it ok to commit ? Please wait a few more days. It's doubtful that anyone would be interested (and ca

Re: chmod of generated grub.cfg

2009-09-06 Thread Vladimir 'phcoder' Serbinenko
On Sun, Sep 6, 2009 at 3:38 PM, Colin Watson wrote: > On Sun, Sep 06, 2009 at 02:29:03PM +0200, Felix Zielcke wrote: >> Currently grub-mkconfig uses chmod 444 on the newly generated grub.cfg >> Wouldn't it be better to use 400 now that we have plaintext password >> support? >> Or should we add supp

Re: Report: compil error on OSX for target=i386

2009-09-06 Thread Vladimir 'phcoder' Serbinenko
> checking whether target compiler is working... no > configure: error: cannot compile for the target > > and if i look into the config.log it's because it use the default apple > linker tool witch don't recognize some arguments: > > configure:5882: gcc-mp-4.4 -o conftest -Wall -W -Wshadow -Wpointe

Fwd: [RFC] Eliminate NESTED_ATTR_FUNC

2009-09-06 Thread Vladimir 'phcoder' Serbinenko
-- Forwarded message -- From: David Miller Date: Sun, Sep 6, 2009 at 12:23 AM Subject: Re: [RFC] Eliminate NESTED_ATTR_FUNC To: phco...@gmail.com From: "Vladimir 'phcoder' Serbinenko" Date: Sat, 5 Sep 2009 23:04:00 +0200 > On Fri, Sep 4, 2009 at 1:17 AM, David Miller wrote: >>

Re: Report: compil error on OSX for target=i386

2009-09-06 Thread Yves Blusseau
Le 6 sept. 09 à 16:54, Robert Millan a écrit : On Sun, Sep 06, 2009 at 06:55:41AM +0200, Yves Blusseau wrote: Le 5 sept. 09 à 22:31, Robert Millan a écrit : On Sat, Sep 05, 2009 at 03:17:58PM +0200, Michal Suchanek wrote: Still the time and space required to build GCC is much larger than

Re: Require at least gcc 4.2

2009-09-06 Thread Robert Millan
On Sun, Sep 06, 2009 at 04:03:28PM +0100, Neil Cafferkey wrote: > > No offence, but this proposal strikes me as slightly lazy. In other words, > I think these bugs should be identified instead of being "fixed" by > declaring "your compiler is too old". In this case, we weren't speaking about bugs

Re: [PATCH] Change clean rules to properly remove files

2009-09-06 Thread Duboucher Thomas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Robert Millan a écrit : > On Sun, Sep 06, 2009 at 02:19:54PM +0200, Yves Blusseau wrote: >> Is it ok to commit ? > > Please wait a few more days. It's doubtful that anyone would be interested > (and capable) of reviewing ruby code, but it's still wor

Re: chmod of generated grub.cfg

2009-09-06 Thread Felix Zielcke
Am Sonntag, den 06.09.2009, 17:09 +0200 schrieb Robert Millan: > On Sun, Sep 06, 2009 at 04:58:40PM +0200, Felix Zielcke wrote: > > > > Ok here's now a patch. > > Robert do you think this can go into 1.97? > > For 1.97 I'd be more comfortable with a simple s/444/400/. An automated check > smells

Re: chmod of generated grub.cfg

2009-09-06 Thread Robert Millan
On Sun, Sep 06, 2009 at 04:58:40PM +0200, Felix Zielcke wrote: > > Ok here's now a patch. > Robert do you think this can go into 1.97? For 1.97 I'd be more comfortable with a simple s/444/400/. An automated check smells like it could have corner cases. In fact I found one: > @@ -260,6 +260,11

Re: Require at least gcc 4.2

2009-09-06 Thread Robert Millan
On Sat, Sep 05, 2009 at 03:12:14PM -0700, David Miller wrote: > From: Robert Millan > Date: Sat, 5 Sep 2009 23:26:11 +0200 > > > David et al, can we agree on a minimal version of GCC that we should > > recommend? > > > > For mentioning in the INSTALL file only. I assume nobody's interested in >

Re: Require at least gcc 4.2

2009-09-06 Thread Neil Cafferkey
On Thu, Sep 03, 2009 at 04:21:55PM +0200, Robert Millan wrote: > On Tue, Sep 01, 2009 at 03:23:01PM -0700, David Miller wrote: > > From: "Vladimir 'phcoder' Serbinenko" > > Date: Tue, 1 Sep 2009 16:12:20 +0200 > > > > > Even if gcc<4.2 seem to work ok I think we shouldn't waste resources > > > on

Re: chmod of generated grub.cfg

2009-09-06 Thread Robert Millan
On Sun, Sep 06, 2009 at 02:38:18PM +0100, Colin Watson wrote: > > A GRUB_CHMOD > variable seems overkill, though. Yes. Please not a new config option just for this. Just pick a reasonable mode and set to it. Auto-detection doesn't sound bad, although I'd be fine with just using 0400. > > Else

Re: chmod of generated grub.cfg

2009-09-06 Thread Felix Zielcke
Am Sonntag, den 06.09.2009, 14:57 +0100 schrieb Colin Watson: > On Sun, Sep 06, 2009 at 03:43:46PM +0200, Felix Zielcke wrote: > > Am Sonntag, den 06.09.2009, 14:38 +0100 schrieb Colin Watson: > > > I think it'd be more sensible to do this in grub-mkconfig itself - it > > > doesn't really fit well

Re: [PATCH] Change clean rules to properly remove files

2009-09-06 Thread Robert Millan
On Sun, Sep 06, 2009 at 02:19:54PM +0200, Yves Blusseau wrote: > > Is it ok to commit ? Please wait a few more days. It's doubtful that anyone would be interested (and capable) of reviewing ruby code, but it's still worth a try. If noone objects, you can commit this. -- Robert Millan The DR

Re: Report: compil error on OSX for target=i386

2009-09-06 Thread Robert Millan
On Sun, Sep 06, 2009 at 06:55:41AM +0200, Yves Blusseau wrote: > > Le 5 sept. 09 à 22:31, Robert Millan a écrit : > >> On Sat, Sep 05, 2009 at 03:17:58PM +0200, Michal Suchanek wrote: >>> >>> Still the time and space required to build GCC is much larger than >>> that required for building grub. The

Re: chmod of generated grub.cfg

2009-09-06 Thread Colin Watson
On Sun, Sep 06, 2009 at 03:43:46PM +0200, Felix Zielcke wrote: > Am Sonntag, den 06.09.2009, 14:38 +0100 schrieb Colin Watson: > > I think it'd be more sensible to do this in grub-mkconfig itself - it > > doesn't really fit well into the /etc/grub.d/ hook system, which is > > really just for genera

Re: chmod of generated grub.cfg

2009-09-06 Thread Felix Zielcke
Am Sonntag, den 06.09.2009, 14:38 +0100 schrieb Colin Watson: > On Sun, Sep 06, 2009 at 02:29:03PM +0200, Felix Zielcke wrote: > > Currently grub-mkconfig uses chmod 444 on the newly generated grub.cfg > > Wouldn't it be better to use 400 now that we have plaintext password > > support? > > Or shou

Re: chmod of generated grub.cfg

2009-09-06 Thread Colin Watson
On Sun, Sep 06, 2009 at 02:29:03PM +0200, Felix Zielcke wrote: > Currently grub-mkconfig uses chmod 444 on the newly generated grub.cfg > Wouldn't it be better to use 400 now that we have plaintext password > support? > Or should we add support for a GRUB_CHMOD variable so users can override > this

chmod of generated grub.cfg

2009-09-06 Thread Felix Zielcke
Currently grub-mkconfig uses chmod 444 on the newly generated grub.cfg Wouldn't it be better to use 400 now that we have plaintext password support? Or should we add support for a GRUB_CHMOD variable so users can override this setting as they please? Else I'd need to add a /etc/grub.d/999_chmod fi

Re: [PATCH] Change clean rules to properly remove files

2009-09-06 Thread Yves Blusseau
Le 2 sept. 09 à 18:48, Yves Blusseau a écrit : ChangeLog: 2009-09-02 Yves Blusseau Change clean rules to properly remove files * genmk.rb: add new clean rules * Makefile.in (clean): add the new targets (mostlyclean): likewise --- Makefile.in |4 ++-- genmk.rb| 55