Re: [PATCH] bless command

>> Wouldn't it be reasonable to bless both the file and the directory? > > Hi, > > Actually, I think the correct handling is to first bless a boot > directory (storing the directory id in header), then bless a boot file > (add +tbxi attribute), that's why the bless command in OSX needs needs > both

Re: [PATCH] bless command

On Sat, Aug 29, 2009 at 6:59 AM, Michal Suchanek wrote: > Hello > > the bless command is nice. > > 2009/4/19 Vladimir Serbinenko : >> Thank you for the testing and info. >>> >>> Redundant info - >>> I checked the OSX bless utility, it requires both folder and file, or it >>> will not agree to bless

Re: [PATH] grub-mkrelpath

On Sat, Aug 29, 2009 at 1:55 AM, Robert Millan wrote: > On Fri, Aug 28, 2009 at 07:58:39PM +0200, Felix Zielcke wrote: >> +#else /* ! HAVE_REALPATH */ >> +  grub_util_warn ("grub-mkrelpath might not work on your OS correctly."); >> +  /* make relative path absolute.  */ >> +  if (*path != '/') >> +

Re: zfsinfo branch

Sorry -- this was meant as a private message :). Ignore. --S Quoting Seth Goldberg, who wrote the following on Fri, 28 Aug 2009: Hi, Any chance I could convince you to merge that in with the nested partition and sunpc changes + the current trunk? It would definitely make it easier for

zfsinfo branch

Hi, Any chance I could convince you to merge that in with the nested partition and sunpc changes + the current trunk? It would definitely make it easier for me to merge the changes into my workspace... Thanks, --S ___ Grub-devel mailing list

Re: [PATH] grub-mkrelpath

On Fri, Aug 28, 2009 at 07:58:39PM +0200, Felix Zielcke wrote: > +#else /* ! HAVE_REALPATH */ > + grub_util_warn ("grub-mkrelpath might not work on your OS correctly."); > + /* make relative path absolute. */ > + if (*path != '/') > +{ > + len = 1024; > + buf2 = xmalloc (len); > +

Re: [PATCH] bless command

Hello the bless command is nice. 2009/4/19 Vladimir Serbinenko : > Thank you for the testing and info. >> >> Redundant info - >> I checked the OSX bless utility, it requires both folder and file, or it >> will not agree to bless the file. > > I'm nearly sure now that folder blessing (+tbxi attrib

Re: [GITGRUB] Support new object format for powerpc-ieee1275

On Fri, Aug 28, 2009 at 9:19 PM, Bean wrote: > Hi, > > Update: fix a few endian and relocation issue, I can now build all > i386/x64_64/powerpc targets from x86/powerpc OSX Tiger/Leopard. > > Note: when building on OSX, I recommend adding configure option > --disable-grub-fstest --disable-grub-emu

Re: [PATCH] reset USB controller

On Thu, Jul 16, 2009 at 5:56 PM, Robert Millan wrote: > On Wed, Jul 15, 2009 at 10:51:55PM +0200, Vladimir 'phcoder' Serbinenko wrote: >> Hello, some BIOSes don't conform semaphore specification about handing >> over the control on UHCI and/or EHCI controller. Most OS cope with it >> by taking owne

[RFC] -Os and -O2

Hello. Current GRUB2 optimisation strategy is to compile whole grub with -Os but only kernel, bus modules, disk modules, partmap and fs modules have size concerns. Graphical modules have speed concerns. So I propose following optimisation strategy: -Os for kernel, bus modules, disk modules, partmap

[PATCH] Remove has_paritions

-- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git diff --git a/Changelog.phcoder b/Changelog.phcoder new file mode 100644 index 000..978faf6 --- /dev/null +++ b/Changelog.phcoder @@ -0,0 +1,10 @@ +2009-07-26 Vladimir Serbinenko + +

Re: [PATCH] zero-fill entry before asking BIOS for memory map

>> +     /* clear the request area, buggy BIOSes may not clear it */ >> +     xor     %edi, %edi >> +     movl    %edi, 4(%eax) >> +     movl    %edi, 8(%eax) >> +     movl    %edi, 12(%eax) >> +     movl    %edi, 16(%eax) >> +     movl    %edi, 20(%eax) > > This effectively hardcodes sizeof(entry)

Re: [GITGRUB] Support new object format for powerpc-ieee1275

Hi, Update: fix a few endian and relocation issue, I can now build all i386/x64_64/powerpc targets from x86/powerpc OSX Tiger/Leopard. Note: when building on OSX, I recommend adding configure option --disable-grub-fstest --disable-grub-emu --disable-mkfont. grub-fstest can be built successfully,

Re: [PATCH] Inline utf16_to_utf8

2009-08-28 Vladimir Serbinenko * kern/misc.c (grub_utf16_to_utf8): Move from here ... * include/grub/charset.h (grub_utf16_to_utf8): ... to here. Inlined. All users updated. * include/grub/misc.h (grub_utf16_to_utf8): Removed. On Fri, Aug 28, 2009 at 9:16 PM, Vladi

[PATCH] Inline utf16_to_utf8

Needs my usb patch first. Size of cores with filesystems needing UTF-16 doesn't change much (difficult to say if it increases or decreases ecause compression performance varies with other modules (bisdisk vs ata, ...) and even with module order) and decreases th size of core by about 150 bytes if U

[PATCH] Move grub_usb_get_string out of usb.mod

usb.mod may be size-critical (if booting from usb) but usbtest.mod isn't. grub_usb_get_string is in usb.mod but used only in usbtest.mod. Furthermore it's the only potentially size-critical function except filesystems which uses grub_utf16_to_utf8. Making it non-size critical would allow to inline

Re: [PATH] grub-mkrelpath

Am Freitag, den 28.08.2009, 18:28 +0200 schrieb Robert Millan: > On Fri, Aug 28, 2009 at 02:53:12PM +0200, Felix Zielcke wrote: > > + if (stat (buf, &st) < 0) > > + grub_util_error ("can not stat %s", buf); > > We should give a reason. E.g: > > grub_util_error ("can not stat %s: %s", p,

Re: [PATCH] UTF-8 to UTF-16 transformation

>> I'm ok with renaming but whether a conversion goes to charset.mod is >> perhaps to be decided on case-by-case basis- >> > The conversion functions in kern/misc.c could eventually move there as >> > well, >> > once UTF-8 support becomes optional in the kernel. >> utf16_to_utf8 can be moved now o

Re: [PATCH] Simplify Apple CC support by adding LOCAL(x) when needed

Ping? On Sat, Aug 22, 2009 at 9:44 PM, Vladimir 'phcoder' Serbinenko wrote: > -- > Regards > Vladimir 'phcoder' Serbinenko > > Personal git repository: http://repo.or.cz/w/grub2/phcoder.git > -- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.g

Re: [PATCH] fix an infinite loop with a corrupted pc partition table

Ping? On Sun, Aug 23, 2009 at 5:40 PM, Vladimir 'phcoder' Serbinenko wrote: > On Tue, Jul 28, 2009 at 7:55 PM, Robert Millan wrote: >> On Sun, Jul 26, 2009 at 12:58:59AM +0200, Vladimir 'phcoder' Serbinenko >> wrote: >>> +      /* This is our loop-detection algorithm. It works the following way:

Re: Report: compil error on OSX for target=i386

> What about following compromise: > diff --git a/loader/i386/linux.c b/loader/i386/linux.c > index 4144384..1380eb8 100644 > --- a/loader/i386/linux.c > +++ b/loader/i386/linux.c > @@ -543,7 +543,8 @@ grub_linux_boot (void) >   asm volatile ("lgdt %0" : : "m" (gdt_desc)); > >   /* Enter Linux.  */

Re: Interrupt testing

On Sun, Mar 8, 2009 at 2:32 PM, Robert Millan wrote: > On Sat, Mar 07, 2009 at 04:43:01PM +0100, phcoder wrote: >> Hello. Here is a trivial patch for testing which interrupts are and >> which aren't handled by BIOS. Can be used as a simple but not reliable >> test for boot viruses > > Would it be f

Re: [PATCH] Bitmap scale support.

On Wed, Aug 26, 2009 at 2:40 AM, Robert Millan wrote: > On Mon, Aug 24, 2009 at 10:48:26PM +0200, Vladimir 'phcoder' Serbinenko wrote: >> +  int dy; >> +  for (dy = 0; dy < dh; dy++) >> +    { >> +      int dx; >> +      for (dx = 0; dx < dw; dx++) >> +        { >> +          grub_uint8_t *dptr; >>

[RFC] FAT signature

Hello. Currently one on FAT* check is a check for string FAT* at specific location. This check was added to avoid detecting some recovery partitions as fat even if they are really FAT and previously you could access them from GRUB. I find this approach incorrect since even if data on this partition

Re: [RFT, PATCH] Fix file->offset handling

On Mon, Aug 17, 2009 at 3:34 PM, Robert Millan wrote: > On Fri, Aug 14, 2009 at 07:48:40PM +0200, Vladimir 'phcoder' Serbinenko wrote: >> diff --git a/kern/file.c b/kern/file.c >> index 9b56b88..85092b8 100644 >> --- a/kern/file.c >> +++ b/kern/file.c >> @@ -112,6 +112,12 @@ grub_file_read (grub_fi

Re: [PATH] grub-mkrelpath

On Fri, Aug 28, 2009 at 02:53:12PM +0200, Felix Zielcke wrote: > + if (stat (buf, &st) < 0) > + grub_util_error ("can not stat %s", buf); We should give a reason. E.g: grub_util_error ("can not stat %s: %s", p, strerror (errno)); Also, I believe some of the comments in the old shell

Re: [PATCH] UTF-8 to UTF-16 transformation

On Thu, Aug 27, 2009 at 11:31:28PM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Wed, Aug 26, 2009 at 2:31 AM, Robert Millan wrote: > > On Mon, Aug 24, 2009 at 09:23:22PM +0200, Vladimir 'phcoder' Serbinenko > > wrote: > > > >> 2009-08-24  Vladimir Serbinenko   > >> > >>       UTF-8 to UTF-16 t

Re: [PATCH] Remove framework for external modules

On Fri, Aug 28, 2009 at 04:04:39PM +0200, Vladimir 'phcoder' Serbinenko wrote: > >> (footnote) We are applying GPL license to these modules, but they'll > >> never end up in the grub tree. Our requirements are too weird. You > >> won't want to merge this code, believe me. > > > > I understand.  Goo

[PATCH] Double buffering support

-- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git diff --git a/ChangeLog b/ChangeLog index 9d98cdf..f34b4d6 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,35 @@ +2009-08-24 Colin D Bennett +2009-08-24 Vladimir Serbinenko + + Dou

Re: [PATCH] change --enable-efiemu to --enable-efiemu64

On Sat, Jul 18, 2009 at 11:59 PM, Pavel Roskin wrote: > On Sat, 2009-07-18 at 20:32 +0200, Robert Millan wrote: >> On Fri, Jul 17, 2009 at 06:15:57PM +0200, Vladimir 'phcoder' Serbinenko >> wrote: >> > Like previously discussed efiemu32 can always be compiled hence this patch >> >> This does a few

Re: [PATCH] Remove framework for external modules

On Fri, Aug 28, 2009 at 2:48 PM, Robert Millan wrote: > On Wed, Aug 26, 2009 at 09:20:58PM -0700, Joe Auricchio wrote: >> On Tue, Aug 25, 2009 at 14:13, Robert Millan wrote: >> > >> > My bad... >> > >> > When I proposed adding a framework for building GRUB modules externally, I >> > was expecting i

[PATCH] Fallback to efiemu32.o if efiemu64.o isn't available

-- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git diff --git a/ChangeLog b/ChangeLog index 1858a9c..b279f2f 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,18 @@ +2009-07-17 Vladimir Serbinenko + + Fall back to efiemu32.o if efiemu6

Re: [PATCH] bless command

On Sun, Jun 21, 2009 at 1:05 PM, Robert Millan wrote: > On Fri, Jun 19, 2009 at 01:53:18PM +0200, Vladimir 'phcoder' Serbinenko wrote: >> On Fri, Jun 19, 2009 at 8:08 AM, Peter Cros wrote: >> >> > Hi again, >> > >> > Could the hfspbless patch be updated and hopefully committted to provide >> > the

Re: [PATCH] Remove framework for external modules

>> (footnote) We are applying GPL license to these modules, but they'll >> never end up in the grub tree. Our requirements are too weird. You >> won't want to merge this code, believe me. > > I understand.  Good luck with it! This case is exactly something external module build want to prevent. If

Re: [GITGRUB] FB driver for OLPC

On Fri, Aug 28, 2009 at 8:54 PM, Robert Millan wrote: > On Fri, Aug 28, 2009 at 01:57:59AM +0800, Bean wrote: >> Hi, >> >> Update: >> >> Extends the driver to support powerpc-ieee1275. It's quite similar to >> i386-ieee1275, but it uses 8-bit indexed color instead of 16-bit >> color. > > Hi, > > Yo

Re: [PATCH] Optimised 1bit blitters

comitted On Tue, Aug 25, 2009 at 4:41 PM, Vladimir 'phcoder' Serbinenko wrote: > On Tue, Aug 25, 2009 at 4:06 PM, Michal Suchanek wrote: >> 2009/8/23 Robert Millan : >>> On Fri, Aug 21, 2009 at 05:33:30PM +0200, Vladimir 'phcoder' Serbinenko >>> wrote: +  for (j = 0; j < height; j++) +

Re: [PATCH] Fix hfsplus.

Le 22 août 09 à 21:43, Vladimir 'phcoder' Serbinenko a écrit : Hello. In multiple places hfsplus aborts if read_file returns 0. But in this case grub_error isn't set so the errors aren't propagated. Here is fix. Compiled and checked on OSX: great job, no more grub crash in case of AppleRaid

Re: [PATCH] Compiler warning in grub_cmdline_get

On Fri, Aug 28, 2009 at 02:48:45PM +0200, Robert Millan wrote: > On Thu, Aug 27, 2009 at 12:55:18AM +0100, Colin Watson wrote: > > 2009-08-27 Colin Watson > > > > * normal/cmdline.c (grub_cmdline_get): Supply a format string as > > the first argument to grub_printf. > > Thanks Colin.

Re: [PATCH] UTF-8 to UTF-16 transformation

On Thu, Aug 27, 2009 at 11:31 PM, Vladimir 'phcoder' Serbinenko wrote: > On Wed, Aug 26, 2009 at 2:31 AM, Robert Millan wrote: >> On Mon, Aug 24, 2009 at 09:23:22PM +0200, Vladimir 'phcoder' Serbinenko >> wrote: >> >>> 2009-08-24  Vladimir Serbinenko   >>> >>>       UTF-8 to UTF-16 transformation.

Re: [PATCH] Detect key modifier status in 'sleep --interruptible'

On Fri, Aug 28, 2009 at 02:44:15PM +0200, Robert Millan wrote: > On Wed, Aug 26, 2009 at 09:26:06PM +0100, Colin Watson wrote: > > If GRUB_HIDDEN_TIMEOUT is set to a non-zero value, I would use sleep > > rather than keystatus, I think. (At least, if I decided I wanted to > > support that configurat

Re: [PATCH] Split big and little endian BeFS and AtheFS

Comitted On Mon, Aug 24, 2009 at 1:09 AM, Robert Millan wrote: > On Sun, Aug 23, 2009 at 01:04:30PM +0200, Vladimir 'phcoder' Serbinenko wrote: >> On Sun, Aug 23, 2009 at 12:40 PM, Robert Millan wrote: >> > On Thu, Aug 20, 2009 at 06:16:24PM -0400, Pavel Roskin wrote: >> >> I don't think we should

Re: [GITGRUB] FB driver for OLPC

On Fri, Aug 28, 2009 at 01:57:59AM +0800, Bean wrote: > Hi, > > Update: > > Extends the driver to support powerpc-ieee1275. It's quite similar to > i386-ieee1275, but it uses 8-bit indexed color instead of 16-bit > color. Hi, You forgot to attach it? -- Robert Millan The DRM opt-in fallacy

Re: [Fwd: Bug#543950: grub-pc(GNU/kFreeBSD): wrong root fs type]

On Thu, Aug 27, 2009 at 07:33:47PM +0200, Felix Zielcke wrote: > Seems like the ufs split breaks seting the root for FreeBSD: I have a pending rewrite of 10_freebsd.in (there was a thread about this), which is waiting on a portable "make path relative to its root" method. -- Robert Millan The

[PATH] grub-mkrelpath

Here's a patch which implements grub-mkrelpath based on my make_system_path_relative_to_its_root patch to fix the problem with grub-setup and blocklists, if the path to core.img given to grub-setup isn't already relative to the root. I wasn't sure if I should place the function now in util/grub-mkr

Re: [RFC] Don't pass filename in multiboot command line

On Thu, Aug 27, 2009 at 12:55:21PM +0200, Michal Suchanek wrote: > 2009/8/27 Seth Goldberg : > > Hi, > > > >  Any chance of having a 'multiboot1' module that can continue to pass the > > multiboot filename as arg0 ? > > > > >From the previous discussion of this feature I guess you can pass it > as

Re: [PATCH] Compiler warning in grub_cmdline_get

On Thu, Aug 27, 2009 at 12:55:18AM +0100, Colin Watson wrote: > I don't think this can actually cause a real problem, but it's a > compiler warning since it might (e.g. if prompt ever contained "%"). > > /home/cjwatson/src/ubuntu/grub2/tmp/grub2-1.96+20090826/normal/cmdline.c: > In function ‘gr

Re: [PATCH] Remove framework for external modules

On Wed, Aug 26, 2009 at 09:20:58PM -0700, Joe Auricchio wrote: > On Tue, Aug 25, 2009 at 14:13, Robert Millan wrote: > > > > My bad... > > > > When I proposed adding a framework for building GRUB modules externally, I > > was expecting it would end up being used.  I had grub-extras in mind. > > > >

Re: [PATCH] Detect key modifier status in 'sleep --interruptible'

On Wed, Aug 26, 2009 at 09:26:06PM +0100, Colin Watson wrote: > > > > I'm still not convinced that we want the sleep bits. They seem too ad-hoc, > > and I'd like to hear what others think first. > > > > But if I understood correctly, you plan on using keystatus command only? > > If GRUB_HIDDEN_

Re: Re[2]: 'password' command in GRUB 2?

On Wed, Aug 26, 2009 at 07:32:37PM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Wed, Aug 26, 2009 at 1:51 PM, Michal Suchanek wrote: > > 2009/8/25 Vladimir 'phcoder' Serbinenko : > >>> However, that CVE is about grub leaving its passwords in memory. > >>> Wiping memory used by grub should be fa

Re: [PATCH] Detect endian in cpio fs

On Fri, Aug 28, 2009 at 2:20 PM, Bean wrote: > On Fri, Aug 28, 2009 at 8:03 PM, Vladimir 'phcoder' > Serbinenko wrote: >> On Thu, Aug 27, 2009 at 10:27 AM, Bean wrote: >>> Hi, >>> >>> This patch allows to access big/little endian cpio archive from >>> big/little endian machine. >> Quick glance show

[Bug Report] loadenv module

Hi, i have compiled the current version of grub2 under OSX. I have an error when using the loadenv module: I don't have any grub.cfg file. When i was at the prompt i do a save_env timeout and grub return me an "out of partition" error. I have created a newly grubenv with grub-editenv comman

Re: [PATCH] Detect endian in cpio fs

On Fri, Aug 28, 2009 at 8:03 PM, Vladimir 'phcoder' Serbinenko wrote: > On Thu, Aug 27, 2009 at 10:27 AM, Bean wrote: >> Hi, >> >> This patch allows to access big/little endian cpio archive from >> big/little endian machine. > Quick glance showed that you use swap_bytes. Could you use > grub_*_to_c

Re: [PATCH] Detect endian in cpio fs

On Thu, Aug 27, 2009 at 10:27 AM, Bean wrote: > Hi, > > This patch allows to access big/little endian cpio archive from > big/little endian machine. Quick glance showed that you use swap_bytes. Could you use grub_*_to_cpu* instead? This would simplify the future maintainability if someone decides t

Re: pc.mod -> part_msdos.mod (etc)

As was discussed in http://www.mail-archive.com/grub-devel@gnu.org/msg06210.html I intend to prefix all partmap modules with "part_" and rename "pc" to "part_msdos". If anyone has an objection, please say it now. Is it normal that i see gpt when i do a lsmod instead of part_gpt ? Sorry i m

Re: pc.mod -> part_msdos.mod (etc)

As was discussed in http://www.mail-archive.com/grub-devel@gnu.org/msg06210.html I intend to prefix all partmap modules with "part_" and rename "pc" to "part_msdos". If anyone has an objection, please say it now. Is it normal that i see gpt when i do a lsmod instead of part_gpt ? Regards, Yves