Re: [PATCH] Clear out gfxterm's virtual text_buffer - fixes junk at end of lines

2009-08-24 Thread Joe Auricchio
On Sun, Aug 23, 2009 at 06:07, Robert Millan wrote: > On Wed, Jul 22, 2009 at 10:42:54AM -0700, Joe Auricchio wrote: >>> >>> So perhaps this can be solved simpler by replacing grub_malloc with >>> grub_zalloc ? >> >> I saw the zalloc commit and thought the same thing! :D I'll test it. But >> fg_col

Re: Re[2]: 'password' command in GRUB 2?

2009-08-24 Thread Vladimir 'phcoder' Serbinenko
On Tue, Aug 25, 2009 at 12:36 AM, Robert Millan wrote: > > I had a look at grub_cmdline_get(), and it would need some restructuring in > order not to enforce static allocation.  I admit it doesn't make sense to > put this patch on hold because of it. > > Vladimir, please go ahead with your latest p

Re: [PATCH] Large disk support for XFS

2009-08-24 Thread Vladimir 'phcoder' Serbinenko
On Tue, Aug 25, 2009 at 12:30 AM, Robert Millan wrote: > On Mon, Aug 24, 2009 at 09:14:48PM +0200, Vladimir 'phcoder' Serbinenko wrote: >> On Sun, Aug 16, 2009 at 9:46 PM, Bean wrote: >> > Hi, >> > >> > This patch fixes a few size limits of xfs fs. >> Ping > > Isn't this already in SVN ? > No. > --

Re: [PATCH] Detect key modifier status in 'sleep --interruptible'

2009-08-24 Thread Colin Watson
On Tue, Aug 25, 2009 at 12:41:20AM +0200, Robert Millan wrote: > On Mon, Aug 24, 2009 at 11:04:19PM +0100, Colin Watson wrote: > > +/* See http://heim.ifi.uio.no/~stanisls/helppc/bios_data_area.html for a > > + description of the BIOS Data Area layout. */ > > +struct grub_machine_bios_data_area

Re: [PATCH] Detect key modifier status in 'sleep --interruptible'

2009-08-24 Thread Robert Millan
On Mon, Aug 24, 2009 at 11:04:19PM +0100, Colin Watson wrote: > +/* See http://heim.ifi.uio.no/~stanisls/helppc/bios_data_area.html for a > + description of the BIOS Data Area layout. */ > +struct grub_machine_bios_data_area > +{ > + grub_uint8_t unused1[0x17]; > + grub_uint8_t keyboard_flag_l

Re: Re[2]: 'password' command in GRUB 2?

2009-08-24 Thread Robert Millan
I had a look at grub_cmdline_get(), and it would need some restructuring in order not to enforce static allocation. I admit it doesn't make sense to put this patch on hold because of it. Vladimir, please go ahead with your latest patch. I will try to change grub_cmdline_get() semantics later if

Re: [PATCH] Large disk support for XFS

2009-08-24 Thread Robert Millan
On Mon, Aug 24, 2009 at 09:14:48PM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Sun, Aug 16, 2009 at 9:46 PM, Bean wrote: > > Hi, > > > > This patch fixes a few size limits of xfs fs. > Ping Isn't this already in SVN ? -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We

Re: [PATCH] Detect key modifier status in 'sleep --interruptible'

2009-08-24 Thread Colin Watson
On Mon, Aug 24, 2009 at 02:23:52PM +0200, Robert Millan wrote: > I don't have time to test it, but what we want is roughly something like > this. If you would please test and confirm it's working the way you expected, > it can be committed. OK, here's a cleanup that (a) fixes some compilation err

[PATCH] Bitmap scale support.

2009-08-24 Thread Vladimir 'phcoder' Serbinenko
-- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git diff --git a/ChangeLog b/ChangeLog index b3289c7..5d32e90 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,4 +1,21 @@ 2009-08-24 Colin D Bennett + + Bitmap scaling support. + + * co

Re: [PATCH] import multiboot1 specification in grub trunk

2009-08-24 Thread Isaac Dupree
Vladimir 'phcoder' Serbinenko wrote: On Mon, Aug 24, 2009 at 8:38 PM, Isaac Dupree wrote: Vladimir 'phcoder' Serbinenko wrote: 8) COPYING contains GPLv2. fdl.texi isn't imported. I'm not a lawyer but following is my analysis AFAICT only example kernel is under GPL (v2 to be precise) the rest i

[PATCH] Support double buffering.

2009-08-24 Thread Vladimir 'phcoder' Serbinenko
-- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git diff --git a/ChangeLog b/ChangeLog index 5701f9b..6f03a92 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,35 @@ +2009-08-24 Colin D Bennett +2009-08-24 Vladimir Serbinenko + + Dou

Re: [PATCH] save around 100 bytes on core.img by inlining small misc.c functions

2009-08-24 Thread Vladimir 'phcoder' Serbinenko
On Wed, Aug 19, 2009 at 5:11 PM, Robert Millan wrote: > On Mon, Aug 17, 2009 at 03:54:06PM +0200, Vladimir 'phcoder' Serbinenko wrote: >> On Mon, Aug 17, 2009 at 3:43 PM, Robert Millan wrote: >> > On Sat, Aug 15, 2009 at 04:47:32PM +0200, Vladimir 'phcoder' Serbinenko >> > wrote: >> >> +static inl

Re: [PATCH] Replace ad-hoc format in efiemu (for variables) and XNU (for device tree) by environment variables

2009-08-24 Thread Vladimir 'phcoder' Serbinenko
Splitted. Another split part is in thread UTF-8 to UTF-16 On Sun, Aug 23, 2009 at 1:11 PM, Vladimir 'phcoder' Serbinenko wrote: > On Sun, Aug 23, 2009 at 12:57 PM, Robert Millan wrote: >> On Sat, Aug 22, 2009 at 04:33:13PM +0200, Vladimir 'phcoder' Serbinenko >> wrote: >>> [...] >>> + >>> +pkglib

Re: [PATCH] UTF-8 to UTF-16 transformation

2009-08-24 Thread Vladimir 'phcoder' Serbinenko
On Mon, Aug 24, 2009 at 9:22 PM, Vladimir 'phcoder' Serbinenko wrote: > Splitted from my newtree patch > > -- > Regards > Vladimir 'phcoder' Serbinenko > > Personal git repository: http://repo.or.cz/w/grub2/phcoder.git > -- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://

[PATCH] UTF-8 to UTF-16 transformation

2009-08-24 Thread Vladimir 'phcoder' Serbinenko
Splitted from my newtree patch -- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Large disk support for XFS

2009-08-24 Thread Vladimir 'phcoder' Serbinenko
On Sun, Aug 16, 2009 at 9:46 PM, Bean wrote: > Hi, > > This patch fixes a few size limits of xfs fs. Ping > > -- > Bean > > gitgrub home: http://github.com/grub/grub/ > my fork page: http://github.com/bean123/grub/ > > ___ > Grub-devel mailing list > Grub

Re: [PATCH] Eliminate script line length limit

2009-08-24 Thread Vladimir 'phcoder' Serbinenko
On Mon, Aug 24, 2009 at 5:46 PM, Robert Millan wrote: > On Mon, Aug 24, 2009 at 04:39:01PM +0200, Vladimir 'phcoder' Serbinenko wrote: >> +          but extends automaticlly when needed.  */ > > Typo :-) > > Other than this, it looks fine.  Thanks! > Fixed and comitted > -- > Robert Millan > >  The

[PATCH] Hotkey support

2009-08-24 Thread Vladimir 'phcoder' Serbinenko
This patch allows to boot entry with a single keypress -- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git diff --git a/ChangeLog b/ChangeLog index 1efb882..afb1bec 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,14 @@ 2009-08-24 Vladimir S

Re: [PATCH] import multiboot1 specification in grub trunk

2009-08-24 Thread Felix Zielcke
Am Montag, den 24.08.2009, 20:52 +0200 schrieb Vladimir 'phcoder' Serbinenko: > > If we have any, then it doesn't fall within the Debian Free > > Software Guidelines and Debian et al. will be annoyed and not distribute it > > as much. > Actually this doesn't matter. GRUB is GNU project and invarian

Re: [PATCH] import multiboot1 specification in grub trunk

2009-08-24 Thread Vladimir 'phcoder' Serbinenko
> If we have any, then it doesn't fall within the Debian Free > Software Guidelines and Debian et al. will be annoyed and not distribute it > as much. Actually this doesn't matter. GRUB is GNU project and invariant sections and cover texts are completely ok. Additionally it's a coder manual so it's

Re: [PATCH] import multiboot1 specification in grub trunk

2009-08-24 Thread Vladimir 'phcoder' Serbinenko
On Mon, Aug 24, 2009 at 8:38 PM, Isaac Dupree wrote: > Vladimir 'phcoder' Serbinenko wrote: >>> >>> 8) COPYING contains GPLv2. fdl.texi isn't imported. >> >> I'm not a lawyer but following is my analysis >> AFAICT only example kernel is under GPL (v2 to be precise) the rest is >> either custom lice

Re: [PATCH] import multiboot1 specification in grub trunk

2009-08-24 Thread Isaac Dupree
Vladimir 'phcoder' Serbinenko wrote: 8) COPYING contains GPLv2. fdl.texi isn't imported. I'm not a lawyer but following is my analysis AFAICT only example kernel is under GPL (v2 to be precise) the rest is either custom license, unclaimed copyright or non-copyrightable. IMO multiboot specificati

Re: [PATCH] Improve handling of "keep" in gfxpayload

2009-08-24 Thread Vladimir 'phcoder' Serbinenko
On Mon, Aug 24, 2009 at 6:38 PM, Colin Watson wrote: > On Mon, Aug 24, 2009 at 04:26:09PM +0200, Vladimir 'phcoder' Serbinenko wrote: >> On Mon, Aug 10, 2009 at 6:41 PM, Colin Watson wrote: >> > On Mon, Aug 10, 2009 at 06:27:04PM +0200, Vladimir 'phcoder' Serbinenko >> > wrote: >> >> Framebuffer c

Re: [PATCH] Detect key modifier status in 'sleep --interruptible'

2009-08-24 Thread Colin Watson
On Mon, Aug 24, 2009 at 04:28:00PM +0200, Robert Millan wrote: > On Mon, Aug 24, 2009 at 02:27:07PM +0100, Colin Watson wrote: > > Perhaps we can apply the following patch first, then? I was following > > existing style, so the other code should be updated too. > > Ah, sorry I didn't know that. B

Re: [PATCH] Detect key modifier status in 'sleep --interruptible'

2009-08-24 Thread Colin Watson
On Mon, Aug 24, 2009 at 05:23:00PM +0100, Colin Watson wrote: > On Mon, Aug 24, 2009 at 04:28:00PM +0200, Robert Millan wrote: > > Please go ahead (I assume you've tested it, at least with QEMU's USB > > keyboard). > > Hmm. Does GRUB actually work with that right now? Even without my patch > appli

Re: [GITGRUB] FB driver for EFI

2009-08-24 Thread Bean
Hi, BTW, with this latest driver, it's possible to start Colin's graphics menu on EFI. I've re-packaged the configure files for EFI and post it at: http://grub4dos.sourceforge.net/gfxmenu.zip On Tue, Aug 25, 2009 at 12:28 AM, Bean wrote: > Hi, > > Update: Add double buffer support for efi fb. >

Re: [PATCH] Improve handling of "keep" in gfxpayload

2009-08-24 Thread Colin Watson
On Mon, Aug 24, 2009 at 04:26:09PM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Mon, Aug 10, 2009 at 6:41 PM, Colin Watson wrote: > > On Mon, Aug 10, 2009 at 06:27:04PM +0200, Vladimir 'phcoder' Serbinenko > > wrote: > >> Framebuffer console works just fine with no KMS if video mode is > >> al

Re: [GITGRUB] FB driver for EFI

2009-08-24 Thread Bean
Hi, Update: Add double buffer support for efi fb. -- Bean gitgrub home: http://github.com/grub/grub/ my fork page: http://github.com/bean123/grub/ ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Detect key modifier status in 'sleep --interruptible'

2009-08-24 Thread Colin Watson
On Mon, Aug 24, 2009 at 04:28:00PM +0200, Robert Millan wrote: > Please go ahead (I assume you've tested it, at least with QEMU's USB > keyboard). Hmm. Does GRUB actually work with that right now? Even without my patch applied, this just gives me a prompt I can't type at: ./grub-mkrescue --modu

Re: [PATCH] Eliminate script line length limit

2009-08-24 Thread Robert Millan
On Mon, Aug 24, 2009 at 04:39:01PM +0200, Vladimir 'phcoder' Serbinenko wrote: > + but extends automaticlly when needed. */ Typo :-) Other than this, it looks fine. Thanks! -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may a

Re: [PATCH] Eliminate script line length limit

2009-08-24 Thread Vladimir 'phcoder' Serbinenko
On Sun, Aug 23, 2009 at 3:20 PM, Robert Millan wrote: > On Sat, Aug 22, 2009 at 04:30:08PM +0200, Vladimir 'phcoder' Serbinenko wrote: >> Making GNU GRUB more GNU ;) > > Good!  But please could you use NULL for pointers?  :-) > > Also, remember to include a ChangeLog entry. > > -- > Robert Millan >

Re: [PATCH] Detect key modifier status in 'sleep --interruptible'

2009-08-24 Thread Robert Millan
On Mon, Aug 24, 2009 at 02:58:50PM +0200, Michal Suchanek wrote: > 2009/8/24 Robert Millan : > > On Mon, Aug 24, 2009 at 10:11:10AM +0100, Colin Watson wrote: > >> > But in at_keyboard it's definitely possible (check how we handle e.g. > >> > CTRL > >> > or SHIFT keys). > >> > >> No, that code onl

Re: [PATCH] Detect key modifier status in 'sleep --interruptible'

2009-08-24 Thread Robert Millan
On Mon, Aug 24, 2009 at 02:27:07PM +0100, Colin Watson wrote: > > Perhaps we can apply the following patch first, then? I was following > existing style, so the other code should be updated too. Ah, sorry I didn't know that. But thanks for fixing anyway :-) Please go ahead (I assume you've test

Re: [PATCH] Improve handling of "keep" in gfxpayload

2009-08-24 Thread Vladimir 'phcoder' Serbinenko
On Mon, Aug 10, 2009 at 6:41 PM, Colin Watson wrote: > On Mon, Aug 10, 2009 at 06:27:04PM +0200, Vladimir 'phcoder' Serbinenko wrote: >> Framebuffer console works just fine with no KMS if video mode is >> already set and video parameters passed. At least technically. > > Feel free to show me what I

Re: [PATCH] Detect key modifier status in 'sleep --interruptible'

2009-08-24 Thread Robert Millan
On Mon, Aug 24, 2009 at 01:57:26PM +0200, Robert Millan wrote: > On Mon, Aug 24, 2009 at 10:11:10AM +0100, Colin Watson wrote: > > > But in at_keyboard it's definitely possible (check how we handle e.g. CTRL > > > or SHIFT keys). > > > > No, that code only spots make scan codes arriving after GRUB

Re: [PATCH] Detect key modifier status in 'sleep --interruptible'

2009-08-24 Thread Colin Watson
On Mon, Aug 24, 2009 at 02:23:52PM +0200, Robert Millan wrote: > I ommitted the USB part of your patch, because I had some comments. Once > that's fixed it can be added as well: > > > +static int > > +grub_usb_keyboard_keystatus (void) > > +{ > > + unsigned char data[8]; > > Please use grub_uin

Re: [PATCH] BSD fixes (make OpenBSD work again)

2009-08-24 Thread Vladimir 'phcoder' Serbinenko
Committed. Now NetBSD32, NetBSD64, OpenBSD32 and OpenBSD64 are all bootable by SVN. On Sun, Aug 23, 2009 at 10:36 PM, Vladimir 'phcoder' Serbinenko wrote: > -- > Regards > Vladimir 'phcoder' Serbinenko > > Personal git repository: http://repo.or.cz/w/grub2/phcoder.git > -- Regards Vladimir 'ph

Re: [PATCH] Add --root=DEVICE parameter support when boot NetBSD.

2009-08-24 Thread Vladimir 'phcoder' Serbinenko
Committed as approved by Robert Millan for fast-track acception. On Sun, Aug 23, 2009 at 8:28 PM, Vladimir 'phcoder' Serbinenko wrote: > Currently grub2 tries to guess root device name in OS notation basing > on BIOS number. This fails in multiple cases. This patch lets user > specify root device.

Re: [PATCH] NetBSD64 support

2009-08-24 Thread Vladimir 'phcoder' Serbinenko
Committed as approved by Robert Millan for fast-track acception. On Sun, Aug 23, 2009 at 2:01 PM, Vladimir 'phcoder' Serbinenko wrote: > -- > Regards > Vladimir 'phcoder' Serbinenko > > Personal git repository: http://repo.or.cz/w/grub2/phcoder.git > -- Regards Vladimir 'phcoder' Serbinenko P

Re: [PATCH] Detect key modifier status in 'sleep --interruptible'

2009-08-24 Thread Colin Watson
On Mon, Aug 24, 2009 at 01:57:26PM +0200, Robert Millan wrote: > On Mon, Aug 24, 2009 at 10:11:10AM +0100, Colin Watson wrote: > > No, that code only spots make scan codes arriving after GRUB's terminal > > starts up. AFAICS it has no way to tell whether e.g. Shift was held down > > already when GR

Re: [PATCH] Detect key modifier status in 'sleep --interruptible'

2009-08-24 Thread Michal Suchanek
2009/8/24 Robert Millan : > On Mon, Aug 24, 2009 at 10:11:10AM +0100, Colin Watson wrote: >> > But in at_keyboard it's definitely possible (check how we handle e.g. CTRL >> > or SHIFT keys). >> >> No, that code only spots make scan codes arriving after GRUB's terminal >> starts up. AFAICS it has no

Re: [PATCH] Detect key modifier status in 'sleep --interruptible'

2009-08-24 Thread Robert Millan
On Mon, Aug 24, 2009 at 10:24:06AM +0100, Colin Watson wrote: > diff -Nur -x '*.orig' -x '*~' grub2-1.96+20090725/term/ieee1275/ofconsole.c > grub2-1.96+20090725.new/term/ieee1275/ofconsole.c > --- grub2-1.96+20090725/term/ieee1275/ofconsole.c 2009-06-10 > 22:04:23.0 +0100 > +++ grub2

Re: [PATCH] Support --no-smp and --no-acpi for NetBSD

2009-08-24 Thread Vladimir 'phcoder' Serbinenko
Committed as approved by Robert Millan for fast-track acception. On Sun, Aug 23, 2009 at 1:56 PM, Vladimir 'phcoder' Serbinenko wrote: > -- > Regards > Vladimir 'phcoder' Serbinenko > > Personal git repository: http://repo.or.cz/w/grub2/phcoder.git > -- Regards Vladimir 'phcoder' Serbinenko P

Re: [PATCH] Detect key modifier status in 'sleep --interruptible'

2009-08-24 Thread Vladimir 'phcoder' Serbinenko
On Mon, Aug 24, 2009 at 1:57 PM, Robert Millan wrote: > On Mon, Aug 24, 2009 at 10:11:10AM +0100, Colin Watson wrote: >> > But in at_keyboard it's definitely possible (check how we handle e.g. CTRL >> > or SHIFT keys). >> >> No, that code only spots make scan codes arriving after GRUB's terminal >>

Re: [PATCH] Detect key modifier status in 'sleep --interruptible'

2009-08-24 Thread Robert Millan
On Mon, Aug 24, 2009 at 02:23:52PM +0200, Robert Millan wrote: > Index: include/grub/i386/pc/memory.h > === > --- include/grub/i386/pc/memory.h (revision 2520) > +++ include/grub/i386/pc/memory.h (working copy) > @@ -78,6 +78,1

Re: pc.mod -> part_msdos.mod (etc)

2009-08-24 Thread Robert Millan
On Mon, Aug 24, 2009 at 02:07:45AM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Mon, Aug 24, 2009 at 1:43 AM, Vladimir 'phcoder' > Serbinenko wrote: > > On Mon, Aug 24, 2009 at 12:59 AM, Robert Millan wrote: > >> On Sun, Aug 23, 2009 at 11:05:47PM +0200, Vladimir 'phcoder' Serbinenko > >> wrot

Re: [PATCH] Detect key modifier status in 'sleep --interruptible'

2009-08-24 Thread Robert Millan
On Mon, Aug 24, 2009 at 10:24:06AM +0100, Colin Watson wrote: > On Mon, Aug 24, 2009 at 12:46:29AM +0200, Vladimir 'phcoder' Serbinenko wrote: > > [Could you please preserve attributions in your replies? I've reinserted > one here so that it's clear who wrote what.] > > > Colin Watson wrote: > >

Re: [PATCH] import multiboot1 specification in grub trunk

2009-08-24 Thread Vladimir 'phcoder' Serbinenko
> 8) COPYING contains GPLv2. fdl.texi isn't imported. I'm not a lawyer but following is my analysis AFAICT only example kernel is under GPL (v2 to be precise) the rest is either custom license, unclaimed copyright or non-copyrightable. IMO multiboot specification should be FDL with cover text "Mult

Re: [PATCH] Detect key modifier status in 'sleep --interruptible'

2009-08-24 Thread Robert Millan
On Mon, Aug 24, 2009 at 10:11:10AM +0100, Colin Watson wrote: > > But in at_keyboard it's definitely possible (check how we handle e.g. CTRL > > or SHIFT keys). > > No, that code only spots make scan codes arriving after GRUB's terminal > starts up. AFAICS it has no way to tell whether e.g. Shift

Re: [PATCH] import multiboot1 specification in grub trunk

2009-08-24 Thread Vladimir 'phcoder' Serbinenko
On Sun, Aug 23, 2009 at 12:39 PM, Robert Millan wrote: > On Thu, Aug 20, 2009 at 10:56:09PM +0200, Vladimir 'phcoder' Serbinenko wrote: >> On Thu, Aug 20, 2009 at 6:28 PM, Robert Millan wrote: >> > On Wed, Aug 19, 2009 at 05:38:58PM +0200, Vladimir 'phcoder' Serbinenko >> > wrote: >> >> On Wed, Au

Re: [PATCH] Detect key modifier status in 'sleep --interruptible'

2009-08-24 Thread Colin Watson
On Mon, Aug 24, 2009 at 12:46:29AM +0200, Vladimir 'phcoder' Serbinenko wrote: [Could you please preserve attributions in your replies? I've reinserted one here so that it's clear who wrote what.] > Colin Watson wrote: > > The values I picked for the constants were convenient for i386-pc, but > >

Re: [PATCH] Detect key modifier status in 'sleep --interruptible'

2009-08-24 Thread Colin Watson
On Mon, Aug 24, 2009 at 12:27:45AM +0200, Robert Millan wrote: > On Wed, Aug 12, 2009 at 04:35:21PM +0100, Colin Watson wrote: > > +static int > > +grub_at_keyboard_keystatus (void) > > +{ > > + /* FIXME: I don't know if getting key modifier status is possible without > > + * BIOS help. */ > >