Re: Fwd: [PATCH 1/2] Framebuffer split

2009-08-01 Thread Vladimir 'phcoder' Serbinenko
On Sat, Aug 1, 2009 at 5:10 PM, Vladimir 'phcoder' Serbinenko wrote: > Ok, I will try to split while keeping patch functional. Done >> -- >> Robert Millan >> >>  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and >>  how) you may access your data; but nobody's threatening yo

Re: Fwd: [PATCH 1/2] Framebuffer split

2009-08-01 Thread Michal Suchanek
2009/8/1 Vladimir 'phcoder' Serbinenko : > On Sat, Aug 1, 2009 at 5:14 PM, Michal Suchanek wrote: >> 2009/8/1 Robert Millan : >> I guess the current initialization is somewhat fishy. I haven't looked >> at the code so far but the way it works is odd. When I change output >> to gfxterm it apparently

Re: Fwd: [PATCH 1/2] Framebuffer split

2009-08-01 Thread Vladimir 'phcoder' Serbinenko
On Sat, Aug 1, 2009 at 5:14 PM, Michal Suchanek wrote: > 2009/8/1 Robert Millan : > I guess the current initialization is somewhat fishy. I haven't looked > at the code so far but the way it works is odd. When I change output > to gfxterm it apparently tries to initialize the vbe graphics but it >

Re: Fwd: [PATCH 1/2] Framebuffer split

2009-08-01 Thread Michal Suchanek
2009/8/1 Robert Millan : > On Mon, Jul 27, 2009 at 12:06:17AM +0200, Vladimir 'phcoder' Serbinenko wrote: >>    grub_err_t (*get_info) (struct grub_video_mode_info *mode_info); >> >> +  grub_err_t (*get_info_and_fini) (struct grub_video_mode_info *mode_info, >> +                                void

Re: [RFC] Don't pass filename in multiboot command line

2009-08-01 Thread Vladimir 'phcoder' Serbinenko
On Sat, Aug 1, 2009 at 5:05 PM, Robert Millan wrote: > On Sat, Aug 01, 2009 at 04:37:40PM +0200, Vladimir 'phcoder' Serbinenko wrote: >> > I agree with this.  But please wait a few days to give everyone a chance >> > to read it. >> > >> > Regarding the patch: >> > >> > There's a much simpler way to

Re: Fwd: [PATCH 1/2] Framebuffer split

2009-08-01 Thread Vladimir 'phcoder' Serbinenko
> > I see that returning framebuffer address and finishing the video subsystem > must be together, but is there a reason to couple this with getting mode_info > ? When designing this part I thought of accelerated graphics. Before loading the OS they would switch to standard framebuffer mode this m

Re: grub-pe2elf

2009-08-01 Thread Christian Franke
Robert Millan wrote: On Fri, Jul 31, 2009 at 08:27:58PM +0200, Christian Franke wrote: First of all, I'm worried that we have discussions to decide things and they are later forgotten or ignored. Bean, please can you provide some explanation on what happened? Also, I think this commit shoul

Re: [RFC] Don't pass filename in multiboot command line

2009-08-01 Thread Robert Millan
On Sat, Aug 01, 2009 at 04:37:40PM +0200, Vladimir 'phcoder' Serbinenko wrote: > > I agree with this.  But please wait a few days to give everyone a chance > > to read it. > > > > Regarding the patch: > > > > There's a much simpler way to address this.  Just add something like: > > > >  cmdline_arg

Re: Fwd: [PATCH 1/2] Framebuffer split

2009-08-01 Thread Robert Millan
On Sat, Aug 01, 2009 at 04:50:59PM +0200, Michal Suchanek wrote: > 2009/8/1 Robert Millan : > > On Fri, Jul 31, 2009 at 10:31:07PM +0200, Vladimir 'phcoder' Serbinenko > > wrote: > >> > Well, that fits the definition of backend. > >> > > >> But there are other backends too - network backend, openg

Re: Fwd: [PATCH 1/2] Framebuffer split

2009-08-01 Thread Robert Millan
On Mon, Jul 27, 2009 at 12:06:17AM +0200, Vladimir 'phcoder' Serbinenko wrote: >grub_err_t (*get_info) (struct grub_video_mode_info *mode_info); > > + grub_err_t (*get_info_and_fini) (struct grub_video_mode_info *mode_info, > +void **framebuffer); > + > [...]

Re: Fwd: [PATCH 1/2] Framebuffer split

2009-08-01 Thread Michal Suchanek
2009/8/1 Robert Millan : > On Fri, Jul 31, 2009 at 10:31:07PM +0200, Vladimir 'phcoder' Serbinenko wrote: >> > Well, that fits the definition of backend. >> > >> But there are other backends too - network backend, opengl backend, ... >> Framebuffer is a term often used to designated memory ranged w

Re: Fwd: [PATCH 1/2] Framebuffer split

2009-08-01 Thread Robert Millan
On Fri, Jul 31, 2009 at 10:31:07PM +0200, Vladimir 'phcoder' Serbinenko wrote: > > Well, that fits the definition of backend. > > > But there are other backends too - network backend, opengl backend, ... > Framebuffer is a term often used to designated memory ranged which is > mapped to the screen.

Re: [RFC] Don't pass filename in multiboot command line

2009-08-01 Thread Vladimir 'phcoder' Serbinenko
> I agree with this.  But please wait a few days to give everyone a chance > to read it. > > Regarding the patch: > > There's a much simpler way to address this.  Just add something like: > >  cmdline_argv = argv + 1; >  cmdline_argc = argc - 1; > > at the beginning, and then use cmdline_argv and c

Re: [RFC] Don't pass filename in multiboot command line

2009-08-01 Thread Robert Millan
On Sat, Aug 01, 2009 at 03:23:04PM +0200, Vladimir 'phcoder' Serbinenko wrote: > According to multiboot specification "It should be possible to write > compliant boot loaders that load the OS image from a variety of > sources, including floppy disk, hard disk, and across a network. " > It implicitl

Re: [PATCH] fix usability problem in FreeBSD loader

2009-08-01 Thread Robert Millan
On Sat, Aug 01, 2009 at 03:49:15PM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Sat, Aug 1, 2009 at 3:40 PM, Robert Millan wrote: > > > > There's a minor usability problem with FreeBSD loader.  E.g. if user runs > > freebsd_module first, the error message is confusing. > > > -static int kernel_

Re: grub-pe2elf

2009-08-01 Thread Robert Millan
On Fri, Jul 31, 2009 at 08:27:58PM +0200, Christian Franke wrote: >> First of all, I'm worried that we have discussions to decide things and they >> are later forgotten or ignored. Bean, please can you provide some >> explanation >> on what happened? >> >> Also, I think this commit should be reve

Re: [PATCH] Fix CPUID documentation and return values

2009-08-01 Thread Robert Millan
On Fri, Jul 31, 2009 at 06:41:44PM +0200, Felix Zielcke wrote: > > Ah in the thread you said that > `if cpuid --long-mode; then ...; else ...; fi' > doestn't work. > > But I just tested this with > `if cpuid --long-mode; then echo true; else echo false; fi' > in qemu and in 32bit I get false and

Re: 2273 lines in 170 files consists of only space and tabulators

2009-08-01 Thread Felix Zielcke
Am Samstag, den 01.08.2009, 06:05 -0400 schrieb Alfred M. Szmidt: > Uhm I thought this wasn't needed because the actual code didn't >change. But okay GCS talks about all changes made to source files >so you're probable right. > > Usually, such changes do not need to be mentioned in the Ch

Re: [PATCH] fix usability problem in FreeBSD loader

2009-08-01 Thread Vladimir 'phcoder' Serbinenko
On Sat, Aug 1, 2009 at 3:40 PM, Robert Millan wrote: > > There's a minor usability problem with FreeBSD loader.  E.g. if user runs > freebsd_module first, the error message is confusing. > -static int kernel_type; +static int kernel_type; /* 0 == KERNEL_TYPE_NONE */ I would prefer either static int

[PATCH] fix usability problem in FreeBSD loader

2009-08-01 Thread Robert Millan
There's a minor usability problem with FreeBSD loader. E.g. if user runs freebsd_module first, the error message is confusing. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: w

[RFC] Don't pass filename in multiboot command line

2009-08-01 Thread Vladimir 'phcoder' Serbinenko
According to multiboot specification "It should be possible to write compliant boot loaders that load the OS image from a variety of sources, including floppy disk, hard disk, and across a network. " It implicitly says that kernel shouldn't care about filename used by bootloader. About commandline

Re: 2273 lines in 170 files consists of only space and tabulators

2009-08-01 Thread Alfred M. Szmidt
Uhm I thought this wasn't needed because the actual code didn't change. But okay GCS talks about all changes made to source files so you're probable right. Usually, such changes do not need to be mentioned in the ChangeLog, since they do not change the behaviour of anything. The same go