Re: [Fwd: Re: Bug#495949: grub-common: grub-probe segfaults]

2009-07-24 Thread Felix Zielcke
Am Freitag, den 24.07.2009, 22:37 +0200 schrieb Vladimir 'phcoder' Serbinenko: > On Fri, Jul 24, 2009 at 10:09 PM, Pavel Roskin wrote: > > On Fri, 2009-07-24 at 20:46 +0200, Felix Zielcke wrote: > >> And another bug forward > >> Anyone has an idea why a dm-crypt/lvm leads to a segfault in the strcm

[Fwd: Bug#503344: Grub-pc fails on IBM x3250 configured with RAID-1]

2009-07-24 Thread Felix Zielcke
Is this an acceptable fix? Though I have the feeling this isn't a proper one. Weitergeleitete Nachricht > Von: Bob Gilligan > Reply-to: Bob Gilligan , 503...@bugs.debian.org > An: sub...@bugs.debian.org > Betreff: Bug#503344: Grub-pc fails on IBM x3250 configured with RAID-1 > D

Re: [BUGFIX] Don't use DT_DIR: It doesn't work on non-ext* filesystems

2009-07-24 Thread Christian Franke
Pavel Roskin wrote: On Fri, 2009-07-24 at 23:02 +0200, Christian Franke wrote: A correct performance-aware solution would look like: #ifdef DT_DIR if (de->d_type == DT_DIR) info.dir = 1; else if (de->type == DT_FILE) There in no DT_FILE in glibc, but there is DT_REG. Yes

Re: [BUGFIX] Don't use DT_DIR: It doesn't work on non-ext* filesystems

2009-07-24 Thread Pavel Roskin
On Fri, 2009-07-24 at 23:02 +0200, Christian Franke wrote: > A correct performance-aware solution would look like: > > #ifdef DT_DIR > if (de->d_type == DT_DIR) > info.dir = 1; > else if (de->type == DT_FILE) There in no DT_FILE in glibc, but there is DT_REG. DT_UNKNOWN is present. Per

Re: [PATCH] Faster text rendering by optimizing font glyph lookup

2009-07-24 Thread Felix Zielcke
Am Donnerstag, den 11.06.2009, 23:31 +0200 schrieb Vladimir 'phcoder' Serbinenko: > On Thu, Jun 11, 2009 at 12:28 PM, Felix Zielcke wrote: > > Am Montag, den 09.02.2009, 08:24 -0800 schrieb Colin D Bennett: > >> On Mon, 9 Feb 2009 15:11:16 +0100 > >> Robert Millan wrote: > >> > >> > On Sun, Feb 08

Re: [Fwd: Re: Bug#495949: grub-common: grub-probe segfaults]

2009-07-24 Thread Vladimir 'phcoder' Serbinenko
On Fri, Jul 24, 2009 at 10:56 PM, Pavel Roskin wrote: > On Fri, 2009-07-24 at 22:37 +0200, Vladimir 'phcoder' Serbinenko wrote: > >> Actualy I already fixed this in my patch for installing on >> partitionless devices. Since there were no oppositions I'll commit it > > OK, go ahead.  I just realized

Re: [Fwd: Re: Bug#495949: grub-common: grub-probe segfaults]

2009-07-24 Thread Vladimir 'phcoder' Serbinenko
> -      if (! strcmp (dest_partmap, "pc_partition_map")) > -       grub_util_warn ("This msdos-style partition label has no post-MBR > gap; embedding won't be possible!"); > -      else > -       grub_util_warn ("This GPT partition label has no BIOS Boot Partition; > embedding won't be possible!

Re: [PATCH] fix an infinite loop with a corrupted pc partition table

2009-07-24 Thread Pavel Roskin
On Fri, 2009-07-24 at 22:35 +0200, Vladimir 'phcoder' Serbinenko wrote: > Hello > >> This patch fixes it, but probable there's a better fix. > > > > We could require that all references to extended partitions are only > > considered if they lead to a sector after the one currently being > > process

Re: [BUGFIX] Don't use DT_DIR: It doesn't work on non-ext* filesystems

2009-07-24 Thread Christian Franke
Pavel Roskin wrote: On Thu, 2009-07-23 at 11:29 +0200, Vladimir 'phcoder' Serbinenko wrote: -#ifdef DT_DIR - info.dir = (de->d_type == DT_DIR); -#else info.dir = !! is_dir (path, de->d_name); -#endif Fine with me. Finally a patch that reduces the number of preprocessor di

Re: [Fwd: Re: Bug#495949: grub-common: grub-probe segfaults]

2009-07-24 Thread Pavel Roskin
On Fri, 2009-07-24 at 22:37 +0200, Vladimir 'phcoder' Serbinenko wrote: > Actualy I already fixed this in my patch for installing on > partitionless devices. Since there were no oppositions I'll commit it OK, go ahead. I just realized that your patch is a subset of my patch, so it would be fair

Re: [PATCH] fix an infinite loop with a corrupted pc partition table

2009-07-24 Thread Vladimir 'phcoder' Serbinenko
>> Here's a new one after comments from Vladimir on IRC >> loop count is increased to 100'000 and partitions with a starting sector >> of 0 are ignored. > > I don't see why it's better.  Do you think the links backwards should be > allowed? I think yes since breaking some configuration will be seen

Re: [Fwd: Re: Bug#495949: grub-common: grub-probe segfaults]

2009-07-24 Thread Vladimir 'phcoder' Serbinenko
On Fri, Jul 24, 2009 at 10:09 PM, Pavel Roskin wrote: > On Fri, 2009-07-24 at 20:46 +0200, Felix Zielcke wrote: >> And another bug forward >> Anyone has an idea why a dm-crypt/lvm leads to a segfault in the strcmp >> here: >>  grub_partition_iterate (dest_dev->disk, (strcmp (dest_partmap, >> "pc_p

Re: [PATCH] fix an infinite loop with a corrupted pc partition table

2009-07-24 Thread Vladimir 'phcoder' Serbinenko
Hello >> This patch fixes it, but probable there's a better fix. > > We could require that all references to extended partitions are only > considered if they lead to a sector after the one currently being > processed. I already thought about this and spoke about it on IRC. Unfortunately backward p

Re: [Fwd: Re: Bug#495949: grub-common: grub-probe segfaults]

2009-07-24 Thread Pavel Roskin
On Fri, 2009-07-24 at 16:09 -0400, Pavel Roskin wrote: > On Fri, 2009-07-24 at 20:46 +0200, Felix Zielcke wrote: > > And another bug forward > > Anyone has an idea why a dm-crypt/lvm leads to a segfault in the strcmp > > here: > > grub_partition_iterate (dest_dev->disk, (strcmp (dest_partmap, > >

Re: [PATCH] fix an infinite loop with a corrupted pc partition table

2009-07-24 Thread Pavel Roskin
On Fri, 2009-07-24 at 21:24 +0200, Felix Zielcke wrote: > Here's a new one after comments from Vladimir on IRC > loop count is increased to 100'000 and partitions with a starting sector > of 0 are ignored. I don't see why it's better. Do you think the links backwards should be allowed? -- Rega

Re: [Fwd: Re: Bug#495949: grub-common: grub-probe segfaults]

2009-07-24 Thread Pavel Roskin
On Fri, 2009-07-24 at 20:46 +0200, Felix Zielcke wrote: > And another bug forward > Anyone has an idea why a dm-crypt/lvm leads to a segfault in the strcmp > here: > grub_partition_iterate (dest_dev->disk, (strcmp (dest_partmap, > "pc_partition_map") ? >

Re: [PATCH] fix an infinite loop with a corrupted pc partition table

2009-07-24 Thread Pavel Roskin
On Fri, 2009-07-24 at 18:58 +0200, Felix Zielcke wrote: > With this [0] partition table grub-probe currently loops forever: > > kern/disk.c:389: Reading `hd1'... > partmap/pc.c:142: partition 0: flag 0x0, type 0x5, start 0x0, len > 0x11177330 That's so evil! > This patch fixes it, but probable t

Rotated menu on EFI?

2009-07-24 Thread Michal Suchanek
Hello Is there some chance that the grub menu could be drawn rotated on graphical devices like the efi graphics interface? Thanks Michal ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] fix an infinite loop with a corrupted pc partition table

2009-07-24 Thread Felix Zielcke
Am Freitag, den 24.07.2009, 18:58 +0200 schrieb Felix Zielcke: > > > With this [0] partition table grub-probe currently loops forever: > > kern/disk.c:389: Reading `hd1'... > partmap/pc.c:142: partition 0: flag 0x0, type 0x5, start 0x0, len > 0x11177330 > partmap/pc.c:142: partition 1: flag 0x0,

[Fwd: Re: Bug#495949: grub-common: grub-probe segfaults]

2009-07-24 Thread Felix Zielcke
And another bug forward Anyone has an idea why a dm-crypt/lvm leads to a segfault in the strcmp here: grub_partition_iterate (dest_dev->disk, (strcmp (dest_partmap, "pc_partition_map") ? find_usable_region_gpt : find_usable_region_msdos)); We

[PATCH] fix an infinite loop with a corrupted pc partition table

2009-07-24 Thread Felix Zielcke
With this [0] partition table grub-probe currently loops forever: kern/disk.c:389: Reading `hd1'... partmap/pc.c:142: partition 0: flag 0x0, type 0x5, start 0x0, len 0x11177330 partmap/pc.c:142: partition 1: flag 0x0, type 0x0, start 0x0, len 0x0 partmap/pc.c:142: partition 2: flag 0x0, type 0x0,

RE: [PATCH] Fix chainloding + Chainloading into logical partitions

2009-07-24 Thread Gregg C Levine
Hello! But I am. It is better that we fix these numerous bugs and probably does reorganize the code at the same time; then allowing this to persist and probably explode into a mess that causes undo upset to a user who's got no idea as to how to fix it if he can. Just like I am not comfortable with

Re: [Fwd: Bug#536846: grub-pc: /boot/vmlinux entry cannot be booted]

2009-07-24 Thread Pavel Roskin
On Fri, 2009-07-24 at 15:53 +0200, Jordi Mallach wrote: > In short, I *need* vmlinux to boot my PPC, but need to hide the vmlinuz > entries as they fail and are suppossed to be useful only to boot directly > from OF. Ie, just the contrary that this user is asking for. OK, I'm ready to apply a pat

Re: [Fwd: Bug#536846: grub-pc: /boot/vmlinux entry cannot be booted]

2009-07-24 Thread Jordi Mallach
On Fri, Jul 24, 2009 at 03:53:12PM +0200, Jordi Mallach wrote: > More interestingly, if I try to boot the vmlinuz entry I get dropped to > OpenFirmware, with a friendly Illegal Memory Access error message. Invalid memory access at %SRR0: 00203b94 %Srr1: 3030 load-size=edc0 adler32=e7f75f

Re: [Fwd: Bug#536846: grub-pc: /boot/vmlinux entry cannot be booted]

2009-07-24 Thread Jordi Mallach
On Fri, Jul 24, 2009 at 02:55:01PM +0200, Felix Zielcke wrote: > How about just removing support for vmlinux kernels in grub-mkconfig? > I.e: > > Index: util/grub.d/10_linux.in > === > --- util/grub.d/10_linux.in (revision 2441) > +

Re: [Fwd: Bug#536846: grub-pc: /boot/vmlinux entry cannot be booted]

2009-07-24 Thread Pavel Roskin
On Fri, 2009-07-24 at 14:55 +0200, Felix Zielcke wrote: > How about just removing support for vmlinux kernels in grub-mkconfig? I was thinking of it. However PowerPC uses vmlinux for the kernels, and maybe Sparc too. And I'm not sure about the i386-efi architecture. We would need consider the a

[Fwd: Bug#536846: grub-pc: /boot/vmlinux entry cannot be booted]

2009-07-24 Thread Felix Zielcke
How about just removing support for vmlinux kernels in grub-mkconfig? I.e: Index: util/grub.d/10_linux.in === --- util/grub.d/10_linux.in (revision 2441) +++ util/grub.d/10_linux.in (working copy) @@ -112,7 +112,7 @@ EOF EOF

Re: [Fwd: Bug#532202: grub-pc: behaves strange in virtualbox with a disk > 2 TB]

2009-07-24 Thread Samuel Thibault
Hello, This is most probably a bug of the BIOS. I had pushed to bochs' BIOS a patch to implement LBA48 so as to overcome the LBA28 limitation (2^28*512 = 128GB), but it still has a 2^32 sectors limitation as all computations are done with 32bit integers, that's 2TB... Samuel __

[Fwd: Bug#532202: grub-pc: behaves strange in virtualbox with a disk > 2 TB]

2009-07-24 Thread Felix Zielcke
Seems like 64bit filesystem/disk support isn't that well tested (Ok doestn't surprise me who has a > 2 Tib disk :)) Weitergeleitete Nachricht > Von: Marc Haber > Reply-to: Marc Haber , > 532...@bugs.debian.org > An: Debian Bug Tracking System > Betreff: Bug#532202: grub-pc: beh

[Fwd: Bug#533898: grub-mkdevicemap gives wrong alias for device on powerpc]

2009-07-24 Thread Felix Zielcke
Anyone knows something about this one? By the way I'm still not sure if I should forward bugs to grub-devel or bug-grub. IIRC nobody objected against using bug-grub but I think only Vladimir, Robert and me are subscribed there or is that not true? Weitergeleitete Nachricht > Von

Re: sparc: [Fwd: Bug#538030: grub-ieee1275 fails to install bootblock]

2009-07-24 Thread Alexander Vlasov
Hi, David Miller davemloft.net> writes: > But for the initial bug this user has, can we find out what lives > inside of this directory: > > /sys/devices/root/f0063e50/pci:02/:02:00.0/:03:09.0/:0a:00.0 /:0b:01.0/host0/port-0:0/end_device-0:0/sas_device:end_device-0:0/ > > an