[PATCH] Call a module's init function only after the module is successfully added

2009-07-20 Thread Joe Auricchio
Hi, * kern/dl.c (grub_dl_load_core): Call grub_dl_call_init only after successful grub_dl_add With this patch the module's init function will no longer be called: - if the module is already loaded - if malloc fails in grub_dl_add - before the module is added to grub_dl_head The first two are er

Re: [PATCH] BFS support

2009-07-20 Thread Vladimir 'phcoder' Serbinenko
Committed On Sun, Jul 19, 2009 at 6:01 PM, Vladimir 'phcoder' Serbinenko wrote: > On Sat, Jul 18, 2009 at 8:51 PM, Robert Millan wrote: >> On Sat, Jul 18, 2009 at 12:59:45AM +0200, Vladimir 'phcoder' Serbinenko >> wrote: >>> Hello. Here is a patch to add BFS support to GRUB2. BFS is a >>> filesys

Re: [PATCH] xfs bug fix

2009-07-20 Thread Pavel Roskin
On Sun, 2009-07-19 at 17:04 +0800, Bean wrote: > Oh nice catch, it's indeed a serious problem, this patch should fix it. Please don't add any trailing whitespace. Also please avoid formatting changes in the patches posted for review. If you find formatting in xfs.c too bad, you can indent the o

Re: [PATCH] Support for OSX (replace the old one)

2009-07-20 Thread Pavel Roskin
On Sun, 2009-07-19 at 12:46 +0200, Yves Blusseau wrote: > Hi, > > here's a patch so grub-setup can be compiled and work on MacOSX. > > The only problem remaining is trampoline (nested functions), because > OSX don't want > to execute code in the heap. > > This patch is a rewriting of the last

Re: [PATCH] AFS fixes and improvements

2009-07-20 Thread Pavel Roskin
On Mon, 2009-07-20 at 20:56 +0200, Vladimir 'phcoder' Serbinenko wrote: > I'm ok with it in condition that pre-release freeze period won't last > long. Now Marco Gerards is just back from vacation and I propose to > wait for his statements rather than speaking about virtual release OK -- Regard

Re: [PATCH] AFS fixes and improvements

2009-07-20 Thread Vladimir 'phcoder' Serbinenko
On Mon, Jul 20, 2009 at 8:34 PM, Pavel Roskin wrote: > On Mon, 2009-07-20 at 11:36 +0200, Vladimir 'phcoder' Serbinenko wrote: >> On Sun, Jul 19, 2009 at 10:47 PM, Pavel Roskin wrote: >> > I think we should release 1.97 first.  Sorry, I know that it's bad to >> > sit on a pile of code, but in my op

Re: [PATCH] AFS fixes and improvements

2009-07-20 Thread Pavel Roskin
On Mon, 2009-07-20 at 11:36 +0200, Vladimir 'phcoder' Serbinenko wrote: > On Sun, Jul 19, 2009 at 10:47 PM, Pavel Roskin wrote: > > I think we should release 1.97 first. Sorry, I know that it's bad to > > sit on a pile of code, but in my opinion, the nested partition patch is > > too intrusive at

Re: [PATCH] Clear out gfxterm's virtual text_buffer - fixes junk at end of lines

2009-07-20 Thread Vladimir 'phcoder' Serbinenko
On Sat, Jul 18, 2009 at 9:15 AM, Joe Auricchio wrote: > Hi, > > My first patch! Please be nice. Welcome aboard > > * src/term/gfxterm.c (grub_virtual_screen_setup): Clear out text_buffer > instead of leaving it uninitialized. > No needfor "src" part > This fixes a 100% reproducible and very annoyin

Re: [PATCH] AFS fixes and improvements

2009-07-20 Thread Vladimir 'phcoder' Serbinenko
On Sun, Jul 19, 2009 at 10:47 PM, Pavel Roskin wrote: > On Sun, 2009-07-19 at 22:40 +0200, Vladimir 'phcoder' Serbinenko wrote: >> > I prefer not to fix minor memory leaks by huge patches.  I have a patch, >> > I just wanted to look at the possibility to use grub_kzalloc() and >> > allocating data