Re: [PATCH] AFS fixes and improvements

2009-07-18 Thread Pavel Roskin
Quoting Vladimir 'phcoder' Serbinenko : Update: added symlink support On Fri, Jul 17, 2009 at 9:30 PM, Vladimir 'phcoder' Serbinenko wrote: Hello. Currently I'm coding BFS (filesystem of BeOS and Haiku) which is similar to AFS. So I took the later as codebase. I found some bugs and incompleten

Re: [PATCH] xfs bug fix

2009-07-18 Thread Pavel Roskin
Quoting Pavel Roskin : ==11029== Conditional jump or move depends on uninitialised value(s) ==11029==at 0x403CAE: grub_disk_adjust_range (disk.c:373) ==11029==by 0x403D6C: grub_disk_read (disk.c:392) ==11029==by 0x41CB8C: grub_xfs_read_inode (xfs.c:222) P.S. It looks like struct gr

Re: [PATCH] xfs bug fix

2009-07-18 Thread Pavel Roskin
Quoting Bean : The current xfs driver uses fixed inode size (256), this patch should fix it. I'm afraid this patch doesn't take something into account. I tried creating an image by mkfs.xfs -i log=9 /root/tmp/xfs.img -f Then I copied stgit sources on top of it (it's just a directory with

Re: [PATCH] New object format

2009-07-18 Thread Isaac Dupree
Bean wrote: Hi, This patch implement a new object format, the advantages are: Reduce size dramatically, some result: Size of all modules: original: 645575 new: 519093 [I thought I sent this message a few days ago, guess not?] What are the compressed-size comparisons? -Isaac

Re: [PATCH] enable buildable targets by default

2009-07-18 Thread Pavel Roskin
On Sat, 2009-07-18 at 23:38 +0200, Vladimir 'phcoder' Serbinenko wrote: > > I fully agree. The idea with my proposal (we talked this on IRC, I think) > > was to simplify things, so I proposed that we enable everything so we don't > > have to provide flags, etc. > The main pro was to avoid frequen

Re: [PATCH] Clear out gfxterm's virtual text_buffer - fixes junk at end of lines

2009-07-18 Thread Joe Auricchio
On 18 Jul, 2009, at 11:58 , Robert Millan wrote: On Sat, Jul 18, 2009 at 12:15:04AM -0700, Joe Auricchio wrote: This fixes a 100% reproducible and very annoying bug I've found: Switch to gfxterm and until your clear the screen or scroll, the last position of every line has a random junk c

Re: [PATCH] change --enable-efiemu to --enable-efiemu64

2009-07-18 Thread Pavel Roskin
On Sat, 2009-07-18 at 20:32 +0200, Robert Millan wrote: > On Fri, Jul 17, 2009 at 06:15:57PM +0200, Vladimir 'phcoder' Serbinenko wrote: > > Like previously discussed efiemu32 can always be compiled hence this patch > > This does a few more things than just toggle compile options. Could you > spl

Re: [PATCH] enable buildable targets by default

2009-07-18 Thread Vladimir 'phcoder' Serbinenko
On Sat, Jul 18, 2009 at 7:55 PM, Robert Millan wrote: > On Fri, Jul 17, 2009 at 10:49:09AM -0400, Pavel Roskin wrote: >> Once everything is compiled by default, some of the configure options >> become less meaningful, so we can consider removing them. >> [...] >> I think we should provide meaningfu

Re: [PATCH] Fix when installing on pationless but partionable medium

2009-07-18 Thread Vladimir 'phcoder' Serbinenko
> I don't understand what you mean here. Let's take a common example of cdrom. Most of the users and developers are accustomed to a cdrom holding one filesystem. On macs however cds are partitioned and not being able to access all the partitions is a problem for end user. Such situations are probab

Re: Grub & accessibility

2009-07-18 Thread Samuel Thibault
Robert Millan, le Sat 18 Jul 2009 22:03:25 +0200, a écrit : > I won't allow, however, grub-extras to be used as an excuse to avoid > paperwork for code specifically written for GRUB. That's fine with me at least, since I've already signed the papers :) Samuel ___

Re: [PATCH] Bug fix for LVM

2009-07-18 Thread Robert Millan
On Sat, Jul 18, 2009 at 09:59:55PM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Sat, Jul 18, 2009 at 9:43 PM, Bean wrote: > > On Sun, Jul 19, 2009 at 3:11 AM, Robert Millan wrote: > >> On Sat, Jul 18, 2009 at 10:11:19PM +0800, Bean wrote: > >>>      } > >>> > >>>    grub_raid_rescan (); > >>> +

Re: Grub & accessibility

2009-07-18 Thread Robert Millan
On Sun, Jul 12, 2009 at 10:51:04AM -0400, Pavel Roskin wrote: > Quoting Samuel Thibault : > >> (sorry phcoder for the duplication) >> >> Robert Millan, le Fri 10 Jul 2009 19:22:48 +0200, a écrit : >>> We've made some exceptions, but in general, we'd like to keep the GRUB >>> codebase made entirely

Re: [PATCH] Bug fix for LVM

2009-07-18 Thread Vladimir 'phcoder' Serbinenko
On Sat, Jul 18, 2009 at 9:43 PM, Bean wrote: > On Sun, Jul 19, 2009 at 3:11 AM, Robert Millan wrote: >> On Sat, Jul 18, 2009 at 10:11:19PM +0800, Bean wrote: >>>      } >>> >>>    grub_raid_rescan (); >>> +  grub_lvm_fini (); >>> +  grub_lvm_init (); >> >> This is aside from this patch, but I don't

Re: [PATCH] Bug fix for LVM

2009-07-18 Thread Robert Millan
On Sun, Jul 19, 2009 at 03:43:10AM +0800, Bean wrote: > On Sun, Jul 19, 2009 at 3:11 AM, Robert Millan wrote: > > On Sat, Jul 18, 2009 at 10:11:19PM +0800, Bean wrote: > >>      } > >> > >>    grub_raid_rescan (); > >> +  grub_lvm_fini (); > >> +  grub_lvm_init (); > > > > This is aside from this p

Re: [PATCH] Bug fix for LVM

2009-07-18 Thread Bean
On Sun, Jul 19, 2009 at 3:11 AM, Robert Millan wrote: > On Sat, Jul 18, 2009 at 10:11:19PM +0800, Bean wrote: >>      } >> >>    grub_raid_rescan (); >> +  grub_lvm_fini (); >> +  grub_lvm_init (); > > This is aside from this patch, but I don't see the purpose of this > grub_raid_rescan() function.

Re: [PATCH] Fix when installing on pationless but partionable medium

2009-07-18 Thread Robert Millan
On Sat, Jul 18, 2009 at 09:00:36PM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Sat, Jul 18, 2009 at 8:42 PM, Robert Millan wrote: > > On Fri, Jul 17, 2009 at 06:41:59PM +0200, Vladimir 'phcoder' Serbinenko > > wrote: > >> Sometimes a media that can be partioned isn't really partioned. E.g. >

Re: [PATCH] Fix when installing on pationless but partionable medium

2009-07-18 Thread Robert Millan
On Sat, Jul 18, 2009 at 09:01:38PM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Sat, Jul 18, 2009 at 8:45 PM, Robert Millan wrote: > > On Fri, Jul 17, 2009 at 05:51:40PM +0100, Colin Watson wrote: > >> On Fri, Jul 17, 2009 at 06:41:59PM +0200, Vladimir 'phcoder' Serbinenko > >> wrote: > >> > S

Re: [PATCH 2/2] RFT: Remove ABS macro from boot/i386/pc/boot.S

2009-07-18 Thread Robert Millan
On Sat, Jul 18, 2009 at 08:34:41PM +0200, Vladimir 'phcoder' Serbinenko wrote: > Haiku can be compiled and can use either gcc 4.x or gcc2.95. The main > reason for them to keep gcc 2.95 possibility is the binary > compatibility with BeOS. As François Revol explained me on IRC C++ ABI > changed from

Re: [PATCH] Bug fix for LVM

2009-07-18 Thread Robert Millan
On Sat, Jul 18, 2009 at 10:11:19PM +0800, Bean wrote: > } > >grub_raid_rescan (); > + grub_lvm_fini (); > + grub_lvm_init (); This is aside from this patch, but I don't see the purpose of this grub_raid_rescan() function. It's in raid.mod but only used by grub-fstest, so at least it

Re: [PATCH] Fix when installing on pationless but partionable medium

2009-07-18 Thread Vladimir 'phcoder' Serbinenko
On Sat, Jul 18, 2009 at 8:45 PM, Robert Millan wrote: > On Fri, Jul 17, 2009 at 05:51:40PM +0100, Colin Watson wrote: >> On Fri, Jul 17, 2009 at 06:41:59PM +0200, Vladimir 'phcoder' Serbinenko >> wrote: >> > Sometimes a media that can be partioned isn't really partioned. E.g. >> > usb sticks. This

Re: [PATCH] Fix when installing on pationless but partionable medium

2009-07-18 Thread Vladimir 'phcoder' Serbinenko
On Sat, Jul 18, 2009 at 8:42 PM, Robert Millan wrote: > On Fri, Jul 17, 2009 at 06:41:59PM +0200, Vladimir 'phcoder' Serbinenko wrote: >> Sometimes a media that can be partioned isn't really partioned. E.g. >> usb sticks. This is a patch to handle this situation. > > But we had a check for this alr

Re: [PATCH] Clear out gfxterm's virtual text_buffer - fixes junk at end of lines

2009-07-18 Thread Robert Millan
On Sat, Jul 18, 2009 at 12:15:04AM -0700, Joe Auricchio wrote: > Hi, > > My first patch! Please be nice. > > * src/term/gfxterm.c (grub_virtual_screen_setup): Clear out text_buffer > instead of leaving it uninitialized. > > This fixes a 100% reproducible and very annoying bug I've found: Switch >

Re: please stop this

2009-07-18 Thread Vladimir 'phcoder' Serbinenko
>> > In any case, this kind of changes need wider consensus, and including the >> > maintainers in it. >> The problem is that most comments are in the form "maybe I agree maybe >> I don't". Such kind of discussions may never result in consensus. >> Useful patches lying in bitrot somewhere on the li

Re: [PATCH] BFS support

2009-07-18 Thread Robert Millan
On Sat, Jul 18, 2009 at 12:59:45AM +0200, Vladimir 'phcoder' Serbinenko wrote: > Hello. Here is a patch to add BFS support to GRUB2. BFS is a > filesystem which was originally developped by Be, Inc for their > proprietary BeOS. When Be Inc was sold to Palm and developpement of > BeOS ceased a commu

Re: [PATCH] Fix when installing on pationless but partionable medium

2009-07-18 Thread Robert Millan
On Fri, Jul 17, 2009 at 05:51:40PM +0100, Colin Watson wrote: > On Fri, Jul 17, 2009 at 06:41:59PM +0200, Vladimir 'phcoder' Serbinenko wrote: > > Sometimes a media that can be partioned isn't really partioned. E.g. > > usb sticks. This is a patch to handle this situation. Unfortunately > > such me

Re: [PATCH] Fix when installing on pationless but partionable medium

2009-07-18 Thread Robert Millan
On Fri, Jul 17, 2009 at 06:41:59PM +0200, Vladimir 'phcoder' Serbinenko wrote: > Sometimes a media that can be partioned isn't really partioned. E.g. > usb sticks. This is a patch to handle this situation. But we had a check for this already, is it not working? if (! dest_dev->disk->has_partiti

Re: [PATCH 2/2] RFT: Remove ABS macro from boot/i386/pc/boot.S

2009-07-18 Thread Vladimir 'phcoder' Serbinenko
On Sat, Jul 18, 2009 at 8:22 PM, Robert Millan wrote: > On Sat, Jul 18, 2009 at 05:17:10PM +0200, Vladimir 'phcoder' Serbinenko wrote: >> On Thu, Jul 16, 2009 at 5:47 AM, Pavel Roskin wrote: >> > ChangeLog: >> > >> >        * boot/i386/pc/boot.S: Remove ABS macro, it's useless now. >> Could you wai

Re: [PATCH] change --enable-efiemu to --enable-efiemu64

2009-07-18 Thread Robert Millan
On Fri, Jul 17, 2009 at 06:15:57PM +0200, Vladimir 'phcoder' Serbinenko wrote: > Like previously discussed efiemu32 can always be compiled hence this patch This does a few more things than just toggle compile options. Could you split the patch? > diff --git a/ChangeLog b/ChangeLog > index e38ebc

Re: [PATCH] Support for OSX

2009-07-18 Thread Robert Millan
On Thu, Jul 16, 2009 at 07:45:44PM +0200, Yves Blusseau wrote: > Hi, > > here's a patch so grub-setup can be compiled and work on MacOSX. > > The only problem remaining is trampoline (nested functions), because OSX > don't want > to execute code in the heap. Hi, I have some comments (some of the

Re: [PATCH 2/2] RFT: Remove ABS macro from boot/i386/pc/boot.S

2009-07-18 Thread Robert Millan
On Sat, Jul 18, 2009 at 05:17:10PM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Thu, Jul 16, 2009 at 5:47 AM, Pavel Roskin wrote: > > ChangeLog: > > > >        * boot/i386/pc/boot.S: Remove ABS macro, it's useless now. > Could you wait before committing this patch? I'm currently making > grub2

Re: [PATCH 2/2] Disable lzo compression, lzma is doing its job just fine

2009-07-18 Thread Robert Millan
On Thu, Jul 16, 2009 at 06:24:14PM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Thu, Jul 16, 2009 at 1:40 AM, Pavel Roskin wrote: > > ChangeLog: > > > >        * Makefile.in: Remove LIBLZO and enable_lzo. > >        * conf/i386-pc.rmk: Remove lzo support. > >        * configure.ac: Remove check

Re: please stop this

2009-07-18 Thread Robert Millan
On Thu, Jul 16, 2009 at 06:10:48PM +0200, Vladimir 'phcoder' Serbinenko wrote: > > > > Usually, I only go through the trouble of implementing things when it's > > clear they will be merged in some form.  But I understand it's not > > the same for everyone.  So if I missunderstood, please accept my

Re: [PATCH] enable buildable targets by default

2009-07-18 Thread Robert Millan
On Fri, Jul 17, 2009 at 10:49:09AM -0400, Pavel Roskin wrote: > Once everything is compiled by default, some of the configure options > become less meaningful, so we can consider removing them. > [...] > I think we should provide meaningful options. For example, an option to > disable compiling de

Re: [PATCH 2/2] RFT: Remove ABS macro from boot/i386/pc/boot.S

2009-07-18 Thread Vladimir 'phcoder' Serbinenko
On Thu, Jul 16, 2009 at 5:47 AM, Pavel Roskin wrote: > ChangeLog: > >        * boot/i386/pc/boot.S: Remove ABS macro, it's useless now. Could you wait before committing this patch? I'm currently making grub2 compiling with gcc 2.95 supplied as a possibility (another one is gcc 4.x) with haiku. The

[PATCH] Bug fix for LVM

2009-07-18 Thread Bean
Hi, This patch fixes a few bug in lvm. There can be multiple copies of meta data, it's not an error, ignore the extra copy instead of quit. In case of LVM on RAID, the raid device and first disk would have the same lvm header ! The raid device would be found first, so we don't replace pv->disk i

[PATCH] Clear out gfxterm's virtual text_buffer - fixes junk at end of lines

2009-07-18 Thread Joe Auricchio
Hi, My first patch! Please be nice. * src/term/gfxterm.c (grub_virtual_screen_setup): Clear out text_buffer instead of leaving it uninitialized. This fixes a 100% reproducible and very annoying bug I've found: Switch to gfxterm and until your clear the screen or scroll, the last position of