Re: status grub2 port of grub-legasy map command

2009-04-17 Thread Vladimir Serbinenko
> > we tell it not to touch the 640K-1M area? > On most machines this range is in ROM and VGA buffer so FreeDOS doesn't touch it anyway > > -- > -- Lazy, Oblivious, Rational Disaster -- Habbit > > ___ > Grub-devel mailing list > Grub-devel@gnu.org > http

Re: status grub2 port of grub-legasy map command

2009-04-17 Thread Javier Martín
El vie, 17-04-2009 a las 20:01 -0400, John Stanley escribió: > Ok, that sounds good... I feel better about it then. I didn't mean > directly modifying bios data, but through doc'd bios ints of course. It > been a long, long time since I've looked at (or dealt with) bios code, > so I was was simp

Re: [PATCH] xnu

2009-04-17 Thread Joey Korkames
Thanks for the comments. After reading those and peeking around your code, I have a much better config that allos xnu.mod to give proper panic text: #http://grub.enbug.org/gfxterm loadfont /osstore/STAGE1a/grub2/unifont.pf2 set gfxmode="800x600x32" set vbe_mode=0x115 terminal_output gfxterm

Re: status grub2 port of grub-legasy map command

2009-04-17 Thread John Stanley
Ok, that sounds good... I feel better about it then. I didn't mean directly modifying bios data, but through doc'd bios ints of course. It been a long, long time since I've looked at (or dealt with) bios code, so I was was simply wondering if boot device naming could be modified in a docu

Re: [PATCH] xnu

2009-04-17 Thread Vladimir Serbinenko
> > xnu_kernel /osstore/STAGE2/DARWIN/live/mach_kernel -v -s rd=md0 >> > -v option controls the booter and not the kernel. It's totally ignored by grub which always boots the kernel in verbose mode. In future I'll add a command to load the splash which will switch to splash mode _

Re: status grub2 port of grub-legasy map command

2009-04-17 Thread Vladimir Serbinenko
On Sat, Apr 18, 2009 at 1:12 AM, John Stanley wrote: > Hi Javier and all, > I could probably have a version of the drivemap completed this weekend as > well, but since I've basically simply adapted your drivempa.patch.8 to > r2106, with little change, I'd be more comfortable going with your new pa

Re: [PATCH] xnu

2009-04-17 Thread Vladimir Serbinenko
On Sat, Apr 18, 2009 at 1:22 AM, Joey Korkames > wrote: > I have your whole patch series applied and have been trying to use this to > boot the PureDarwin 9 kernel (on various x86 32 & 64 bit machines): > > menuentry "PureDarwin 9 (phcoder efiemu)" { > #efiemu_loadcore /osstore/STAGE1a/grub

Re: [PATCH] xnu

2009-04-17 Thread Joey Korkames
I have your whole patch series applied and have been trying to use this to boot the PureDarwin 9 kernel (on various x86 32 & 64 bit machines): menuentry "PureDarwin 9 (phcoder efiemu)" { #efiemu_loadcore /osstore/STAGE1a/grub2/efiemu32.o efiemu_loadcore /osstore/STAGE1a/grub2/efiem

Re: Eliminating nested functions

2009-04-17 Thread David Miller
From: Pavel Roskin Date: Fri, 17 Apr 2009 11:54:57 -0400 > I suggest that we eliminate all nested functions. I support this completely. ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: status grub2 port of grub-legasy map command

2009-04-17 Thread John Stanley
Hi Javier and all, I could probably have a version of the drivemap completed this weekend as well, but since I've basically simply adapted your drivempa.patch.8 to r2106, with little change, I'd be more comfortable going with your new patch since you know the code much better. In addition, in

Re: Eliminating nested functions

2009-04-17 Thread Christian Franke
Pavel Roskin wrote: I suggest that we eliminate all nested functions. The reasons are: 1) They make the code less readable, as they make the parent functions longer. 2) They have problems with some popular compilers, as recent as gcc-4.0 when regparm(3) is used. 3) We failed to implement a re

Re: status grub2 port of grub-legasy map command

2009-04-17 Thread Vladimir Serbinenko
Thank you for the feedback on my patch. Also I'll add a function to allocation and register map for hook. Also > The preboot hooks patch works beautifully. Don't forget to make cleanup function in case loader fails > However, mmap causes some > sort of glitch that makes FreeDOS (one of my three

Re: Eliminating nested functions

2009-04-17 Thread Pavel Roskin
On Sat, 2009-04-18 at 03:33 +0800, Bean wrote: > Hi, > > One of the advantage of nested function is to use local variables. > Without it, we would need to pass them as global variable, or add > custom data pointer in many of the iterate function, which would make > the code a lot uglier IMO. Ind

Re: status grub2 port of grub-legasy map command

2009-04-17 Thread Javier Martín
Hello there. I am the original author of the drivemap command. I was told by a friend that it was being discussed again on the GRUB list, so I came back and examined the two new enabling functionalities, preboot hooks and mmap. I've adapted drivemap to use them both, and I'm polishing some rough ed

Re: Eliminating nested functions

2009-04-17 Thread Vladimir Serbinenko
On Fri, Apr 17, 2009 at 9:33 PM, Bean wrote: > Hi, > > One of the advantage of nested function is to use local variables. > Without it, we would need to pass them as global variable, or add > custom data pointer in many of the iterate function, which would make > the code a lot uglier IMO. > Do y

Re: Eliminating nested functions

2009-04-17 Thread Bean
Hi, One of the advantage of nested function is to use local variables. Without it, we would need to pass them as global variable, or add custom data pointer in many of the iterate function, which would make the code a lot uglier IMO. On Fri, Apr 17, 2009 at 11:54 PM, Pavel Roskin wrote: > Hello!

Eliminating nested functions

2009-04-17 Thread Pavel Roskin
Hello! While I have just applied a patch adding NESTED_FUNC_ATTR to several functions as an emergency fix for a major breakage in ata, ohci, uhci and lspci modules, I would prefer a more radical solution. I suggest that we eliminate all nested functions. The reasons are: 1) They make the code l

Re: r2074 broke ata module

2009-04-17 Thread Pavel Roskin
On Fri, 2009-04-17 at 10:39 -0400, Ward Vandewege wrote: > On Wed, Apr 15, 2009 at 05:50:42PM -0400, Pavel Roskin wrote: > > On Wed, 2009-04-15 at 17:34 -0400, Ward Vandewege wrote: > > > Hi there, > > > > > > I tried to use the ata module today in combination with grub2's coreboot > > > code, but

Re: r2074 broke ata module

2009-04-17 Thread Ward Vandewege
On Wed, Apr 15, 2009 at 05:50:42PM -0400, Pavel Roskin wrote: > On Wed, 2009-04-15 at 17:34 -0400, Ward Vandewege wrote: > > Hi there, > > > > I tried to use the ata module today in combination with grub2's coreboot > > code, but found that it broke in r2074, specifically by this hunk: > > Actual

Re: [PATCH] Split #4: text menu separation

2009-04-17 Thread Bean
Hi, With the handler.lst patch, commands to switch between different handler are registered automatically. For example, you can start the text menu with this command: menu_viewer.text On Fri, Apr 17, 2009 at 7:28 PM, phcoder wrote: > Hello. Couldn't this be done by transforming menu viewer to

Re: [PATCH] Split #4: text menu separation

2009-04-17 Thread phcoder
Hello. Couldn't this be done by transforming menu viewer to a command? What are pros and contras of both approaches? Bean wrote: Hi, This patch moves menu_text.c to menu/text/, and it changes grub_menu_viewer structure as handler. -

Re: [PATCH] Split 3: boot script support

2009-04-17 Thread phcoder
Hello, I find this useful. It permits e.g. to have root by uuid. >/* Not an ELF module, skip. */ This comment is out of sync Bean wrote: Hi, This patch allows grub-mkimage to embed a boot script in core.img, which would be executed by the rescue parser before switching to normal mode.

Re: [PATCH] parttool

2009-04-17 Thread phcoder
Thank you for the testing Please remove one space after "list". done I've tested the command quickly. A few notes. We need a command to list the partition table, as "ls" doesn't show the partition types. The easiest way is to add an info string to partmap structure. This, however pollutes t