Re: GRUB device names wrt. ieee1275

2009-03-22 Thread David Miller
From: Robert Millan Date: Sun, 22 Mar 2009 13:22:34 +0100 > On Sun, Mar 22, 2009 at 01:41:52AM +0100, phcoder wrote: > > I don't see why > > sth like > > (/p...@1e\,60/p...@0/p...@9/p...@0/s...@1/d...@0,1) > > is a problem. > > FWIW, I like this much better than replacing our comma separat

Re: [PATCH] Use hfs case ordering - another try

2009-03-22 Thread Jordi Mallach
Hi Pavel, On Mon, Mar 09, 2009 at 01:37:14PM -0400, Pavel Roskin wrote: > Hello! > > It's a shame the discussion about hfs got nowhere. I've made another > patch. I didn't look at the Linux hfs sources or at any previous > patches. I took the case ordering table from hfsutils 3.2.6, which is >

Re: GRUB device names wrt. ieee1275

2009-03-22 Thread David Miller
From: phcoder Date: Sun, 22 Mar 2009 23:51:14 +0100 > You could do it the way similar to how it's done on i386-pc: > jmp use_hardcoded > > use_hardcoded: > And then the grub-setup tool nops out the first jump if stage2 > resides on a disk different than where bootblock is Sure we could do that.

Re: GRUB device names wrt. ieee1275

2009-03-22 Thread phcoder
You could do it the way similar to how it's done on i386-pc: jmp use_hardcoded use_hardcoded: And then the grub-setup tool nops out the first jump if stage2 resides on a disk different than where bootblock is David Miller wrote: From: phcoder Date: Sun, 22 Mar 2009 12:17:17 +0100 As for the

[PATCH] build 32-bit Linux loader as `linux', rename legacy loader to `linux16'

2009-03-22 Thread Robert Millan
On Sat, Mar 21, 2009 at 06:50:56PM +0100, Robert Millan wrote: > On Wed, Mar 18, 2009 at 02:09:11PM +0100, phcoder wrote: > > IMO linux16 for pc/linux.c would better reflect the difference with > > normal 'linux' command. > > I'm fine with that. Does anyone object to the proposed rename? > > N

Re: Move loader.c out of the kernel

2009-03-22 Thread Yoshinori K. Okuji
On Sunday 22 March 2009 23:19:09 phcoder wrote: > Yoshinori K. Okuji wrote: > > On Sunday 22 March 2009 22:30:24 phcoder wrote: > >> Yoshinori K. Okuji wrote: > >>> On Sunday 22 March 2009 22:06:36 phcoder wrote: > Yoshinori K. Okuji wrote: > > On Sunday 22 March 2009 21:48:21 phcoder wrot

Re: Move loader.c out of the kernel

2009-03-22 Thread Robert Millan
On Sun, Mar 22, 2009 at 11:01:41PM +0900, Yoshinori K. Okuji wrote: > > > > If it's unable to read FS then it can't boot much anyway. If it's it can > > load modules from its own partition. The only use I see is when grub > > partition is corrupted but OS one is intact and you already have FS > > d

Re: Move loader.c out of the kernel

2009-03-22 Thread phcoder
Yoshinori K. Okuji wrote: On Sunday 22 March 2009 22:30:24 phcoder wrote: Yoshinori K. Okuji wrote: On Sunday 22 March 2009 22:06:36 phcoder wrote: Yoshinori K. Okuji wrote: On Sunday 22 March 2009 21:48:21 phcoder wrote: Hello. Now when boot command isn't in kernel anymore I don't see why l

Re: Migrating to GRUB 2 in Debian (Re: Interesting GSoC project ideas for 09)

2009-03-22 Thread Yoshinori K. Okuji
On Sunday 22 March 2009 22:23:53 phcoder wrote: > Yoshinori K. Okuji wrote: > > On Sunday 22 March 2009 19:48:36 phcoder wrote: > >> Hello, I agree that non-sector aligned writes should be handled > >> correctly. However I disagree with removing of the magic number. I > >> personally would prefer i

Re: Move loader.c out of the kernel

2009-03-22 Thread Yoshinori K. Okuji
On Sunday 22 March 2009 22:30:24 phcoder wrote: > Yoshinori K. Okuji wrote: > > On Sunday 22 March 2009 22:06:36 phcoder wrote: > >> Yoshinori K. Okuji wrote: > >>> On Sunday 22 March 2009 21:48:21 phcoder wrote: > Hello. Now when boot command isn't in kernel anymore I don't see why > loa

Re: Leak fixes

2009-03-22 Thread phcoder
Robert Millan wrote: On Sun, Mar 22, 2009 at 02:09:52PM +0100, phcoder wrote: - grub_disk_cache_invalidate (dev_id, disk_id, sector); - index = grub_disk_cache_get_index (dev_id, disk_id, sector); cache = grub_disk_cache_table + index; + + cache->lock = 1; + grub_free (cache->da

Re: Leak fixes

2009-03-22 Thread Robert Millan
On Sun, Mar 22, 2009 at 02:09:52PM +0100, phcoder wrote: > > - grub_disk_cache_invalidate (dev_id, disk_id, sector); > - >index = grub_disk_cache_get_index (dev_id, disk_id, sector); >cache = grub_disk_cache_table + index; > + > + cache->lock = 1; > + grub_free (cache->data); > +

Re: Move loader.c out of the kernel

2009-03-22 Thread phcoder
Yoshinori K. Okuji wrote: On Sunday 22 March 2009 22:06:36 phcoder wrote: Yoshinori K. Okuji wrote: On Sunday 22 March 2009 21:48:21 phcoder wrote: Hello. Now when boot command isn't in kernel anymore I don't see why loader.c stays in kernel. Here is the patch to move it to boot.mod This is n

Re: Migrating to GRUB 2 in Debian (Re: Interesting GSoC project ideas for 09)

2009-03-22 Thread phcoder
Yoshinori K. Okuji wrote: On Sunday 22 March 2009 19:48:36 phcoder wrote: Hello, I agree that non-sector aligned writes should be handled correctly. However I disagree with removing of the magic number. I personally would prefer if this file would have magic number and checksum. AFAIK currently

Re: Move loader.c out of the kernel

2009-03-22 Thread Yoshinori K. Okuji
On Sunday 22 March 2009 22:06:36 phcoder wrote: > Yoshinori K. Okuji wrote: > > On Sunday 22 March 2009 21:48:21 phcoder wrote: > >> Hello. Now when boot command isn't in kernel anymore I don't see why > >> loader.c stays in kernel. Here is the patch to move it to boot.mod > > > > This is not usefu

Re: Migrating to GRUB 2 in Debian (Re: Interesting GSoC project ideas for 09)

2009-03-22 Thread Yoshinori K. Okuji
On Sunday 22 March 2009 19:48:36 phcoder wrote: > Hello, I agree that non-sector aligned writes should be handled > correctly. However I disagree with removing of the magic number. I > personally would prefer if this file would have magic number and > checksum. AFAIK currently grub2 doesn't write t

Re: Leak fixes

2009-03-22 Thread phcoder
Rediffed 2009-03-22 Vladimir Serbinenko Leak fixes * kern/disk.c (grub_disk_cache_store): Invalidate previous cache in case of collision * disk/scsi.c (grub_scsi_open): free scsi in case of error phcoder wrote: Hello I discovered some memory leaks. Here is the fix T

Re: Move loader.c out of the kernel

2009-03-22 Thread phcoder
Yoshinori K. Okuji wrote: On Sunday 22 March 2009 21:48:21 phcoder wrote: Hello. Now when boot command isn't in kernel anymore I don't see why loader.c stays in kernel. Here is the patch to move it to boot.mod This is not useful in reality, because the loader interface needs to be pre-loaded

Re: Move loader.c out of the kernel

2009-03-22 Thread Yoshinori K. Okuji
On Sunday 22 March 2009 21:48:21 phcoder wrote: > Hello. Now when boot command isn't in kernel anymore I don't see why > loader.c stays in kernel. Here is the patch to move it to boot.mod This is not useful in reality, because the loader interface needs to be pre-loaded into core.img anyway. Note

Re: Migrating to GRUB 2 in Debian (Re: Interesting GSoC project ideas for 09)

2009-03-22 Thread Yoshinori K. Okuji
On Sunday 22 March 2009 21:29:23 Robert Millan wrote: > On Sun, Mar 22, 2009 at 04:01:35PM +0900, Yoshinori K. Okuji wrote: > > I will work towards this direction. I will first fix up the sector > > handling and change the format to plain text. Naming changes are quite > > trivial, so they can be d

Move loader.c out of the kernel

2009-03-22 Thread phcoder
Hello. Now when boot command isn't in kernel anymore I don't see why loader.c stays in kernel. Here is the patch to move it to boot.mod 2009-03-22 Vladimir Serbinenko Move loader out of the kernel * kern/loader.c: moved to ... * commands/boot.c: ... moved here

Re: [Patch] Move multiboot helpers out of the kernel

2009-03-22 Thread Robert Millan
Committed. On Sun, Mar 22, 2009 at 01:15:03AM +0100, phcoder wrote: > Fixed. I temporarily left grub_stop_floppy in linux code. > 2009-03-22 Vladimir Serbinenko > > Move multiboot helper out of kernel > > * conf/i386-pc.rmk (multiboot_mod_SOURCES): Add > loader/i386/multiboot_helpe

Re: Migrating to GRUB 2 in Debian (Re: Interesting GSoC project ideas for 09)

2009-03-22 Thread Robert Millan
On Sun, Mar 22, 2009 at 04:01:35PM +0900, Yoshinori K. Okuji wrote: > > I will work towards this direction. I will first fix up the sector handling > and change the format to plain text. Naming changes are quite trivial, so > they can be done later. I notice some changes went in for the new imp

Re: GRUB device names wrt. ieee1275

2009-03-22 Thread Robert Millan
On Sun, Mar 22, 2009 at 01:41:52AM +0100, phcoder wrote: > I don't see why > sth like > (/p...@1e\,60/p...@0/p...@9/p...@0/s...@1/d...@0,1) > is a problem. FWIW, I like this much better than replacing our comma separator with something else, thereby making GRUB inconsistent among platforms.

Re: Migrating to GRUB 2 in Debian (Re: Interesting GSoC project ideas for 09)

2009-03-22 Thread phcoder
Hello, I agree that non-sector aligned writes should be handled correctly. However I disagree with removing of the magic number. I personally would prefer if this file would have magic number and checksum. AFAIK currently grub2 doesn't write to FS except in load_env/save_env so a bug in code ca

Re: Migrating to GRUB 2 in Debian (Re: Interesting GSoC project ideas for 09)

2009-03-22 Thread Yoshinori K. Okuji
On Sunday 15 March 2009 14:52:05 Bean wrote: > On Sun, Mar 15, 2009 at 5:10 AM, Yoshinori K. Okuji wrote: > > On Friday 13 March 2009 21:23:19 phcoder wrote: > >> Look at load_env/save_env commands and grub-editenv util > > > > Thanks. Now I really regret that I didn't find those additions earlier