Re: __FILE__ (Re: [PATCH] framework for building modules externally)

2008-11-06 Thread Christian Franke
Robert Millan wrote: On Wed, Nov 05, 2008 at 10:41:20PM +0100, Christian Franke wrote: PS: The current use of __FILE__ may also add extra unexpected size: For packaging, configure is often run outside of $srcdir with a absolute path name. This may result in long __FILE__ strings, like /home

Re: [PATCH] framework for building modules externally

2008-11-06 Thread Christian Franke
Robert Millan wrote: On Wed, Nov 05, 2008 at 10:41:20PM +0100, Christian Franke wrote: Then, a module author has the option to check the ABI version by importing this symbol (possibly by simply adding '-u grub_abi_VERSION' to ld command) How would the whole picture look like? Sounds

Re: PPC64 mlongcall gcc flag

2008-11-06 Thread Manoel
Humm..we should do something to prevent memory to be allocated above 32mb (actually things can be above 32mb...but they cant be at a large offset since the PowerPC branch instruction works with offsets not absolute address). The thing is I was able to load the modules in P6 by changing the link

Re: Multiboot2 header

2008-11-06 Thread Yoshinori K. Okuji
On Tuesday 04 November 2008 21:36:27 Robert Millan wrote: > The Multiboot2 draft says a Multiboot2 header must be included in the OS > image. However, our code assumes (in code itself and in comments) that for > MB2 this is optional. > > As a consequence, if you feed GRUB's multiboot loader any EL

Re: [PATCH] terminal split

2008-11-06 Thread Yoshinori K. Okuji
On Tuesday 04 November 2008 19:31:09 Vesa Jääskeläinen wrote: > Yoshinori K. Okuji wrote: > > BTW, I would like to obtain the capability of handling pipes, so that we > > can, say, "help | more". I guess you have the same idea in your mind. > > This should be trivial, once the input and output are

Re: [PATCH] terminal split

2008-11-06 Thread Yoshinori K. Okuji
On Tuesday 04 November 2008 18:14:17 Robert Millan wrote: > On Tue, Nov 04, 2008 at 04:52:20PM +0100, Yoshinori K. Okuji wrote: > > No ChangeLog? > > Here. I ommitted it because I wanted to see if it would need big > adjustments first. OK. The patch looks perfect for me. > > BTW, I would like to

RE: [PATCH] PCI serial card support

2008-11-06 Thread Dugger, Donald D
Hmm, I just realized that the word `either' is interesting, it could mean that the intent was to use either v2 or v3 and the v3 part got dropped by mistake. I'll ask for a clarification on the LKML to see for sure. -- Don Dugger "Censeo Toto nos in Kansa esse decisse." - D. Gale [EMAIL PROTECTED]

RE: [PATCH] PCI serial card support

2008-11-06 Thread Dugger, Donald D
To quote from the driver, `drivers/serial/8250_pci.c': /* * linux/drivers/char/8250_pci.c * * Probe module for 8250/16550-type PCI serial ports. * * Based on drivers/char/serial.c, by Linus Torvalds, Theodore Ts'o. * * Copyright (C) 2001 Russell King, All Rights Reserved. * * This pro

Re: [PATCH] PCI serial card support

2008-11-06 Thread Robert Millan
On Thu, Nov 06, 2008 at 07:28:57AM -0800, Dugger, Donald D wrote: > The Linux driver has over 600 > lines of customized code for over 100 different devices > to do this task. Trying to duplicate that code from > scratch is rather unfeasible. Before we continue, did you check if that code in parti

RE: [PATCH] PCI serial card support

2008-11-06 Thread Dugger, Donald D
Bummer, I forgot about v2 vs. v3. This means we have a significant problem. I can create a table to do the base baud mapping without too much difficulty, there are only about 153 non-standard devices to worry about, it wouldn't be that hard to create a table for these devices. Automatically tryi

Re: PPC64 mlongcall gcc flag

2008-11-06 Thread Robert Millan
On Wed, Nov 05, 2008 at 11:25:15AM -0600, Hollis Blanchard wrote: > > Module memory is allocated by grub_malloc(), but as you can see at > http://svn.savannah.gnu.org/viewvc/trunk/grub2/kern/ieee1275/init.c?revision=1806&root=grub&view=markup > the GRUB heap capped at 4MB (I don't mean size, I me

Re: [PATCH] PCI serial card support

2008-11-06 Thread Robert Millan
On Wed, Nov 05, 2008 at 07:37:50AM -0800, Dugger, Donald D wrote: > > Hmmm, this is getting a litte more complex than I had hoped but > so be it. The problem is that to do this you need more than just > a PCI ID to base_baud map, now you have to be able to enumerate > serial devices, both multi-p

Re: [PATCH] framework for building modules externally

2008-11-06 Thread Robert Millan
On Wed, Nov 05, 2008 at 10:41:20PM +0100, Christian Franke wrote: > > Then, a module author has the option to check the ABI version by > importing this symbol > (possibly by simply adding '-u grub_abi_VERSION' to ld command) How would the whole picture look like? Sounds like it'd mean less comp

__FILE__ (Re: [PATCH] framework for building modules externally)

2008-11-06 Thread Robert Millan
On Wed, Nov 05, 2008 at 10:41:20PM +0100, Christian Franke wrote: > > PS: The current use of __FILE__ may also add extra unexpected size: For > packaging, configure is often run outside of $srcdir with a absolute > path name. This may result in long __FILE__ strings, like > /home/maintainer/pack