Re: [PATCH] fix disk->id abuse

2008-09-01 Thread Pavel Roskin
On Sun, 2008-08-31 at 15:33 +0200, Robert Millan wrote: > On Sat, Aug 30, 2008 at 11:41:18AM -0400, Pavel Roskin wrote: > > Quoting Robert Millan <[EMAIL PROTECTED]>: > > > > >So this patch means to solve both issues; makes single-disk drivers use a > > >constant directly (since a pointer to stri

Re: [PATCH] Grub2 cannot find LVM volume groups with a dash (-) in the name

2008-09-01 Thread Felix Zielcke
Am Dienstag, den 02.09.2008, 00:14 +0200 schrieb Robert Millan: > On Mon, Aug 18, 2008 at 05:05:26PM +0200, Felix Zielcke wrote: > > + unsigned char i, j, k, l; > > I think using unsigned chars to store "integers" is counter-intuitive, and in > some cases possibly dangerous (overflow). I should

Re: [PATCH] Grub2 cannot find LVM volume groups with a dash (-) in the name

2008-09-01 Thread Robert Millan
On Mon, Aug 18, 2008 at 05:05:26PM +0200, Felix Zielcke wrote: > + unsigned char i, j, k, l; I think using unsigned chars to store "integers" is counter-intuitive, and in some cases possibly dangerous (overflow). > + grub_dev = xmalloc (strlen (os_dev) - strlen ("/dev/mapper/") + 1); > +

Re: [PATCH] new static const char[] channel (was: modname)

2008-09-01 Thread Robert Millan
On Mon, Sep 01, 2008 at 01:24:16PM +0200, Felix Zielcke wrote: > Am Samstag, den 30.08.2008, 14:42 +0200 schrieb Robert Millan: > > > > > grub_dprintf itself refers to that as "condition". I'd personally prefer > > "channel" though. What do others think? > > I used now just channel, if others

Re: Crypto Patch: Legal Issues

2008-09-01 Thread Robert Millan
Marco, I think you're the only one who can take care of this. Please could you have a look? On Mon, Sep 01, 2008 at 05:26:46PM +0200, Simon Peter wrote: > > >> In the meantime, I've assigned copyright of my work (excluding the > > >> AES and RIPEMD implementations) to the FSF. The documents are

Re: [PATCH] GSoC #02 Minor tweak: Comment fix.

2008-09-01 Thread Vesa Jääskeläinen
Colin D Bennett wrote: > One-liner: Fix an incorrect comment in include/grub/normal.h for > GRUB_COMMAND_FLAG_NO_ARG_PARSE. The incorrect comment appears to have > been a copy-and-paste error. Thanks. Committed. ___ Grub-devel mailing list Grub-devel

[PATCH] GSoC #12 videotest enhancements

2008-09-01 Thread Colin D Bennett
This patch adds a number of different tests to the 'videotest' command, including a benchmark test that tabulates the performance results for various video modes and graphics operations. The tests are accessed by specifying the name as an argument, such as: videotest bench Also, most tests sup

Re: Windows,grub and grub2

2008-09-01 Thread Viswesh S
- Original Message From: Bean <[EMAIL PROTECTED]> To: The development of GRUB 2 Sent: Monday, 1 September, 2008 9:05:48 PM Subject: Re: Windows,grub and grub2 On Mon, Sep 1, 2008 at 11:27 PM, Viswesh S <[EMAIL PROTECTED]> wrote: > > Hi, Perhaps you can upload the boot sector file ?

Re: [PATCH] GSoC #08 [v3] vbeinfo enhancements

2008-09-01 Thread Vesa Jääskeläinen
Colin D Bennett wrote: > This refinement is against current SVN head. It introduces the VBE > mode info field constant values into vbe.h and these are used instead > of the magic numbers in vbeinfo.c. Thanks! Commited with modified changelog entry. Check what I changed. ___

Re: Windows,grub and grub2

2008-09-01 Thread Bean
On Mon, Sep 1, 2008 at 11:27 PM, Viswesh S <[EMAIL PROTECTED]> wrote: > > > - Original Message > From: Bean <[EMAIL PROTECTED]> > To: The development of GRUB 2 > Sent: Monday, 1 September, 2008 8:05:29 PM > Subject: Re: Windows,grub and grub2 > > > Hi, > > Perhaps you can dump the biosdis

Re: Crypto Patch: Legal Issues

2008-09-01 Thread Simon Peter
> >> In the meantime, I've assigned copyright of my work (excluding the > >> AES and RIPEMD implementations) to the FSF. The documents are > >> probably already waiting in my mailbox at home. I'll get the > >> signing done once I'm back home at the end of this month. > > I assume that I shall need

Re: Windows,grub and grub2

2008-09-01 Thread Viswesh S
- Original Message From: Bean <[EMAIL PROTECTED]> To: The development of GRUB 2 Sent: Monday, 1 September, 2008 8:05:29 PM Subject: Re: Windows,grub and grub2 Hi, Perhaps you can dump the biosdisk information as well #include ... struct grub_biosdisk_data *data = (struct grub_b

Re: Windows,grub and grub2

2008-09-01 Thread Bean
On Mon, Sep 1, 2008 at 9:53 PM, Viswesh S <[EMAIL PROTECTED]> wrote: > > > - Original Message > From: Bean <[EMAIL PROTECTED]> > To: The development of GRUB 2 > Sent: Monday, 1 September, 2008 6:32:28 PM > Subject: Re: Windows,grub and grub2 > > On Mon, Sep 1, 2008 at 6:48 PM, Viswesh S <

Re: Hiddenmenu for grub2

2008-09-01 Thread Niko Cavallini Araya
A little amend: On Sun, Aug 31, 2008 at 6:13 PM, Niko Cavallini Araya <[EMAIL PROTECTED]> wrote: > echo -n "Press ESC to enter the menu... " > if sleep --verbose --interruptible ${GRUB_TIMEOUT} ; then > set timeout=${GRUB_TIMEOUT} > else > set timeout=-1 > fi should be: > echo -n "Press ESC to

Re: Windows,grub and grub2

2008-09-01 Thread Viswesh S
- Original Message From: Bean <[EMAIL PROTECTED]> To: The development of GRUB 2 Sent: Monday, 1 September, 2008 6:32:28 PM Subject: Re: Windows,grub and grub2 On Mon, Sep 1, 2008 at 6:48 PM, Viswesh S <[EMAIL PROTECTED]> wrote: > > Hi, I doubt that this is caused by int 13, as grub

Re: Windows,grub and grub2

2008-09-01 Thread Bean
On Mon, Sep 1, 2008 at 9:37 PM, Viswesh S <[EMAIL PROTECTED]> wrote: > > > - Original Message > From: Bean <[EMAIL PROTECTED]> > To: The development of GRUB 2 > Sent: Monday, 1 September, 2008 6:32:28 PM > Subject: Re: Windows,grub and grub2 > > On Mon, Sep 1, 2008 at 6:48 PM, Viswesh S <

Re: Windows,grub and grub2

2008-09-01 Thread Viswesh S
  - Original Message From: Bean <[EMAIL PROTECTED]> To: The development of GRUB 2 Sent: Monday, 1 September, 2008 6:32:28 PM Subject: Re: Windows,grub and grub2 On Mon, Sep 1, 2008 at 6:48 PM, Viswesh S <[EMAIL PROTECTED]> wrote: > > Hi, I doubt that this is caused by int 13, as grub2

[PATCH] bug fix for ata.c and scsi.c

2008-09-01 Thread Bean
Hi, 2008-09-01 Bean <[EMAIL PROTECTED]> * disk/ata.c (grub_apapi_open): Initialize devfnd, no need to set scsi->name and scsi->luns, as they will be set in grub_scsi_open. * disk/scsi.c (grub_scsi_open): Don't call p->close (scsi) here when error occurs, as grub

Re: Windows,grub and grub2

2008-09-01 Thread Bean
On Mon, Sep 1, 2008 at 6:48 PM, Viswesh S <[EMAIL PROTECTED]> wrote: > > > - Original Message > From: Bean <[EMAIL PROTECTED]> > To: The development of GRUB 2 > Sent: Monday, 1 September, 2008 3:46:32 PM > Subject: Re: Windows,grub and grub2 > > On Mon, Sep 1, 2008 at 5:08 PM, Viswesh S <

Re: Windows,grub and grub2

2008-09-01 Thread Viswesh S
- Original Message From: Bean <[EMAIL PROTECTED]> To: The development of GRUB 2 Sent: Monday, 1 September, 2008 3:46:32 PM Subject: Re: Windows,grub and grub2 On Mon, Sep 1, 2008 at 5:08 PM, Viswesh S <[EMAIL PROTECTED]> wrote: > > Hi, Do you mean the result is still the same after

Re: Windows,grub and grub2

2008-09-01 Thread Bean
On Mon, Sep 1, 2008 at 5:08 PM, Viswesh S <[EMAIL PROTECTED]> wrote: > > > - Original Message > From: Bean <[EMAIL PROTECTED]> > To: The development of GRUB 2 > Sent: Saturday, 30 August, 2008 11:01:18 AM > Subject: Re: Windows,grub and grub2 > >> Hi, >> >> I thinks it's caused by partiti

Re: Windows,grub and grub2

2008-09-01 Thread Viswesh S
- Original Message From: Bean <[EMAIL PROTECTED]> To: The development of GRUB 2 Sent: Saturday, 30 August, 2008 11:01:18 AM Subject: Re: Windows,grub and grub2 > Hi, > > I thinks it's caused by partition entry pointer %esi which isn't > correct in grub2, please see if this patch fixe

Re: [PATCH] Grub2 cannot find LVM volume groups with a dash (-) in the name

2008-09-01 Thread Felix Zielcke
Am Montag, den 18.08.2008, 17:16 +0200 schrieb Felix Zielcke: > Well attached is now the right one. I want to bring the topic up again, so that this hopefully, so that this hopefully won't get forgotten for a while again. I have just noticed that we have a regression in our new debian experiment