Re: [PATCH] PXE support for grub2

2008-08-01 Thread Bean
On Sat, Aug 2, 2008 at 12:59 AM, Bean <[EMAIL PROTECTED]> > Hi, > > This kind of usage have been around for some time. In grub legacy, it > generates pxe image by catenating pxeloader and pre_stage2. > pxeboot.img is basiclly identical to pxeloader.S, and pre_stage2 and > core.img loaded at the sam

[PATCH] Fix color problem the grub-emu

2008-08-01 Thread Bean
Hi, Currently, the color handling in grub-emu is broken, sometimes you see nothing on screen. This patch fix it, now variable menu_color_normal and menu_color_highlight works properly in grub-emu. 2008-08-02 Bean <[EMAIL PROTECTED]> * util/console.c (grub_console_cur_color): New variab

Re: "Out of Partition" error on XFS still occuring

2008-08-01 Thread Pavel Roskin
On Sun, 2008-07-27 at 18:21 +0800, Bean wrote: > This new patch avoids the warning message of xfs.c Thanks. Sorry for breaking it. -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-de

Re: loadee relocation (Re: loader modules jumping back to kernel)

2008-08-01 Thread Robert Millan
On Fri, Aug 01, 2008 at 06:16:06PM +0200, Robert Millan wrote: > On Fri, Aug 01, 2008 at 01:45:30AM +0200, Robert Millan wrote: > > > > - What to do about physical_entry_addr now? My patch currently discards > > it, which I suppose is not what we want. > > Fixed after some discussion with

Re: [PATCH] Add support for /dev/md/N style mdraid devices

2008-08-01 Thread Felix Zielcke
Am Freitag, den 01.08.2008, 17:09 +0200 schrieb Felix Zielcke: > Maybe there's a way to make it even better so please comment all of you > grub-devels :) Thanks to Robert who suggested asprintf I hope the #define _GNU_SOURCE which is needed for it isn't a problem, you use anyway gcc specific ext

Re: [PATCH] PXE support for grub2

2008-08-01 Thread Bean
On Sat, Aug 2, 2008 at 12:21 AM, Pavel Roskin <[EMAIL PROTECTED]> wrote: > On Fri, 2008-08-01 at 13:32 +0200, Robert Millan wrote: >> On Thu, Jul 31, 2008 at 11:52:43PM -0400, Pavel Roskin wrote: >> > On Fri, 2008-08-01 at 11:46 +0800, Bean wrote: >> > > On Thu, Jul 31, 2008 at 12:50 AM, Bean <[EMA

Re: two bugs in configfile parser

2008-08-01 Thread Bean
On Fri, Aug 1, 2008 at 7:44 AM, Patrick Georgi <[EMAIL PROTECTED]> wrote: > Hi, > > given the following grub.cfg (simplified test case): > > menuentry "test" { > if test "a" = "a" ; then > echo foo > fi > } > > I have some issues. To reproduce, load grub with that file, enter the editor > on the m

Re: [PATCH] PXE support for grub2

2008-08-01 Thread Pavel Roskin
On Fri, 2008-08-01 at 13:32 +0200, Robert Millan wrote: > On Thu, Jul 31, 2008 at 11:52:43PM -0400, Pavel Roskin wrote: > > On Fri, 2008-08-01 at 11:46 +0800, Bean wrote: > > > On Thu, Jul 31, 2008 at 12:50 AM, Bean <[EMAIL PROTECTED]> wrote: > > > > Hi, > > > > > > > > This patch add the (pxe) dev

Re: loadee relocation (Re: loader modules jumping back to kernel)

2008-08-01 Thread Robert Millan
On Fri, Aug 01, 2008 at 01:45:30AM +0200, Robert Millan wrote: > > - What to do about physical_entry_addr now? My patch currently discards > it, which I suppose is not what we want. Fixed after some discussion with Bean on IRC. This version of the patch should handle physical_entry_addr f

Re: rename grub to grub-legacy ?

2008-08-01 Thread Robert Millan
On Fri, Aug 01, 2008 at 05:09:41PM +0200, Marco Gerards wrote: > Hi, > > Robert Millan <[EMAIL PROTECTED]> writes: > > > What would you think of renaming grub to grub-legacy in SVN ? > > > > I think it'd help send a strong message that we consider this a legacy > > branch > > and is not open for

Re: [PATCH] show an error instead of segfaulting on grub-probe -t partmap on a unsynced raid

2008-08-01 Thread Felix Zielcke
Am Freitag, den 01.08.2008, 15:36 +0200 schrieb Robert Millan: > The existing code is confusing. What is total_devs for? If we need to > iterate up to 32, sounds like this variable is pointless? > > If it's useless, it should be removed (but maybe it isn't!). > total_devs is a fast check if t

Re: slight oddity in script parser

2008-08-01 Thread Marco Gerards
Hi, Bean <[EMAIL PROTECTED]> writes: > On Fri, Aug 1, 2008 at 6:32 PM, Marco Gerards <[EMAIL PROTECTED]> wrote: >> Hi, >> >> Bean <[EMAIL PROTECTED]> writes: >> >>> Perhaps we should use automatic tool to generate the lexer, like using >>> bison for the parser. But I recall that Marco encounter s

RE: rename grub to grub-legacy ?

2008-08-01 Thread Gregg C Levine
Hello! I agree! Every time someone asks a question on the regular list I include that as part of my statement. I can't begin to explain how many times people have over reacted over the idea that what seems to them to be a brand new boot loader is already an old one who's reached that status. -- Gr

Re: [PATCH] Add support for /dev/md/N style mdraid devices

2008-08-01 Thread Felix Zielcke
Am Freitag, den 01.08.2008, 15:12 +0200 schrieb Robert Millan: > This looks fine, but I'd suggest to avoid hardcoding numbers when possible. > So > if you're adding 5 because that's the size of "/dev/", I think it's a good > idea > to use sizeof("/dev/")-1, and so on. This way the code is much

Re: rename grub to grub-legacy ?

2008-08-01 Thread Marco Gerards
Hi, Robert Millan <[EMAIL PROTECTED]> writes: > What would you think of renaming grub to grub-legacy in SVN ? > > I think it'd help send a strong message that we consider this a legacy branch > and is not open for further development. This is fine for me. Can you do this assuming Okuji and othe

rename grub to grub-legacy ?

2008-08-01 Thread Robert Millan
Hi, What would you think of renaming grub to grub-legacy in SVN ? I think it'd help send a strong message that we consider this a legacy branch and is not open for further development. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may

Re: slight oddity in script parser

2008-08-01 Thread Patrick Georgi
Robert Millan schrieb: If it's just to support \ in comments, I think it's not worth the hassle to implement and later debug any problems it creates. There's also the "comments that don't start at the beginning of the line" thing, and it might be that one of the issues in my other mail (leading

Re: slight oddity in script parser

2008-08-01 Thread Robert Millan
On Fri, Aug 01, 2008 at 12:34:20PM +0800, Bean wrote: > > Hi, > > In theory, it should be handled by the lexer. but actually, it's not > so easy. lexer already has some issue, adding new handling would not > help. I'm not familiar with this part of GRUB. But based on what you say, I think befor

Re: [PATCH] show an error instead of segfaulting on grub-probe -t partmap on a unsynced raid

2008-08-01 Thread Robert Millan
On Wed, Jul 30, 2008 at 05:11:24PM +0200, Felix Zielcke wrote: > Index: disk/raid.c > === > --- disk/raid.c (Revision 1753) > +++ disk/raid.c (Arbeitskopie) > @@ -75,8 +75,10 @@ >grub_disk_memberlist_t list = NULL, tmp;

Re: [PATCH] Add support for /dev/md/N style mdraid devices

2008-08-01 Thread Robert Millan
On Wed, Jul 30, 2008 at 09:11:22PM +0200, Felix Zielcke wrote: > + else if (os_dev[7] == '/' && os_dev[8] >= '0' && os_dev[8] <= '9') > + { > + memcpy (grub_dev, os_dev + 5, 2); > + memcpy (grub_dev + 2, os_dev + 8, 5); > + grub_dev[7] = '\0'; > + } This looks fine,

Re: [PATCH] skip over invalid BSD partitions

2008-08-01 Thread Robert Millan
On Fri, Aug 01, 2008 at 12:40:17PM +0200, Marco Gerards wrote: > > - return grub_error (GRUB_ERR_BAD_PART_TABLE, > > - "no space for disk label"); > > - > > + { > > + grub_error (GRUB_ERR_BAD_PART_TABLE, > > +

Re: [PATCH] PXE support for grub2

2008-08-01 Thread Robert Millan
On Thu, Jul 31, 2008 at 11:52:43PM -0400, Pavel Roskin wrote: > On Fri, 2008-08-01 at 11:46 +0800, Bean wrote: > > On Thu, Jul 31, 2008 at 12:50 AM, Bean <[EMAIL PROTECTED]> wrote: > > > Hi, > > > > > > This patch add the (pxe) device that can be used to load files using > > > the pxe service. It a

Re: [PATCH] skip over invalid BSD partitions

2008-08-01 Thread Felix Zielcke
Am Freitag, den 01.08.2008, 12:40 +0200 schrieb Marco Gerards: > When does this occur? > That's the Debian bugreport for it: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=478238 It's very easy to reproduce. I never used any *BSD flavour just Linux so I even didn't know about these BSD subpar

Re: slight oddity in script parser

2008-08-01 Thread Bean
On Fri, Aug 1, 2008 at 6:32 PM, Marco Gerards <[EMAIL PROTECTED]> wrote: > Hi, > > Bean <[EMAIL PROTECTED]> writes: > >> Perhaps we should use automatic tool to generate the lexer, like using >> bison for the parser. But I recall that Marco encounter some issue >> with flex, but I can't remember wh

Re: [PATCH] skip over invalid BSD partitions

2008-08-01 Thread Marco Gerards
Felix Zielcke <[EMAIL PROTECTED]> writes: > On invalid BSD partitions partmap/pc.c stops with reading the partitons, > so grub doestn't know anything about the ones behind it. > Attached patch fixes this and displays also the partition number not > only the invalid magic it encounters > > 2008-07-

Re: slight oddity in script parser

2008-08-01 Thread Marco Gerards
Hi, Bean <[EMAIL PROTECTED]> writes: > Perhaps we should use automatic tool to generate the lexer, like using > bison for the parser. But I recall that Marco encounter some issue > with flex, but I can't remember what it's now. You are right. I am not happy with the current lexer and would pref