Re: Endianness macros capitalization

2008-07-08 Thread Pavel Roskin
On Tue, 2008-07-08 at 20:04 +0200, Christian Franke wrote: > With old gcc versions without the "rol" optimization, even the 16 bit > swap should be a function: Or better yet, an asm statement. We should consider optimized assembly vs function call. Even the 32-bit swap could be shorter: a:

Re: a bug in read

2008-07-08 Thread Pavel Roskin
On Tue, 2008-07-08 at 00:18 +0200, Yoshinori K. Okuji wrote: > Hello, > > I have noticed that read.c has a bug. In this line: > > while ((line[i - 1] != '\n') && (line[i - 1] != '\r')) > > LINE is not initialized yet at the first time, so this refers to a > uninitialized location. Thank you!

Re: Endianness macros capitalization

2008-07-08 Thread Christian Franke
Christian Franke wrote: Assembly code for grub_swap_bytes16 from Debian gcc 4.1.2-7: Macro or Inline: 4 bytes (minus possible additional benefit from register level optimizations) 66 c1 c0 08 rol$0x8,%ax Function call: 11 bytes 0f b7 c0 movzwl %ax,%eax e8 xx xx xx xx

Re: [PATCH] New x86_64 EFI patch

2008-07-08 Thread Bean
On Wed, Jul 9, 2008 at 12:16 AM, Isaac Dupree <[EMAIL PROTECTED]> wrote: > Bean wrote: >> >> On Sun, Jul 6, 2008 at 7:02 AM, Isaac Dupree >> <[EMAIL PROTECTED]> wrote: >>> >>> Bean wrote: Hi, Perhaps you can also try the binary version at: http://grub4dos.sourceforge.n

Re: [PATCH] New x86_64 EFI patch

2008-07-08 Thread Isaac Dupree
Bean wrote: On Sun, Jul 6, 2008 at 7:02 AM, Isaac Dupree <[EMAIL PROTECTED]> wrote: Bean wrote: Hi, Perhaps you can also try the binary version at: http://grub4dos.sourceforge.net/grub2/grub.efi.1 A friend of mine have tested in in 32-bit EFI firmware, there is no problem for him. It confus

Junior developer switches to offline state

2008-07-08 Thread Javier Martín
...which is just a way of saying that I'm on vacation (yay! beach!) until at least Saturday and maybe July 22. So, I won't be able to answer any posts on the drivemap module (in fact, any posts at all, but drivemap is the only area in which I might be of any importante u_u). See you! signature.as