Re: [PATCH] implement menu_lock

2008-02-11 Thread Yoshinori K. Okuji
On Sunday 10 February 2008 21:59, Robert Millan wrote: > I didn't see this; it was inspired in the "lock" command in GRUB Legacy. > But since it only applies to menu, and doesn't lock anything else, I > thought "menu_lock" would be a good choice. > > Since our default state is not to lock the men

Re: Rename update-grub to grub-update?

2008-02-11 Thread Yoshinori K. Okuji
On Tuesday 12 February 2008 06:51, Pavel Roskin wrote: > Hello! > > All grub binaries installed in $prefix/bin and $prefix/sbin start with > "grub-" except mbchk and update-grub. mbchk is probably not meant to > be grub specific, but update-grub is. > > I think it would be logical to rename update

Re: [PATCH] to make grub2 compile on NetBSD

2008-02-11 Thread Yoshinori K. Okuji
On Monday 11 February 2008 23:44, walt wrote: > On Mon, 2008-02-04 at 16:56 +0100, Marco Gerards wrote: > > walt <[EMAIL PROTECTED]> writes: > > > NetBSD's gcc wants libgcc and libc to define __enable_execute_stack, > > > but this is useless for a free-standing executable like grub. Define > > > a

Rename update-grub to grub-update?

2008-02-11 Thread Pavel Roskin
Hello! All grub binaries installed in $prefix/bin and $prefix/sbin start with "grub-" except mbchk and update-grub. mbchk is probably not meant to be grub specific, but update-grub is. I think it would be logical to rename update-grub to grub-update. Objections? -- Regards, Pavel Roskin

Re: [PATCH] a.out support for multiboot and freebsd

2008-02-11 Thread Bean
On Feb 12, 2008 5:51 AM, walt <[EMAIL PROTECTED]> wrote: > > Any BSD kernel I try to load, including /boot/loader, gives me a 'free > magic broken' error. Same with 'multiboot netbsd'. > > A separate problem is that 'ls' will list the root directory of my > OpenBSD partition, but not any of the su

Re: [PATCH] to make grub2 compile on NetBSD

2008-02-11 Thread walt
On Mon, 2008-02-04 at 16:56 +0100, Marco Gerards wrote: walt <[EMAIL PROTECTED]> writes: > NetBSD's gcc wants libgcc and libc to define __enable_execute_stack, > but this is useless for a free-standing executable like grub. Define > a dummy function in lieu of libgcc to supply __enable_execute

Re: Generic halt and reboot commands (was: Re: grub2 efi patches)

2008-02-11 Thread Alexandre Boeglin
Le lun 11 fév 2008 à 15:11:44 +0100, Robert Millan a écrit : > No. See how other parts of GRUB do it. Ok, here's the patch. I also added 2008 to the copyright statement of modified files. Alex diff -ruNap -x CVS -x '*.lst' -x '*.mk' -x '.*' -x '*.d' -x '*.o' grub2_commit/commands/halt.c grub2_c

Re: [PATCH] a.out support for multiboot and freebsd

2008-02-11 Thread walt
On Tue, 2008-02-12 at 04:46 +0800, Bean wrote: > On Feb 12, 2008 4:45 AM, Bean <[EMAIL PROTECTED]> wrote: > > Hi, > > > > Change in this patch: > > > > 1. support OpenBSD kernel: > > > > set root=(hd0,3,a) > > openbsd /bsd > > > > The modules name is changed to bsd.mod. > > > > 2. Support setting

Re: [PATCH] a.out support for multiboot and freebsd

2008-02-11 Thread Bean
On Feb 12, 2008 5:28 AM, Robert Millan <[EMAIL PROTECTED]> wrote: > On Tue, Feb 12, 2008 at 04:46:31AM +0800, Bean wrote: > > +# For _freebsd.mod > > +_bsd_mod_SOURCES = loader/i386/pc/bsd.c > > You forgot to rename the commend ;-) oh, yes. > > > +_bsd_mod_CFLAGS = $(COMMON_CFLAGS) > > +_bsd_mod_

Re: [PATCH] a.out support for multiboot and freebsd

2008-02-11 Thread Robert Millan
On Tue, Feb 12, 2008 at 04:46:31AM +0800, Bean wrote: > +# For _freebsd.mod > +_bsd_mod_SOURCES = loader/i386/pc/bsd.c You forgot to rename the commend ;-) > +_bsd_mod_CFLAGS = $(COMMON_CFLAGS) > +_bsd_mod_LDFLAGS = $(COMMON_LDFLAGS) > + > +# For freebsd.mod > +bsd_mod_SOURCES = loader/i386/pc/bs

Re: [PATCH] a.out support for multiboot and freebsd

2008-02-11 Thread Bean
On Feb 12, 2008 4:45 AM, Bean <[EMAIL PROTECTED]> wrote: > Hi, > > Change in this patch: > > 1. support OpenBSD kernel: > > set root=(hd0,3,a) > openbsd /bsd > > The modules name is changed to bsd.mod. > > 2. Support setting kernel flags > > one character represent one flag, for FreeBSD, it's "DhaC

Re: [PATCH] a.out support for multiboot and freebsd

2008-02-11 Thread Bean
Hi, Change in this patch: 1. support OpenBSD kernel: set root=(hd0,3,a) openbsd /bsd The modules name is changed to bsd.mod. 2. Support setting kernel flags one character represent one flag, for FreeBSD, it's "DhaCcdgmnpqrsv", for OpenBSD, it's "abcsd". for example, to enable ask for root de

Re: [PATCH] improve error handling in util/

2008-02-11 Thread Robert Millan
On Mon, Feb 11, 2008 at 07:39:56PM +0100, Jan Nieuwenhuizen wrote: > Robert Millan: > > This improves error handling notably in util/. For example, from: > > > > $ ./grub-probe -t fs / > > grub-probe: error: cannot find a GRUB drive for /dev/sda1. > > Sorry, still get the constant error message.

Re: Docs

2008-02-11 Thread Franklin PIAT
Hi, Have you made progress regarding the re-licensing of the current grub manual under GFDL ? (with no cover text and no invariant ?) Franklin On Thu, 2008-01-31 at 15:34 +0100, Robert Millan wrote: > On Thu, Jan 31, 2008 at 02:43:59PM +0100, Yoshinori K. Okuji wrote: > > On Thursday 31 January

Re: [PATCH] improve error handling in util/

2008-02-11 Thread Jan Nieuwenhuizen
Robert Millan: > This improves error handling notably in util/. For example, from: > > $ ./grub-probe -t fs / > grub-probe: error: cannot find a GRUB drive for /dev/sda1. Sorry, still get the constant error message. $ ./grub-probe -t partmap /boot error: unknown device grub-probe: error: unknow

Re: [PATCH] Add option to grub-probe to accept system devices as arguments

2008-02-11 Thread Robert Millan
On Mon, Feb 11, 2008 at 04:48:26PM +0100, Fabian Greffrath wrote: > >Is there really a need to strdup() it? > > Yep. If you return the pointer (i.e. to `path') you'll get memory > corruption as soon as you try to free (device_name). You put that function in a separate file, which indicates it is

[PATCH] improve error handling in util/

2008-02-11 Thread Robert Millan
This improves error handling notably in util/. For example, from: $ ./grub-probe -t fs / grub-probe: error: cannot find a GRUB drive for /dev/sda1. to: $ ./grub-probe -t fs / error: cannot open `/dev/sda1' (Permission denied) grub-probe: error: cannot find a GRUB drive for /dev/sda1. -- Robe

Re: [PATCH] Add option to grub-probe to accept system devices as arguments

2008-02-11 Thread Fabian Greffrath
Hi Robert, You need to list every function or variable separately. [...] If you use the -p option to diff it'll be easier to check it just by reading the patch. OK, thanks, I didn't know this. Next time... ;) Is there really a need to strdup() it? Yep. If you return the pointer (i.e. to `

Re: [PATCH] Add option to grub-probe to accept system devices as arguments

2008-02-11 Thread Robert Millan
On Mon, Feb 11, 2008 at 09:53:15AM +0100, Fabian Greffrath wrote: > The following patch adds to grub-probe the ability to accept system devices > as > arguments and e.g. convert between system devices and GRUB drives. > > This patch is improved over the one from my previous posting and has some

Re: [PATCH] a.out support for multiboot and freebsd

2008-02-11 Thread Bean
On Feb 11, 2008 10:11 PM, walt <[EMAIL PROTECTED]> wrote: > Bean wrote: > > Hi, > > > > The following patch support freebsd a.out and elf, now you can load > > the kernel directly. > > > > 1. Boot through loader: > > > > set root=(hd0,0,a) > > freebsd /boot/loader > > > > It should be able to deduc

Re: Generic halt and reboot commands (was: Re: grub2 efi patches)

2008-02-11 Thread Robert Millan
On Sun, Feb 10, 2008 at 10:58:02PM +0100, Alexandre Boeglin wrote: > Le dim 10 fév 2008 à 22:05:46 +0100, Robert Millan a écrit : > > For consistency with similar code elsewhere in GRUB, I think it's better if > > you made this: > > > > #if defined(foo) > > #elif defined(bar) > > #endif > > No wh

Re: [PATCH] a.out support for multiboot and freebsd

2008-02-11 Thread walt
Bean wrote: Hi, The following patch support freebsd a.out and elf, now you can load the kernel directly. 1. Boot through loader: set root=(hd0,0,a) freebsd /boot/loader It should be able to deduce the root device from the root variable. I still see currdev=disk0s1c but that should be s1a, n

Re: [PATCH] fix for partmap detection on RAID/LVM

2008-02-11 Thread Robert Millan
On Mon, Feb 11, 2008 at 01:43:21PM +0100, Jan Nieuwenhuizen wrote: > Robert Millan writes: > > > This is only known to work on proof-of-concept test systems. *Please* > > anyone > > who was affected on real, production systems, test it (against latest CVS) > > and > > send feedback. The proble

Re: [PATCH] Use os-prober to detect other OSes during update-grub

2008-02-11 Thread Fabian Greffrath
I should not forget to say that this script *depends* on the patch I sent in for grub-probe in my previous mail. #! /bin/sh -e # update-grub helper script. # Copyright (C) 2006,2007,2008 Free Software Foundation, Inc. # # GRUB is free software: you can redistribute it and/or modify # it under

Re: IA64 port

2008-02-11 Thread tgingold
Quoting Alexandre Boeglin <[EMAIL PROTECTED]>: > Le mer 30 jan 2008 à 06:48:11 +0100, Tristan Gingold a écrit : > > * loader/ia64/efi/linux_normal.c: New file. > > * loader/ia64/efi/linux.c: New file. > > Hello, > > Wouldn't it be possible to merge these and the current loader/i386/efi/lin

[PATCH] Use os-prober to detect other OSes during update-grub

2008-02-11 Thread Fabian Greffrath
The following is a script that should be installed into `/etc/grub.d/os-prober'. It uses Debian's `os-prober' package (if installed) to detect other operating systems which are installed on the computer and add them to the boot menu. It's up to you to decide if this is too Debian-specific or if yo

[PATCH] Add option to grub-probe to accept system devices as arguments

2008-02-11 Thread Fabian Greffrath
The following patch adds to grub-probe the ability to accept system devices as arguments and e.g. convert between system devices and GRUB drives. This patch is improved over the one from my previous posting and has some minor issues fixed. Please use this version instead. It is all my work. ï