Re: Issue in cvs kern/elf.c

2007-04-18 Thread Jerone Young
This is an obvious problem. Thanks for finding it Pattrick! I will commit the fix today. On 4/18/07, Pattrick Hueper <[EMAIL PROTECTED]> wrote: Hi all, testing grub2 on a 64bit platform i found an issue in kern/elf.c method grub_elf64_load. There are parentheses missing after the compare of re

RE: GRUB 1.95 cannot read the ufs filesystem

2007-04-18 Thread Hitoshi Ozeki
Hello,all. I wrote in the last: At second, However we have the filepath in 'const char* path', The original code copies the filepath. It wastes the processor time. If you think the use of pointers makes complex, I recommend to use array and index. It does

Issue in cvs kern/elf.c

2007-04-18 Thread Pattrick Hueper
Hi all, testing grub2 on a 64bit platform i found an issue in kern/elf.c method grub_elf64_load. There are parentheses missing after the compare of read bytes and expected filesize causing the load to always fail with GRUB_ERR_BAD_OS. Here is the cvs patch that fixed the issue for me: Index: k

Re: GRUB 1.95 cannot read the ufs filesystem

2007-04-18 Thread Johan Rydberg
"Hitoshi Ozeki" <[EMAIL PROTECTED]> writes: > At first, When we use the 'strcmp' for the purpose of comparision C-strings, > It requires to terminate with the NIL sentry('\0'). > > begin--- > grub_ufs_find_file (struct grub_ufs_data *data, const char *path) > { >

Re: GRUB 1.95 cannot read the ufs filesystem

2007-04-18 Thread Johan Rydberg
"Hitoshi Ozeki" <[EMAIL PROTECTED]> writes: > At first, When we use the 'strcmp' for the purpose of comparision C-strings, > It requires to terminate with the NIL sentry('\0'). > > begin--- > grub_ufs_find_file (struct grub_ufs_data *data, const char *path) > { >