Re: problem in usage of grub_errno...

2005-12-19 Thread Vesa Jääskeläinen
Tomáš Ebenlendr wrote: >> Error stack is statically allocated and it is protected so that it >> cannot overflow. Error stack is defined as being static to file >> kern/err.c so there is no direct access possible to error stack. >> >> Error stack is emptied in grub_print_error function. (And this is

Re: problem in usage of grub_errno...

2005-12-19 Thread Vesa Jääskeläinen
Joel Buckley wrote: > There is a second bug though... > > A possible stack memory-leak is possible. Replace the > first line with the following to avoid the memory leak: > >if (grub_errno != GRUB_ERR_NONE) { > grub_error_push(); >} > > Otherwise, a useless push is done. Then you

Re: problem in usage of grub_errno...

2005-12-19 Thread Tomáš Ebenlendr
> Error stack is statically allocated and it is protected so that it > cannot overflow. Error stack is defined as being static to file > kern/err.c so there is no direct access possible to error stack. > > Error stack is emptied in grub_print_error function. (And this is called > before prompt is p