Re: [patch] set prefix on PPC

2005-02-23 Thread Hollis Blanchard
On Feb 21, 2005, at 1:01 PM, Marco Gerards wrote: +static void +grub_set_prefix (void) +{ + char bootpath[64]; /* XXX check length */ You could get the property length and use that. It would be clearer. All these stack-based get_property calls are an accident waiting to happen, but you've advoc

Re: [patch] set prefix on PPC

2005-02-23 Thread Hollis Blanchard
On Feb 20, 2005, at 11:50 AM, Marco Gerards wrote: If a user installs GRUB now with this bootargs patch, then later if we wish to add a debug option with "fancy parser" they will no longer be able to boot, as the syntax will change. Now: "boot grubof hd0,6" Later: "boot grubof prefix=hd0,6 debug=al

Re: [PATCH] dprintf implementation

2005-02-23 Thread Hollis Blanchard
On Feb 21, 2005, at 3:04 PM, Vincent Pelletier wrote: Here is the dprintf function I worked on 2 weeks ago, which I fixed this evening. Your mailer did some bad stuff to this patch again... Index: kern/misc.c === RCS file: /cvsroot/gr