Re: [PATCH v2] man*/: ffix (migrate to `MR`)

Hi Branden, On 2023-08-16 05:55, G. Branden Robinson wrote: [...] >> Would you mind sending an updated commit message? > > I did, but you found a fresh problem, this time with part 1, so I guess > we'll be going to v4! :-O Also I'm going to make an attempt to drive > the part 1 change with sed

Re: [PATCH v2] man*/: ffix (migrate to `MR`)

Hi Ingo! On 2023-08-16 18:33, Ingo Schwarze wrote: > That perspective is not really helpful for general purpose Linux > distributions: for these, the Linux man-pages project matters a lot, > and that project is not considering the man(7) language as obsolete at > all. That i keep recommending cha

linting mdoc(7) pages (was: [PATCH v2] man*/: ffix (migrate to `MR`))

Hi Ingo! On 2023-08-16 20:25, Alejandro Colomar wrote: > Hi Ingo! > > On 2023-08-16 18:33, Ingo Schwarze wrote: >> That perspective is not really helpful for general purpose Linux >> distributions: for these, the Linux man-pages project matters a lot, >> and that pro

process man(7) (or any other package of macros) without typesetting

Hi Branden, I've had this desire for a long time, and maybe now I have a strong reason to ask for it. In the usual groff pipeline, you have something like $ preconvfoo.1 >foo.1.tbl $ tbl foo.1.eqn $ eqn -Tutf8foo.1.man $ troff

Re: process man(7) (or any other package of macros) without typesetting

On 2023-08-17 21:12, Alejandro Colomar wrote: > Hi Branden, > > I've had this desire for a long time, and maybe now I have a strong > reason to ask for it. > > In the usual groff pipeline, you have something like > > $ preconvfoo.1

Re: groff features for hyperlinked man pages (was: No 6.05/.01 pdf book available)

Hi Branden, Deri, On 2023-08-15 02:50, G. Branden Robinson wrote: [...] > >>> I just re-read this, and am confused. '\-' is an ASCII character, >>> isn't it? In fact, all of the Linux man-pages pathnames are >>> composed exclusively of ASCII characters, aren't they? > > You're thinking about

Re: Proposed: change `pm` request argument semantics (was: process man(7) (or any other package of macros) without typesetting)

Hi Branden, Lennart, Doug, On 2023-08-18 01:44, G. Branden Robinson wrote: > In other words, you want to see what a *roff document looks like after > all macro expansions have been (recursively) performed. Exactly. Basically, I want an equivalent of cpp(1) for expanding man(7) macros. > > I w

'-' vs '\-' in TH (man(7))

Hi Branden, I just noticed that the Linux man-pages use '-' in TH. That's surprising to me, as Michael was careful to use '\-' correctly. In the documentation, I couldn't find anything that says TH should be different than anywhere else, and so I'd expect he would have used it there. $ grep -rn

Re: '-' vs '\-' in TH (man(7))

On 2023-08-20 23:51, Brian Inglis wrote: > On Sun, 20 Aug 2023 21:10:52 +0200, Alejandro Colomar wrote: >> Hi Branden, >> I just noticed that the Linux man-pages use '-' in TH. That's >> surprising to me, as Michael was careful to use '\-' corre

Re: groff in openSUSE

[CC += linux-man@ & groff@, as we're discussing packaging of both] Hi Michael! On 2023-08-25 14:05, Michael Vetter wrote: > Hi Alejandro! > >> Are you a SUSE maintainer? I'd like to know who is the maintainer of >> the groff(1) package in openSUSE. They released a new version a couple >> of mo

Re: [PATCH v1 1/2] [troff]: Add lengthof() macro.

Hi Branden! On 2023-08-26 00:28, G. Branden Robinson wrote: > Hi Alex, > > I didn't forget about this. > > At 2023-08-04T03:00:10+0200, Alejandro Colomar wrote: >> * src/roff/troff/env.cpp (lengthof): Add macro to calculate the number >>of elements in

Re: [PATCH v1 1/2] [troff]: Add lengthof() macro.

Hi Lennart, Branden, On 2023-08-26 21:36, Lennart Jablonka wrote: > Quoth Alejandro Colomar: >> The good news is that I like the implementation. I just don't like the >> name. I have a sizeof_array() macro that does >> >> #define sizeof_array(a) (sizeof(a) + mus

Re: [PATCH v1 1/2] [troff]: Add lengthof() macro.

Hi Lennart, On 2023-08-27 02:00, Alejandro Colomar wrote: > Hi Lennart, Branden, > > On 2023-08-26 21:36, Lennart Jablonka wrote: >> Quoth Alejandro Colomar: >>> The good news is that I like the implementation. I just don't like the >>> name. I

Re: groff features for hyperlinked man pages (was: No 6.05/.01 pdf book available)

Hi Branden, Sorry for the delay. I've been learning neomutt(1) and mbsync(1) recently, which took a lot of time from me. Now it all stabilized. Finally, I'm able to grep(1) my mail. :) On Fri, Aug 18, 2023 at 11:37:32PM -0500, G. Branden Robinson wrote: > > I'd expect that the hyperlinking abi

XREF in man(7)

Hi Branden, I've imported some archaic pages. Those pages used some ".XREF" after the TH and before SH NAME. They seem to be a duplication of the name, possibly for some weird software that wouldn't parse the name. Did you know about that thing? Cheers, Alex signature.asc Description: PGP si

Re: XREF in man(7)

On Tue, Oct 03, 2023 at 08:16:00PM +0200, Alejandro Colomar wrote: > Hi Branden, > > I've imported some archaic pages. Those pages used some ".XREF" after > the TH and before SH NAME. They seem to be a duplication of the name, > possibly for some weird softwar

Re: mandoc -man -Thtml bug: inconsistent vertical space before .TP

Hi Branden, On Mon, Oct 23, 2023 at 04:15:23AM -0500, G. Branden Robinson wrote: > [dropped t...@mandoc.bsd.lv from Cc; I'm not subscribed, so it > deep-sixes my mails] [Added groff@, to have some mailing list] > > At 2023-10-19T23:32:42+0200, Alejandro Colomar wrote: >

Re: mandoc -man -Thtml bug: inconsistent vertical space before .TP

Hi Branden, Ingo, On Mon, Oct 23, 2023 at 08:36:11AM -0500, G. Branden Robinson wrote: [...] > > What I think I'm convinced is that there's no perfect way of dealing > > with indentation in man(7). .TP/.RS/.RE might be the most consistent > > one. I just wish it didn't introduce a break after th

Re: mandoc -man -Thtml bug: inconsistent vertical space before .TP

On Tue, Oct 24, 2023 at 02:13:34AM +0200, Ingo Schwarze wrote: > Hi Alejandro, > > Alejandro Colomar wrote on Mon, Oct 23, 2023 at 04:30:58PM +0200: > > > This got me curious about TQ, since mandoc(1) considers it "very rarely > > used, even in GNU pages". >

Re: `\c`, mdoc(7), and man(7) extension macros (was: [PATCH 1/2] man*/: srcfix)

Hi Branden, On Thu, Oct 26, 2023 at 07:58:35AM -0500, G. Branden Robinson wrote: [...] > > And mdoc _does_ manage to make `\c` > almost(?) totally unnecessary--at the cost of a weighty internal > recursive macro reprocessing system that no other *roff package is known > to implement. > > (This i

Re: Why does man(7) have 3 paragraph macros for the same thing? (was: `\c`, mdoc(7), and man(7) extension macros)

Hi Branden, On Thu, Oct 26, 2023 at 09:51:40AM -0500, G. Branden Robinson wrote: > At 2023-10-26T16:12:36+0200, Alejandro Colomar wrote: > > Regarding PP, LP, and P, what's the history of them? Why do we have > > the 3? I'm willing to reduce them to just one. > >

Re: Why does man(7) have 3 paragraph macros for the same thing? (was: `\c`, mdoc(7), and man(7) extension macros)

Hi Branden, On Thu, Oct 26, 2023 at 11:09:23AM -0500, G. Branden Robinson wrote: > [self-correcting follow-up] > > At 2023-10-26T09:51:42-0500, G. Branden Robinson wrote: > > In ms(7), `LP` sets a paragraph that is left-aligned, and `PP` sets > > one with a first-line indentation. > > > > In man

Re: Why does man(7) have 3 paragraph macros for the same thing? (was: `\c`, mdoc(7), and man(7) extension macros)

Hi Branden, On Thu, Oct 26, 2023 at 10:28:13AM -0500, G. Branden Robinson wrote: > At 2023-10-26T16:58:13+0200, Alejandro Colomar wrote: > > On Thu, Oct 26, 2023 at 09:51:40AM -0500, G. Branden Robinson wrote: > > > At 2023-10-26T16:12:36+0200, Alejandro Colomar wrote: > &

Re: Why does man(7) have 3 paragraph macros for the same thing?

Hi Ingo, On Thu, Oct 26, 2023 at 07:52:13PM +0200, Ingo Schwarze wrote: > > I consider this a bikeshed discussion. Sure. But someone has to design the bike parkings. I find a lot awful bike parkings that harm bike's wheels, and have to park it in a sign or tree nearby. > > Given that Branden

Re: mandoc -man -Thtml bug: inconsistent vertical space before .TP

On Thu, Oct 26, 2023 at 06:37:58PM +0200, Ingo Schwarze wrote: > That is completely true, and my point 5 is completely bogus. This is > embarrassing, in particular since it also tainted the commit message. > I'm not completely sure how the wrong idea entered my head, possibly by > confusing .TP an

Re: `\c`, mdoc(7), and man(7) extension macros (was: [PATCH 1/2] man*/: srcfix)

Hi Ingo, [...ingoring the battle in which I don't want to participate...] [My position here is that man(7) has problems, but I fear that jumping to mdoc(7) *may* be worse; I can't know before jumping, which is a problem. Maybe if some pages are added written in mdoc(7), I get used to it and start

Re: mandoc -man -Thtml bug: inconsistent vertical space before .TP

On Sat, Oct 28, 2023 at 07:27:49AM -0500, G. Branden Robinson wrote: > At 2023-10-24T12:31:04+0200, Alejandro Colomar wrote: > > In less(1) I use similar heuristics to find what I want: '/--unused' > > will get me exactly where I expect. > > You might want to a

Re: `\c`, mdoc(7), and man(7) extension macros (was: [PATCH 1/2] man*/: srcfix)

Hi Branden, On Sat, Oct 28, 2023 at 08:21:59AM -0500, G. Branden Robinson wrote: > > Regarding PP, LP, and P, what's the history of them? Why do we have > > the 3? I'm willing to reduce them to just one. > > We covered this in another thread, but as Ingo noted, there is no hope > of actually _r

Re: mandoc -man -Thtml bug: inconsistent vertical space before .TP

On Sat, Oct 28, 2023 at 11:15:11AM -0500, G. Branden Robinson wrote: > Hi Alex, > > At 2023-10-28T17:55:50+0200, Alejandro Colomar wrote: > > On Sat, Oct 28, 2023 at 07:27:49AM -0500, G. Branden Robinson wrote: > > > At 2023-10-24T12:31:04+0200, Alejandro Colomar wrote:

Optimize script for generating LinuxManBook.pdf

sh #!/bin/sh # Copyright 2023, Alejandro Colomar # SPDX-License-Identifier: GPL-3.0-or-later ( "$(dirname "$0")"/prepare_linux_man_book.pl "$1" \ | groff -z -dPDF.EXPORT=1 -dLABEL.REFS=1 -dpaper=a4 -Tpdf -k -pet \ -M"$(dirname

Re: Optimize script for generating LinuxManBook.pdf

Hi Deri, On Wed, Nov 22, 2023 at 05:33:52PM +, Deri wrote: > Hi Alex, > > Is there a git address I can clone to see the changes "in the round” and give > it a go? Here's an unstable branch (I rebase often):

Re: Optimize script for generating LinuxManBook.pdf

Hi Deri, On Thu, Nov 23, 2023 at 06:41:14PM +, Deri wrote: > Hi Alex, > > It looks fine, although you have to run the code in > "prepare_linux_man_book.pl" twice (to avoid using a temporary file). Yep. I was wondering if we could change something in the design of prepare_linux_man_book.pl

Re: Optimize script for generating LinuxManBook.pdf

On Thu, Nov 23, 2023 at 11:12:45PM +0100, Alejandro Colomar wrote: > > It looks fine, although you have to run the code in > > "prepare_linux_man_book.pl" twice (to avoid using a temporary file). > > Yep. I was wondering if we could change something in the design of

Possibly incomplete bounds check after strtol(3)

Hi Branden, I see some code calling strtol(3) that I suspect won't behave well in some systems: $ grepc -tfd check_integer_arg . ./src/utils/indxbib/indxbib.cpp:static void check_integer_arg(char opt, const char *arg, int min, int *res) { char *ptr; long n = strtol(arg, &ptr, 10); if (n ==

[PATCH 1/4] [libgroff]: Remove redundant checks.

ERANGE can only happen if strtol(3) returns either LONG_MIN or LONG_MAX. Signed-off-by: Alejandro Colomar --- src/libs/libgroff/curtime.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/libs/libgroff/curtime.cpp b/src/libs/libgroff/curtime.cpp index 277755cab

[PATCH 2/4] [libgroff]: Remove dead code

strtol(3) can only report ERANGE, if the base is valid (and it is). Signed-off-by: Alejandro Colomar --- src/libs/libgroff/curtime.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libs/libgroff/curtime.cpp b/src/libs/libgroff/curtime.cpp index 490fc3018..4623ad9a0

[PATCH 4/4] [grolbp]: Remove bogus (and redundant) check

`str == end` can only happen if strtol(3) returns 0. Signed-off-by: Alejandro Colomar --- src/devices/grolbp/lbp.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/devices/grolbp/lbp.cpp b/src/devices/grolbp/lbp.cpp index 9b061f9ad..765bf6893 100644 --- a/src/devices

[PATCH 3/4] src/: Remove redundant checks after strtol(3).

`str == end` can only happen if strtol(3) returns 0. Signed-off-by: Alejandro Colomar --- src/devices/grodvi/dvi.cpp | 4 ++-- src/devices/grolbp/lbp.cpp | 2 +- src/devices/grolj4/lj4.cpp | 6 +++--- src/devices/grops/ps.cpp| 4 ++-- src/devices/grops/psrm.cpp | 2

xasprintf() NIH

Hi Branden, I just saw some function in groff that looks like gnulib's xasprintf(). You may want to just use that instead, or at least rename it to my_xasprintf() to be more clear about what it is. $ grepc -B8 make_string . ./src/preproc/html/pre-html.cpp-/* ./src/preproc/

troff -Tpdf: '.' in SS macro

Hi Branden! I'm improving the Linux man-pages build system, to add a 'distcheck' target, and have control over newly added warnings vs longstanding ones. I found that most output devices have warnings in the same pages, but here's one that I've only seen in -Tpdf. It might be a bug in -Tpdf.

[idea] troff -Troff

Hi Branden! I've been thinking about a suggestion I've done in the past. I wanted a program that reads man(7) source and produces roff(7) source, so that it can later be passed to troff(1), thus splitting the groff(1) pipeline a bit more. The idea is similar to how eqn(1) and other pre-troff fil

Re: troff -Tpdf: '.' in SS macro

Hi Branden, On Fri, Feb 16, 2024 at 09:15:07AM -0600, G. Branden Robinson wrote: > Hi Alex, > > At 2024-02-16T01:44:36+0100, Alejandro Colomar wrote: > Yes, I can reproduce this with groff 1.23.0 and Git HEAD. > > Try this patch. > > diff --git a/tmac/pdf.tmac b/tmac/pd

Re: [idea] troff -Troff

Hi Branden, On Fri, Feb 16, 2024 at 10:49:52AM -0600, G. Branden Robinson wrote: > Hi Alex, [...] > Right. I had a similar desire when I first came to groff development. [...] > It's not that it's a bad idea, it's that it's hard. > > Please excuse an excursion into parser theory, presented b

Re: How to crash the formatter with a dummy character (was: troff -Tpdf: '.' in SS macro)

Hi Branden, On Sat, Feb 17, 2024 at 11:23:11AM -0600, G. Branden Robinson wrote: > Hi Alex, > > I regret to ask you to work around this problem in Linux man-pages at > the man(7) document source level for the time being. I'll do. I'll have to add to my CV "uncoverer of ancient bugs". 0u0 Have

Version string with git(1) (-dirty)

Hi Branden, I notice that when I build groff(1) from source, it gets its version from git(1), and if the repository is dirty (has modifications on top of the last commit), the version string has a "-dirty" suffix. I was wondering how you get the version string, because I'd like to use that "-dirt

Re: Version string with git(1) (-dirty)

On Fri, Feb 23, 2024 at 03:20:58PM +0100, Alejandro Colomar wrote: > Hi Branden, > > I notice that when I build groff(1) from source, it gets its version > from git(1), and if the repository is dirty (has modifications on top of > the last commit), the version string has a "-d

special character 'mc' not defined

Hi Branden, I'm linting the Linux man-pages in a different computer, where I only have groff-1.23.0 installed from the Debian package, and I'm getting more warnings than in my everyday computer (where I have both 1.23.0 from Debian Sid, and groff from git HEAD built from source). System with only

Re: special character 'mc' not defined

Hi Branden, On Sun, Feb 25, 2024 at 03:01:42PM -0600, G. Branden Robinson wrote: > I suspect the problem is a matter of locale or selected output device. Hmmm, it was the locale. Which itself was due to SSH (the locale was set as C.utf8, but when SSHing it was POSIX). I set now LANG in .profile

Warnings in groff's manual pages

Hi Branden, I've been linting groff's manual pages, as of $ git describe 1.23.0-902-g1fce75f6b and got some warnings. You may want to have a look at them, just in case any of those is legit. Have a lovely day! Alex --- $ make -k --debug=print \ -C /home/alx/src/linu

Re: Warnings in groff's manual pages

Hi Branden, On Mon, Feb 26, 2024 at 04:25:53PM -0600, G. Branden Robinson wrote: > These are documented, expected, and relatively harmless. > > https://git.savannah.gnu.org/cgit/groff.git/tree/PROBLEMS#n959 Good. > > ! (troff -man -wbreak -Tutf8 -rLL=78n -rCHECKSTYLE=3 -ww > > &1 > > >/tmp/

Re: [PATCH] [grotrin] Add post-processor for groff input.

Hi Lennart, On Sun, Mar 10, 2024 at 12:13:34AM +, Lennart Jablonka wrote: > This is useless. And also not what Alejandro wanted, presumably. > > Suggested-By: Alejandro Colomar > --- > I don’t wanna wait for April 1st. Lol! It's not exactly what I wanted, but it&#x

Re: Possibly incomplete bounds check after strtol(3)

On Tue, Mar 12, 2024 at 05:05:31PM -0500, G. Branden Robinson wrote: > Hi Alex, > > I forgot about this; fortunately, Dave reminded me. Hi Branden! (Hi Dave!) > At 2024-01-14T20:19:18+0100, Alejandro Colomar wrote: > > I see some code calling strtol(3) that I suspect wo

Re: Possibly incomplete bounds check after strtol(3)

On Tue, Mar 12, 2024 at 11:22:32PM +0100, Alejandro Colomar wrote: > On Tue, Mar 12, 2024 at 05:05:31PM -0500, G. Branden Robinson wrote: > > Hi Alex, > > > > I forgot about this; fortunately, Dave reminded me. > > Hi Branden! (Hi Dave!) > > > At 2024-01

Re: Possibly incomplete bounds check after strtol(3)

On Wed, Mar 13, 2024 at 12:27:33AM +0100, Alejandro Colomar wrote: > On Tue, Mar 12, 2024 at 11:22:32PM +0100, Alejandro Colomar wrote: > > On Tue, Mar 12, 2024 at 05:05:31PM -0500, G. Branden Robinson wrote: > > > 147 case 'h': > > > 148 { > >

[PATCH] src/: ceil_prime(): Add function to get the lowest prime not smaller than n

And use it where the same logic was being open-coded. Cc: "G. Branden Robinson" Signed-off-by: Alejandro Colomar --- Hi Branden, Now this looks better. After this change, it seems to me more clear that using 1 as the minimum is fine, since it only results in a warning, and not i

[PATCH v2] src/: ceil_prime(): Add function to get the lowest prime not smaller than n

o the first prime, 2. Cc: "G. Branden Robinson" Signed-off-by: Alejandro Colomar --- Range-diff against v1: 1: 124bbe1ae ! 1: 9432f7f87 src/: ceil_prime(): Add function to get the lowest prime not smaller than n @@ Commit message And use it where the same logic was b

Re: [PATCH v2] src/: ceil_prime(): Add function to get the lowest prime not smaller than n

On Wed, Mar 13, 2024 at 05:45:10AM -0500, G. Branden Robinson wrote: > Hi Alex, Hi Branden, > At 2024-03-13T11:21:55+0100, Alejandro Colomar wrote: > > And use it where the same logic was being open-coded. > > > > While at it, fix the logic, which was incorrect in the o

Re: [PATCH v2] src/: ceil_prime(): Add function to get the lowest prime not smaller than n

Hi Branden, On Wed, Mar 13, 2024 at 05:46:38AM -0500, G. Branden Robinson wrote: > Forgot to attach my working copy, of course. You could have attached/inlined a diff; it would be smaller. :) > /* Copyright (C) 1989-2020 Free Software Foundation, Inc. > Written by James Clark (j...@jclark.

Re: [PATCH v2] src/: ceil_prime(): Add function to get the lowest prime not smaller than n

Hi Branden, On Wed, Mar 13, 2024 at 06:52:10AM -0500, G. Branden Robinson wrote: > Hi Alex, > > At 2024-03-13T12:01:32+0100, Alejandro Colomar wrote: > > I didn't write an exploit, as that would be a little bit more work > > (including learning what is indxbib at all

Unable to generate glyphs for chinese letters

Hi Deri, I've noticed another similar issue, this time with Chinese. I see chinese letters in the bookmarks, but they don't appear in the PDF body. If I read the manual page in the terminal, I do see them. When generating the PDF, I get a bunch of warnings about special characters not defined.

Re: Unable to generate glyphs for chinese letters

On Wed, Mar 13, 2024 at 02:25:51PM +0100, Alejandro Colomar wrote: > Hi Deri, > > I've noticed another similar issue, this time with Chinese. You can find the PDF here: <https://www.alejandro-colomar.es/share/dist/shadow/git/HEAD/man/shadow-HEAD_zh_CN.pdf> -- <https://w

[PATCH v3 2/9] [libgroff]: Remove dead code

strtol(3) can only report ERANGE, if the base is valid (and it is). Link: <https://savannah.gnu.org/bugs/?65451> Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Signed-off-by: Alejandro Colomar --- src/libs/libgroff/curtime.cpp | 2 +- 1 file

[PATCH v3 0/9] strtol(3)-related fixes

Hi Branden, Here's a patch set that includes the patches that Dave reminded, the ceil_prime() one, and the fixes for the problems I noticed in your recent commit. I've rebased everything on top of git HEAD. Below is a range-diff. Have a lovely day! Alex Alejandro Colomar (9):

[PATCH v3 3/9] src/: Remove redundant checks after strtol(3).

`str == end` can only happen if strtol(3) returns 0. Link: <https://savannah.gnu.org/bugs/?65451> Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Signed-off-by: Alejandro Colomar --- src/devices/grodvi/dvi.cpp | 4 ++-- src/devices/grolbp/lbp.cp

[PATCH v3 8/9] [indxbib]: Remove dead code

gt; Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Signed-off-by: Alejandro Colomar --- src/utils/indxbib/indxbib.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/utils/indxbib/indxbib.cpp b/src/utils/indxbib/indxbib.cpp index 6253

[PATCH v3 6/9] [indxbib]: Don't else after [[noreturn]]

Link: <https://savannah.gnu.org/bugs/?65452> Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Signed-off-by: Alejandro Colomar --- src/utils/indxbib/indxbib.cpp | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff

[PATCH v3 9/9] [indxbib]: Collapse related tests

Fixes: d7b36a45fc3f ("[indxbib]: Mitigate Savannah #65452.") Link: <https://savannah.gnu.org/bugs/?65452> Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Signed-off-by: Alejandro Colomar --- src/utils/indxbib/indxbib.cpp | 6 +- 1 file

[PATCH v3 5/9] src/: ceil_prime(): Add function to get the lowest prime not smaller than n

Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Signed-off-by: Alejandro Colomar --- src/include/lib.h | 2 +- src/libs/libbib/index.cpp | 4 +--- src/libs/libgroff/prime.cpp | 18 +- src/utils/indxbib/indxbib.cpp | 6 +-

[PATCH v3 4/9] [grolbp]: Remove bogus (and redundant) check

`str == end` can only happen if strtol(3) returns 0. Closes: <https://savannah.gnu.org/bugs/?65451> Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Signed-off-by: Alejandro Colomar --- src/devices/grolbp/lbp.cpp | 2 +- 1 file changed, 1 inserti

[PATCH v3 1/9] [libgroff]: Remove redundant checks.

ERANGE can only happen if strtol(3) returns either LONG_MIN or LONG_MAX. Link: <https://savannah.gnu.org/bugs/?65451> Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Signed-off-by: Alejandro Colomar --- src/libs/libgroff/curtime.cpp | 3 +-- 1 file

[PATCH v3 7/9] [indxbib]: Clear errno before calling strtol(3)

Otherwise, errno may hold ERANGE from before. See strtol(3). Fixes: d7b36a45fc3f ("[indxbib]: Mitigate Savannah #65452.") Link: <https://savannah.gnu.org/bugs/?65452> Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Signed-off-by: Aleja

[PATCH v4 04/10] [grolbp]: Remove bogus (and redundant) check

`str == end` can only happen if strtol(3) returns 0. Closes: <https://savannah.gnu.org/bugs/?65451> Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Werner LEMBERG Signed-off-by: Alejandro Colomar --- src/devices/grolbp/lbp.cpp

[PATCH v4 00/10] strtol(3)-related fixes

no known bugs (admittedly, it's too new for that, but hey, it's just a thin wrapper around strtoi(3), which I fixed recently). Have a lovely day! Alex Alejandro Colomar (10): [libgroff]: Remove redundant checks. [libgroff]: Remove dead

[PATCH v4 05/10] src/: ceil_prime(): Add function to get the lowest prime not less than n

Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Werner LEMBERG Signed-off-by: Alejandro Colomar --- src/include/lib.h | 2 +- src/libs/libbib/index.cpp | 4 +--- src/libs/libgroff/prime.cpp | 18 +- src/utils/ind

[PATCH v4 02/10] [libgroff]: Remove dead code

ot; Cc: Colin Watson Cc: Werner LEMBERG Signed-off-by: Alejandro Colomar --- src/libs/libgroff/curtime.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libs/libgroff/curtime.cpp b/src/libs/libgroff/curtime.cpp index 490fc3018..4623ad9a0 100644 --- a/src/libs/lib

[PATCH v4 07/10] [indxbib]: Clear errno before calling strtol(3)

Otherwise, errno may hold ERANGE from before. See strtol(3). Fixes: d7b36a45fc3f ("[indxbib]: Mitigate Savannah #65452.") Link: <https://savannah.gnu.org/bugs/?65452> Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Wern

[PATCH v4 03/10] src/: Remove redundant checks after strtol(3).

`str == end` can only happen if strtol(3) returns 0. Link: <https://savannah.gnu.org/bugs/?65451> Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Werner LEMBERG Signed-off-by: Alejandro Colomar --- src/devices/grodvi/dvi.cpp

[PATCH v4 08/10] [indxbib]: Remove dead code

gt; Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Werner LEMBERG Signed-off-by: Alejandro Colomar --- src/utils/indxbib/indxbib.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/utils/indxbib/indxbib.cpp b/src/

[PATCH v4 06/10] [indxbib]: Don't else after [[noreturn]]

Link: <https://savannah.gnu.org/bugs/?65452> Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Werner LEMBERG Signed-off-by: Alejandro Colomar --- src/utils/indxbib/indxbib.cpp | 20 1 file changed, 8 i

[PATCH v4 01/10] [libgroff]: Remove redundant checks.

owden" Cc: Colin Watson Cc: Werner LEMBERG Signed-off-by: Alejandro Colomar --- src/libs/libgroff/curtime.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/libs/libgroff/curtime.cpp b/src/libs/libgroff/curtime.cpp index 277755cab..490fc3018 100644 --- a/src/libs/lib

[PATCH v4 09/10] [indxbib]: Collapse related tests

Fixes: d7b36a45fc3f ("[indxbib]: Mitigate Savannah #65452.") Link: <https://savannah.gnu.org/bugs/?65452> Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Werner LEMBERG Signed-off-by: Alejandro Colomar --- src/utils/in

[PATCH v4 10/10] [grolbp]: Fix range check after strtol(3)

ot;G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Werner LEMBERG Signed-off-by: Alejandro Colomar --- src/devices/grolbp/lbp.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/devices/grolbp/lbp.cpp b/src/devices/gro

Re: [PATCH v4 10/10] [grolbp]: Fix range check after strtol(3)

On Sat, Mar 16, 2024 at 12:55:07PM +0100, Alejandro Colomar wrote: > In case INT_MAX==LONG_MAX, we need to check for ERANGE to reject > high values. The test 'n > INT_MAX' would never be true. > > Fixes: d21a9dbc7a83 ("Werner LEMBERG ") Oops, this shou

[PATCH v5 00/10] strtol(3)-related fixes

Hi, This v5 further documents which commits introduced some issues being fixed, and with it, I found James also wrote some of this, so I've also CCed him. See range-diff below. Cheers, Alex Alejandro Colomar (10): [libgroff]: Remove redundant checks. [libgroff]: Remove dead code

[PATCH v5 06/10] [indxbib]: Don't else after [[noreturn]]

Fixes: d7b36a45fc3f ("[indxbib]: Mitigate Savannah #65452.") Link: <https://savannah.gnu.org/bugs/?65452> Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Werner LEMBERG Cc: James Clark Signed-off-by: Alejandro Colomar

[PATCH v5 05/10] src/: ceil_prime(): Add function to get the lowest prime not less than n

lt;https://lists.gnu.org/archive/html/groff/2024-03/msg00065.html> Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Werner LEMBERG Cc: James Clark Signed-off-by: Alejandro Colomar --- src/include/lib.h | 2 +- src/libs/li

[PATCH v5 04/10] [grolbp]: Remove bogus (and redundant) check

`str == end` can only happen if strtol(3) returns 0. Fixes: 98608a8ba037 ("grolbp output device") Link: <https://savannah.gnu.org/bugs/?65451> Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Werner LEMBERG Cc: James Cla

[PATCH v5 01/10] [libgroff]: Remove redundant checks.

owden" Cc: Colin Watson Cc: Werner LEMBERG Cc: James Clark Signed-off-by: Alejandro Colomar --- src/libs/libgroff/curtime.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/libs/libgroff/curtime.cpp b/src/libs/libgroff/curtime.cpp index 277755cab..490fc3018 100644

[PATCH v5 07/10] [indxbib]: Clear errno before calling strtol(3)

ner LEMBERG Cc: James Clark Signed-off-by: Alejandro Colomar --- src/utils/indxbib/indxbib.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/utils/indxbib/indxbib.cpp b/src/utils/indxbib/indxbib.cpp index c5996c279..6253e4782 100644 --- a/src/utils/indxbib/indxbib.cpp +++ b/src/utils/

[PATCH v5 02/10] [libgroff]: Remove dead code

ot; Cc: Colin Watson Cc: Werner LEMBERG Cc: James Clark Signed-off-by: Alejandro Colomar --- src/libs/libgroff/curtime.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libs/libgroff/curtime.cpp b/src/libs/libgroff/curtime.cpp index 490fc3018..4623ad9a0 100644 --- a/src

[PATCH v5 10/10] [grolbp]: Fix range check after strtol(3)

nk: <https://savannah.gnu.org/bugs/?65452> Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Werner LEMBERG Cc: James Clark Signed-off-by: Alejandro Colomar --- src/devices/grolbp/lbp.cpp | 3 ++- 1 file changed, 2 insertions(+), 1

[PATCH v5 08/10] [indxbib]: Remove dead code

gt; Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Werner LEMBERG Cc: James Clark Signed-off-by: Alejandro Colomar --- src/utils/indxbib/indxbib.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/utils/indxbib/

[PATCH v5 03/10] src/: Remove redundant checks after strtol(3).

<https://savannah.gnu.org/bugs/?65451> Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Werner LEMBERG Cc: James Clark Signed-off-by: Alejandro Colomar --- src/devices/grodvi/dvi.cpp | 4 ++-- src/devices/grolbp/lbp.cpp

[PATCH v5 09/10] [indxbib]: Collapse related tests

Fixes: d7b36a45fc3f ("[indxbib]: Mitigate Savannah #65452.") Link: <https://savannah.gnu.org/bugs/?65452> Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Werner LEMBERG Cc: James Clark Signed-off-by: Alejandro Colomar

Use public inbox in groff [was: Remove redundant tests]

[CC += groff@] Hi Andreas, Dave, [This sub-thread started here: <https://lists.gnu.org/archive/html/bug-groff/2024-03/msg00054.html>] On Sat, Mar 16, 2024 at 12:11:08PM -0500, Dave Kemper wrote: > On Sat, Mar 16, 2024 at 5:44 AM Alejandro Colomar wrote: > > Where do I need to

Re: Use public inbox in groff [was: Remove redundant tests]

On Sat, Mar 16, 2024 at 08:37:00PM +0100, Andreas Schwab wrote: > Please contact overse...@sourceware.org. Thanks! Have a lovely night! Alex > -- > Andreas Schwab, sch...@linux-m68k.org > GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 > "And now for something completel

Re: Use public inbox in groff [was: Remove redundant tests]

Hi Branden, On Sat, Mar 16, 2024 at 08:37:00PM +0100, Andreas Schwab wrote: > Please contact overse...@sourceware.org. Branden, I guess it's you who'd need to ask them to do it. Would you mind doing the honours? Have a lovely night! Alex -- signature.asc

Bug#1067022: man2html: Segmentation fault with tzfile(5)

Package: man2html Version: 1.6g-16 Severity: normal Tags: upstream X-Debbugs-Cc: Alejandro Colomar , Paul Eggert , "G. Branden Robinson" , linux-...@vger.kernel.org, groff@gnu.org, t...@iana.org Dear Maintainer, The page tzfile(5) from tzdb-2024a manages to consistently produce a Se

Re: [PATCH v2] tzfile.5: Fix indentation

On Sun, Mar 17, 2024 at 02:24:29PM -0500, G. Branden Robinson wrote: > [looping in groff mailing list to pitch a terminological reform] > > Hi Alex, Hi Banden, > At 2024-03-17T19:56:10+0100, Alejandro Colomar wrote: > > You already gained the first two spaces from the pre

Re: [PATCH v2] tzfile.5: Fix indentation

Hi Branden, On Sun, Mar 17, 2024 at 08:31:55PM +0100, Alejandro Colomar wrote: > Hmmm, I was about to say inset, but double-checked groff_man(7) to be > sure of the exact term, and then I got confused even more: > > $ man groff_man | grep ' \.\(IP\|RS\) \[' > .RS

  1   2   3   4   5   6   7   >