Re: [Groff] PDFPIC macro

2014-09-30 Thread Keith Marshall
On 30/09/14 07:34, Werner LEMBERG wrote: > >>> This is very nice, thanks! For my taste, the comments are a bit >>> excessive, but I guess this is probably only me who thinks so :-) >> >> I've always favoured a verbose commenting style, since I learned to >> write FORTRAN-66, way back in the early

Re: [Groff] PDFPIC macro

2014-09-30 Thread Werner LEMBERG
>> // Private method functions facilitate implementation of >> // the class constructor. >> >> I consider as completely unnecessary, since it is basic C++ >> knowledge how data in the `private' section works. > > In this case, the intent is to emphasize that there is no user, > besides the c

Re: [Groff] PDFPIC macro

2014-09-30 Thread Ralph Corderoy
Hi Keith, First off, thanks for putting the effort in; you're one of the few who's doing that and code wins over codeless argument. That said, I've some complaints that may sway your style. :-) In general, I dislike the verbose comments, both in number and wordiness. Also, vertical space is p