Re: [Groff] understanding groff's source code

2014-09-29 Thread Ralph Corderoy
Hi Ulrich, > In case of questions, should one ask on the list I'd say ask here; answers would be part of the public record. These answers are all based on a quick look; I don't know they're correct. > However, not so for extract(). node *node_list::extract() { node *temp = head

Re: [Groff] understanding groff's source code

2014-09-29 Thread Werner LEMBERG
> I am trying to read and understand groff source code, which is - at > least for me - not easy. In case of questions, should one ask on > the list or are there specialists who are able and willing to help? Please ask here. > And btw. why is node_list in input.cpp but delete_node_list() in > no

Re: [Groff] new automake system

2014-09-29 Thread Werner LEMBERG
> As long as we keep the --with-appresdir option, packagers would not > have extra work. As said previously, Arch linux uses > --with-appresdir=/usr/share/X11/app-defaults, and it seems that > Debian (https://packages.debian.org/jessie/groff) passes > --with-appresdir=/etc/X11/app-defaults to conf

Re: [Groff] understanding groff's source code

2014-09-29 Thread Ulrich Lauther
On Mon, Sep 29, 2014 at 09:05:48AM +0100, Ralph Corderoy wrote: > Hi Ulrich, > > > In case of questions, should one ask on the list > > I'd say ask here; answers would be part of the public record. These > answers are all based on a quick look; I don't know they're correct. > > > However, not

Re: [Groff] PDFPIC macro

2014-09-29 Thread Keith Marshall
On 21/09/14 15:29, Keith Marshall wrote: > On 21/09/14 11:52, Deri James wrote: >> On Sun 21 Sep 2014 06:38:42 Werner LEMBERG wrote: > A good starting point may be to implement a C/C++ library > function, to extract the MediaBox properties; that would open > the gate to a possible pdfbb

Re: [Groff] PDFPIC macro

2014-09-29 Thread Werner LEMBERG
> I've refactored the appropriate code, in src/roff/troff/input.cpp, > with a view to accommodating this; see patch attached. While I've > not yet progressed any implementation for PDF handling, I have > indicated the point at which it should be invoked. Okay to commit, > thus far? This is very

Re: [Groff] PDFPIC macro

2014-09-29 Thread Steffen Nurpmeso
Hello Keith, Keith Marshall wrote: |I've refactored the appropriate code, in src/roff/troff/input.cpp, with |a view to accommodating this; see patch attached. While I've not yet |progressed any implementation for PDF handling, I have indicated the |point at which it should be invoked. Okay

Re: [Groff] PDFPIC macro

2014-09-29 Thread Keith Marshall
On 29/09/14 21:20, Werner LEMBERG wrote: > >> I've refactored the appropriate code, in src/roff/troff/input.cpp, >> with a view to accommodating this; see patch attached. While I've >> not yet progressed any implementation for PDF handling, I have >> indicated the point at which it should be invo

Re: [Groff] PDFPIC macro

2014-09-29 Thread Clarke Echols
I agree with Keith. I've often over the years found my plentiful comments very helpful in going back and reviewing or modifying code. I even comment a lot of my HTML/XHTML work as well as CSS files so I can readily skim what I've created and refresh my memory before attempting useful modificatio

Re: [Groff] new automake system

2014-09-29 Thread Bertrand Garrigues
Werner, On Mon, Sep 29 2014 at 04:55:16 PM, Werner LEMBERG wrote: >> As long as we keep the --with-appresdir option, packagers would not >> have extra work. As said previously, Arch linux uses >> --with-appresdir=/usr/share/X11/app-defaults, and it seems that >> Debian (https://packages.debian.or

Re: [Groff] new automake system

2014-09-29 Thread Werner LEMBERG
> -> So, should I try to support this old behavior (looking for > libX11), or should I directly write something very simple, like > looking for app-defaults in a few defaults directory like > /usr/share/X11, /usr/lib/X11, /etc/X11 (this was my first > intention) ? Note that the possibility

Re: [Groff] PDFPIC macro

2014-09-29 Thread Werner LEMBERG
>> This is very nice, thanks! For my taste, the comments are a bit >> excessive, but I guess this is probably only me who thinks so :-) > > I've always favoured a verbose commenting style, since I learned to > write FORTRAN-66, way back in the early 1970s. Today, with my failing > 60+ year old m