Re: [Groff] new automake system

2014-09-24 Thread Ralph Corderoy
Hi Bertrand, > 'make distcheck' will attempt to make a tarball, untar it, build it > (in out-of-source tree style), clean it, check it, install it and > uninstall it. > > You can use DESTDIR to make the install/uninstall in an ordinary > directory, e.g.: > mkdir ~/tmp > make distcheck DESTDIR

Re: [Groff] Documentation for -mom

2014-09-24 Thread GregExp
Ingo Schwarze wrote: "To mitigate that situation, i think it would help a bit to include a link to http://www.schaffter.ca/mom/mom-04.html (that file name seems a bit awkward; is it stable?) in contrib/mom/groff_mom.man below SEE ALSO." Yes, it would be good to find this link on groff_mom(7). It's

Re: [Groff] Potential buffer overrun in src/roff/troff/input.cpp

2014-09-24 Thread Keith Marshall
On 24/09/14 05:57, Werner LEMBERG wrote: >> I believe I've matched the existing style of code layout, (which >> isn't entirely to my personal taste), but is the comment style >> acceptable? (I've annotated my changes considerably more >> comprehensively than the original). > > I don't really mind

Re: [Groff] Potential buffer overrun in src/roff/troff/input.cpp

2014-09-24 Thread Werner LEMBERG
> Should I also s?\*?/?g, on the lead-in to the function header > comment block, (in addition to introducing each subsequent line with > the C++ style '//')? Even after reading it twice I'm not exactly sure what you mean :-) Please show an example. >>> + * Returns (+ve) number of input character

Re: [Groff] Potential buffer overrun in src/roff/troff/input.cpp

2014-09-24 Thread Keith Marshall
On 24/09/14 10:41, Werner LEMBERG wrote: >> Should I also s?\*?/?g, on the lead-in to the function header >> comment block, (in addition to introducing each subsequent line with >> the C++ style '//')? > > Even after reading it twice I'm not exactly sure what you mean :-) > Please show an example.

Re: [Groff] Potential buffer overrun in src/roff/troff/input.cpp

2014-09-24 Thread Keith Marshall
On 24/09/14 10:41, Werner LEMBERG wrote: >>> What is `+ve'? >> >> I've always understood it to be universally accepted -- at least in >> mathematical, scientific, and engineering circles -- as an >> abbreviation for "positive". > > I'm quite firm in reading such stuff, and up to now I've *never* s

Re: [Groff] new automake system

2014-09-24 Thread Blake McBride
On Wed, Sep 24, 2014 at 12:09 AM, Werner LEMBERG wrote: > > > IMO, if the new make system requires a download of something that is > > already built and installed on my machine, then the new make system > > is significantly worse than using the standard ./configure. > > What Bertrand is working o

Re: [Groff] new automake system

2014-09-24 Thread Blake McBride
On Wed, Sep 24, 2014 at 10:23 AM, Blake McBride wrote: > On Wed, Sep 24, 2014 at 12:09 AM, Werner LEMBERG wrote: > >> >> > IMO, if the new make system requires a download of something that is >> > already built and installed on my machine, then the new make system >> > is significantly worse tha

[Groff] [heirloom] getting dashes when a line is requested

2014-09-24 Thread Blake McBride
Greetings, Using the following: .TS l . _ abcdefghijklmnopqrstuvwxyz .TE In groff, the line is unbroken (as is desired). In heirloom, a bunch of dashes are produced. Each dash is separated by a small space. In other words, groff produced a _line_, and heirloom troff produces a _series of das

Re: [Groff] [heirloom] getting dashes when a line is requested

2014-09-24 Thread Blake McBride
This is true of =, \_, and \= too. On Wed, Sep 24, 2014 at 10:34 AM, Blake McBride wrote: > Greetings, > > Using the following: > > .TS > l . > _ > abcdefghijklmnopqrstuvwxyz > .TE > > > In groff, the line is unbroken (as is desired). In heirloom, a bunch of > dashes are produced. Each dash i

Re: [Groff] [heirloom] getting dashes when a line is requested

2014-09-24 Thread Blake McBride
The same is also true with vertical lines with heirloom tbl. A series of small lines is produces rather than a single line. On Wed, Sep 24, 2014 at 10:41 AM, Blake McBride wrote: > This is true of =, \_, and \= too. > > > On Wed, Sep 24, 2014 at 10:34 AM, Blake McBride > wrote: > >> Greetings

Re: [Groff] [heirloom] getting dashes when a line is requested

2014-09-24 Thread Ralph Corderoy
Hi Blake, > The same is also true with vertical lines with heirloom tbl. A series > of small lines is produces rather than a single line. This seems familiar from long ago. Could it be that if they were ink on paper then they would overlap and join up, but when viewing them on a screen with ant

Re: [Groff] [heirloom] getting dashes when a line is requested

2014-09-24 Thread Blake McBride
Thanks for the input. I'm traveling right now and don't have access to a printer. I'll check when I get back. Also, how does groff get around the problem? Given that most documents are probably viewed via screen these days, and the ugliness of the dashes, I'd think this is important to fix. Th

Re: [Groff] new automake system

2014-09-24 Thread Werner LEMBERG
> Making it more dependent on versions of other software that are > _currently_ available on the Internet means that older copies of > groff will no longer build when those other repositories have moved, > are no longer available, or old versions of those libraries are not > where expected. How o

Re: [Groff] Potential buffer overrun in src/roff/troff/input.cpp

2014-09-24 Thread Werner LEMBERG
> Should it rather become: >> // >> // ps_get_line(): collect an input record from a PostScript file. >> // ... >> // >> static >> int ps_get_line(char *buf, ... > > or: >> //** >> // ps_get_line(): collect an input record from a PostScript file. >> // ... >> // >> static >> int p

Re: [Groff] new automake system

2014-09-24 Thread Blake McBride
Dear Werner, Perhaps I am confused. Let's group users into three categories: 1. users who create documents with an already built groff 2. users who build groff from source 3. users who modify or enhance groff source code - groff developers The type of user I am referring to is number 2. A

Re: [Groff] new automake system

2014-09-24 Thread Werner LEMBERG
> 2. users who build groff from source This is, they are using officially distributed `.tar.gz' archives for compilation and installation (snapshots tarballs of the git repository don't belong to this type). > 3. users who modify or enhance groff source code - groff developers Such people com

Re: [Groff] new automake system

2014-09-24 Thread Ingo Schwarze
Hi Blake, Blake McBride wrote on Wed, Sep 24, 2014 at 12:01:15PM -0500: > Perhaps I am confused. Let's group users into three categories: > > 1. users who create documents with an already built groff > > 2. users who build groff from source > > 3. users who modify or enhance groff source c

Re: [Groff] new automake system

2014-09-24 Thread Ralph Corderoy
Hi Werner, > > 2. users who build groff from source > > This is, they are using officially distributed `.tar.gz' archives for > compilation and installation (snapshots tarballs of the git repository > don't belong to this type). tarballs with configure include official releases; are there any

Re: [Groff] new automake system

2014-09-24 Thread Ingo Schwarze
Hi Ralph, Ralph Corderoy wrote on Tue, Sep 23, 2014 at 11:17:28AM +0100: > Ingo Schwarze wrote: >> - it prefers /usr/local/bin/gsed over /usr/bin/sed >> >> - it prefers /usr/local/bin/bison over /usr/bin/yacc >> >> Prefering the GNU versions over the native POSIX versions is bad >> because it

Re: [Groff] [heirloom] getting dashes when a line is requested

2014-09-24 Thread Carsten Kunze
Blake McBride wrote: > Also, how does groff get around the problem? groff may use a true line where ditroff may use the "_" and "|" characters. > Given that most documents are probably viewed via screen these days, and > the ugliness of the dashes, I'd think this is important to fix. Have you

Re: [Groff] Potential buffer overrun in src/roff/troff/input.cpp

2014-09-24 Thread Keith Marshall
On 24/09/14 17:28, Werner LEMBERG wrote: > Honestly, I would like it to be > > // ps_get_line(): collect an input record from a PostScript file. > // ... > // > static > int ps_get_line(char *buf, ... > Okay. That's how I'll do it, then. (FWIW, for MinGW I normally put the comment b

Re: [Groff] new automake system

2014-09-24 Thread Ulrich Lauther
On Mon, Sep 22, 2014 at 01:17:39AM +0200, Bernd Warken wrote: > I would improve your install commands a bit into: > > test -d old && rm -rf old > test -d groff && mv groff old > git clone git://git.savannah.gnu.org/groff.git > cd groff > git checkout automake2 > ./bootstrap > mkdir build > cd buil

Re: [Groff] new automake system

2014-09-24 Thread Blake McBride
On Wed, Sep 24, 2014 at 12:13 PM, Werner LEMBERG wrote: > > > 2. users who build groff from source > > This is, they are using officially distributed `.tar.gz' archives for > compilation and installation (snapshots tarballs of the git repository > don't belong to this type). > Actually, I belon

Re: [Groff] new automake system

2014-09-24 Thread Bertrand Garrigues
Hi Ralph, On Wed, Sep 24 2014 at 09:31:00 AM, Ralph Corderoy wrote: > Hi Bertrand, > >> 'make distcheck' will attempt to make a tarball, untar it, build it >> (in out-of-source tree style), clean it, check it, install it and >> uninstall it. >> >> You can use DESTDIR to make the install/uninsta

Re: [Groff] [heirloom] getting dashes when a line is requested

2014-09-24 Thread Blake McBride
On Wed, Sep 24, 2014 at 1:38 PM, Carsten Kunze wrote: > Blake McBride wrote: > > > Also, how does groff get around the problem? > > groff may use a true line where ditroff may use the "_" and "|" characters. > > > Given that most documents are probably viewed via screen these days, and > > the u

Re: [Groff] new automake system

2014-09-24 Thread Bertrand Garrigues
Hi Ulrich, On Wed, Sep 24 2014 at 10:52:39 PM, Ulrich Lauther wrote: > I did the bootstrapping as described and then 'make dist' to generate a > groff-1.22.2.tar.gz. > I expanded this file at some other place, went into the new groff-1.22.2 > directory and typed > ./configure --prefix=