Re: [groff] 15/39: [grog]: Drop relic code and comments.

2022-11-02 Thread G. Branden Robinson
[snipping a lot of mutual agreement] At 2022-11-01T00:08:06-0500, Dave Kemper wrote: > I didn't see a one-line "require" as bending over backwards, > but since you pointed out that the version it specified was little > better than a wild guess, I agree it's inappropriate to retain it. Well, _mayb

Re: [groff] 15/39: [grog]: Drop relic code and comments.

2022-10-31 Thread Dave Kemper
On 10/31/22, G. Branden Robinson wrote: > At 2022-10-30T23:41:43-0500, Dave Kemper wrote: >> I'm less convinced by this -- unless a difficult roadblock stands in >> the way, I think modern groff ought to work or fail gracefully on an >> obsolete platform -- but the prior two points are convincing

Re: [groff] 15/39: [grog]: Drop relic code and comments.

2022-10-31 Thread G. Branden Robinson
Hi John, At 2022-10-31T18:23:25+1100, John Gardner wrote: > > Perl 5.6.1 is incredibly old (April 2001). I cannot find any > > evidence of any current distribution supporting it. > > IIRC, declaring a program version is recommended practice, as future > versions of Perl may have different defaul

Re: [groff] 15/39: [grog]: Drop relic code and comments.

2022-10-31 Thread G. Branden Robinson
Hi Dave, At 2022-10-30T23:41:43-0500, Dave Kemper wrote: > On 10/30/22, G. Branden Robinson wrote: > > Perl 5.6.1 is incredibly old (April 2001). I cannot find any > > evidence of any current distribution supporting it. > > I'm less convinced by this -- unless a difficult roadblock stands in >

Re: [groff] 15/39: [grog]: Drop relic code and comments.

2022-10-31 Thread John Gardner
> > Perl 5.6.1 is incredibly old (April 2001). I cannot find any evidence of > any current distribution supporting it. IIRC, declaring a program version is recommended practice, as future versions of Perl may have different defaults w.r.t opt-in behaviours like `use warnings` and `use strict`. T

Re: [groff] 15/39: [grog]: Drop relic code and comments.

2022-10-30 Thread Dave Kemper
On 10/30/22, G. Branden Robinson wrote: > They'll be told at configure time, because we have an Autoconf test for > it. Reasonable. > Furthermore, I've rewritten grog nearly completely since Bernd last > touched it. I don't have any idea what Perl 5.6(.1) features Bernd had > in mind when he ad

Re: [groff] 15/39: [grog]: Drop relic code and comments.

2022-10-30 Thread G. Branden Robinson
At 2022-10-30T21:08:08-0500, G. Branden Robinson wrote: > I'd prefer to audit the script as you describe than to restore this > arcane feature to it; I had to find out about it the hard way. Here's a patch. commit 4acdddb9d4db1c20d7cc4f5f4f0ce2908e20c271 (HEAD -> master) Author: G. Branden Robins

Re: [groff] 15/39: [grog]: Drop relic code and comments.

2022-10-30 Thread G. Branden Robinson
Hi Dave! At 2022-10-30T19:50:38-0500, Dave Kemper wrote: > > commit 6f2e3678366b33ee35cbedf79198c92e88bae29b > > Author: G. Branden Robinson > > AuthorDate: Mon Oct 24 17:08:35 2022 -0500 > > > > [grog]: Drop relic code and comments. > > The comment seems inessential, but I don't believe the

Re: [groff] 15/39: [grog]: Drop relic code and comments.

2022-10-30 Thread Dave Kemper
> commit 6f2e3678366b33ee35cbedf79198c92e88bae29b > Author: G. Branden Robinson > AuthorDate: Mon Oct 24 17:08:35 2022 -0500 > > [grog]: Drop relic code and comments. The comment seems inessential, but I don't believe the two lines of code are relics. > -require v5.6; Pre-5.6 perls are prob