Re: [Groff] Inputfile_caseencapsulation --with-unpack (and --with-zlib) support

2014-08-11 Thread Steffen Nurpmeso
Vaibhaw Pandey wrote: |Steffen, | |I took a shot at reviewing this last week. Turned out I don't have enough |context of the groff code base to be able to do a useful review. I am |currently familiarizing myself with the parts of code to which this review |is pertinent. However, given my cur

Re: [Groff] Inputfile_caseencapsulation --with-unpack (and --with-zlib) support

2014-08-10 Thread Vaibhaw Pandey
Steffen, I took a shot at reviewing this last week. Turned out I don't have enough context of the groff code base to be able to do a useful review. I am currently familiarizing myself with the parts of code to which this review is pertinent. However, given my current abilities and the size of the

Re: [Groff] Inputfile_caseencapsulation --with-unpack (and --with-zlib) support

2014-07-29 Thread Steffen Nurpmeso
Hallo Werner, Werner LEMBERG wrote: |I don't have time to review this. I suggest that you open an |bugtracker issue and post a cleaned-up mbox file for further |inspection. You don't need to review but could just commit it, it is ok by itself. I.e., i would commit it. |It's really time th

Re: [Groff] Inputfile_caseencapsulation --with-unpack (and --with-zlib) support

2014-07-28 Thread Steffen Nurpmeso
So for some more annoyance i'll also post the review tweaks. Brings some consistency and avoids a uselessly large buffer. Everything in the Public Domain, of course. Ciao, --steffen commit b3f543a09f987abacbd13b590cb6b5d1a342c650 Author: Steffen Nurpmeso Date: 2014-07-28 17:46:27 +0200 fil

Re: [Groff] Inputfile_caseencapsulation --with-unpack (and --with-zlib) support

2014-07-28 Thread Steffen Nurpmeso
First: someone messed up the subject when reencoding the message, the correct one would have been Input file_case encapsulation --with-unpack (and --with-zlib) support Sorry. (Don't use Python.) I wrote: [.] | ea111b9 Add GROFF_UNPACK_CHECK m4++ / --with-unpack=XY (Public Domain) | |New