Re: [groff] hyphenation issues (PATCH)

2018-05-07 Thread Werner LEMBERG
> Here is, I think, the third iteration of the patch, taking into > account Ralph's feedback on the length and overworked nature of the > previous iteration's diagnostic messages. LGTM, thanks! Werner

Re: [groff] hyphenation issues (PATCH)

2018-05-07 Thread G. Branden Robinson
At 2018-05-04T19:23:15-0400, G. Branden Robinson wrote: > I've attached a proposed patch. I'm not completely thrilled with it > because some people might interpret it as suggesting that .hy 62 is > valid; it isn't, but not because it is too large. Still, I would prefer > to tell people the limit

Re: [groff] hyphenation issues

2018-05-07 Thread G. Branden Robinson
At 2018-05-06T12:10:13+0100, Ralph Corderoy wrote: > > My debugging instincts tell me to always report the value of an > > argument being rejected. For one thing, the user could have passed > > .hy a register value (possibly with arithmetic manipulation), and if > > we screw up the validity checks